Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053021Openbravo ERP04. Warehouse managementpublic2023-07-21 07:462023-08-22 20:47
ReporterAtulOpenbravo 
Assigned ToAtulOpenbravo 
PrioritynormalSeverityminorReproducibilityalways
StatusscheduledResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053021: [Total stock take] RM7624 There should not be decimal numbers
DescriptionWhen exporting inventory lines with quantities having zeros after decimal point should be exported without decimals numbers.

https://openbravo.atlassian.net/browse/RM-7624 [^]
Steps To Reproduce- Create a total PI
- Make sure there are lines with booked quantity for example 1000.00
- Export stock
- Realize that quantity 1000.00 in the export file instead of 1000
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-07-21 07:46AtulOpenbravoNew Issue
2023-07-21 07:46AtulOpenbravoAssigned To => Triage Omni WMS
2023-07-21 07:46AtulOpenbravoModules => Core
2023-07-21 07:46AtulOpenbravoTriggers an Emergency Pack => No
2023-07-21 07:47AtulOpenbravoAssigned ToTriage Omni WMS => AtulOpenbravo
2023-07-21 07:47AtulOpenbravoStatusnew => scheduled
2023-07-21 07:48AtulOpenbravoNote Added: 0152764
2023-07-21 07:49AtulOpenbravoNote Edited: 0152764bug_revision_view_page.php?bugnote_id=0152764#r26478
2023-07-21 07:54hgbotNote Added: 0152765
2023-07-27 12:44AtulOpenbravoSummary[Total stock take] Lines with stock = 0 should not be exported => [Total stock take] RM7110 Lines with stock = 0 should not be exported
2023-07-27 12:44AtulOpenbravoDescription Updatedbug_revision_view_page.php?rev_id=26526#r26526
2023-08-02 13:03hgbotNote Added: 0153106
2023-08-08 13:15AtulOpenbravoSummary[Total stock take] RM7110 Lines with stock = 0 should not be exported => [Total stock take] RM7624 [Total stock take] There should not be decimal numbers
2023-08-08 13:15AtulOpenbravoDescription Updatedbug_revision_view_page.php?rev_id=26605#r26605
2023-08-08 13:15AtulOpenbravoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=26607#r26607
2023-08-08 13:22AtulOpenbravoSummary[Total stock take] RM7624 [Total stock take] There should not be decimal numbers => [Total stock take] RM7624 There should not be decimal numbers
2023-08-08 13:39hgbotNote Added: 0153334
2023-08-10 13:22hgbotResolutionopen => fixed
2023-08-10 13:22hgbotStatusscheduled => closed
2023-08-10 13:22hgbotNote Added: 0153429
2023-08-10 13:22hgbotFixed in Version => PR23Q4
2023-08-10 13:22hgbotNote Added: 0153430
2023-08-22 20:42AtulOpenbravoStatusclosed => new
2023-08-22 20:42AtulOpenbravoResolutionfixed => open
2023-08-22 20:42AtulOpenbravoFixed in VersionPR23Q4 =>
2023-08-22 20:42AtulOpenbravoStatusnew => scheduled
2023-08-22 20:46AtulOpenbravoNote Added: 0153811
2023-08-22 20:47AtulOpenbravoNote Added: 0153812

Notes
(0152764)
AtulOpenbravo   
2023-07-21 07:48   
(edited on: 2023-07-21 07:49)
Test Plan

- Create a total PI
- Make sure there are lines with booked quantity for example 1000.00 and 1000.256
- Export stock
- Realize that quantity 1000.00 in the export file is 1000 and 1000.256 is as it is.

Same way test when PI is of type Normal.
(0152765)
hgbot   
2023-07-21 07:54   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/949 [^]
(0153106)
hgbot   
2023-08-02 13:03   
Merge request closed: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/949 [^]
(0153334)
hgbot   
2023-08-08 13:39   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/966 [^]
(0153429)
hgbot   
2023-08-10 13:22   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/966 [^]
(0153430)
hgbot   
2023-08-10 13:22   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 237b5c9833d978db5778304d6d55f8650913d8ab
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 10-08-2023 13:22:24
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/237b5c9833d978db5778304d6d55f8650913d8ab [^]

Fixes BUG-0053021: [Total stock take] RM7624 There should not be
decimal numbers

**When exporting PI lines consider bookedqty and QtyCount as
BigInteger in case bigdecimal value has trailing zeros after
decimal else keep bigdecimal value as it is.

---
M src/org/openbravo/common/actionhandler/ExportPhysicalInventoryLinesToCSV.java
---
(0153811)
AtulOpenbravo   
2023-08-22 20:46   
Test in SMCP Instance

Test Plan

- Create a total PI
- Make sure there are lines with booked quantity for example 1000.00 and 1000.256
- Export stock
- Realize that quantity 1000.00 in the export file is 1000 and 1000.256 is as it is.

Same way test when PI is of type Normal.
(0153812)
AtulOpenbravo   
2023-08-22 20:47   
MR >>

https://gitlab.com/openbravo/customers/SMCP/com.openbravo.smcp.warehouse/-/merge_requests/25/ [^]