Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052963ModulesRemittancepublic2023-07-13 23:492023-09-06 13:28
Reporteraxelmercado 
Assigned Tojamie_reid 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0052963: Error in remittances and cancellation of invoices
DescriptionMessage from Practics: we find that we make a vendor invoice, include it in a remittance and then void the invoice and the voided invoice (the negative one) is paid.

On some occasions/customers. The negative invoice offsets it against the positive invoice.

You will see in the following video that it generates a payment in negative that under our point of view and of the client is not correct, since operationally you see that the invoice is paid and it is not... the supplier owes it to us.


CSU has analyzed it and we believe this is wrong, it could be a bug?
Steps To ReproduceVideo with the steps (In Spanish): https://drive.google.com/file/d/167KYJVszplyWLjoCY-6bNg_kcsrsxA9c/view [^]

With the basic remittance configuration provided in the wiki in the F&B client perform the following actions:
1 - Create an invoice in the 'Purchase Invoice' window with a remittance-capable payment method or 'Remittance' and complete it.
2 - In the 'Remittance" window, create a new remittance. Add the previously created invoice from the 'Select Orders or Invoices" button and process the remittance.
3 - Go to the invoice created, from the button 'Reactivate' proceed to cancel it, selecting the option "Void".
4 - Verify that a new cancellation invoice is created, it appears as paid when the original one is not. If we verify the details of your payments, we will find a payment in negative, if we browse it, we will see that the amount is 0 and a negative credit is generated that the business partner never gets.
Proposed SolutionThe invoice should not be paid and if not, a credit should be generated for the user that can be used in other invoices.

Update: When a non-remitted invoice is cancelled and is not paid, it becomes paid since the cancellation invoice contains the negative payment.
If we browse the payments, we can see that they are cleared.

See screenshot.
Additional Information
TagsNo tags attached.
Relationships
related to defect 00309713.0PR16Q1 closed aferraz Openbravo ERP When voiding an unpaid invoice, payment schedule details should be canceled instead of deleted 
related to defect 0054641 closed Triage Omni OMS Modules Error in remittances in status "Liquidated in Remittance" and cancellation of invoices 
Attached Filespng screenshot.png (118,419) 2023-08-07 21:22
https://issues.openbravo.com/file_download.php?file_id=18850&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2023-07-13 23:49axelmercadoNew Issue
2023-07-13 23:49axelmercadoAssigned To => Triage Omni OMS
2023-07-14 08:27PracticsIssue Monitored: Practics
2023-07-14 10:04aferrazAssigned ToTriage Omni OMS => jamie_reid
2023-07-24 15:52axelmercadoNote Added: 0152850
2023-07-24 15:52axelmercadoPriorityhigh => urgent
2023-08-02 09:37hgbotNote Added: 0153090
2023-08-07 21:21axelmercadoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=26596#r26596
2023-08-07 21:21axelmercadoProposed Solution updated
2023-08-07 21:22axelmercadoFile Added: screenshot.png
2023-09-06 12:00aferrazRelationship addedrelated to 0030971
2023-09-06 13:21hgbotNote Added: 0154545
2023-09-06 13:21hgbotResolutionopen => fixed
2023-09-06 13:21hgbotStatusnew => closed
2023-09-06 13:21hgbotNote Added: 0154546
2023-09-06 13:28psanjuanNote Added: 0154547
2023-09-06 14:04psanjuanNote Edited: 0154547bug_revision_view_page.php?bugnote_id=0154547#r26783
2024-02-09 20:46axelmercadoRelationship addedrelated to 0054641

Notes
(0152850)
axelmercado   
2023-07-24 15:52   
Hi team, any news?
(0153090)
hgbot   
2023-08-02 09:37   
Merge Request created: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance/-/merge_requests/12 [^]
(0154545)
hgbot   
2023-09-06 13:21   
Merge request merged: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance/-/merge_requests/12 [^]
(0154546)
hgbot   
2023-09-06 13:21   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance [^]
Changeset: fd68aac768b1503346832af16ace3170182ec964
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 06-09-2023 11:19:56
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance/-/commit/fd68aac768b1503346832af16ace3170182ec964 [^]

Fixes ISSUE-52963: Do not allow to void an invoice if there is a related remitted payment

---
A src/org/openbravo/module/remittance/hooks/REMProcessInvoiceHook.java
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/module/remittance/ad_forms/CancelReturnRemittance.java
---
(0154547)
psanjuan   
2023-09-06 13:28   
(edited on: 2023-09-06 14:04)
Proposed solution:

As any other payment method waiting to be executed it will not be possible to directly void an invoice included in a remittance.

Openbravo will show an error message saying that the remittance in which the invoice is include needs to be either settled or protested.
Once that action is executed, it will be possible to void that invoice.