Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052923POS2POSpublic2023-07-05 07:002023-08-18 08:35
Reportersreehari 
Assigned ToRajesh_18 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052923: No Validation for line Discounts when modifying discount percentage
DescriptionWhen applying a discount for a line product, and trying to modify the discount % or the discount amount, it gets applied whatever the value is.

Attaching a video link FYR : https://drive.google.com/file/d/1xHhmvjSjomlDUT2WS69rLebaa3BTXuN7/view?usp=sharing [^]

Steps To Reproduce1. Add some products to the ticket
2. Click on the product line to apply the discount
3. Select any available variable discount & try to modify the discount % or the discount amount
4. The maximum discount gets applied even if its greater than 100%, also in case of amount it gets applied even if the discounted amount is more than the value of the product.
Proposed SolutionThere should be validation to check for discount percentage greater than 0% and less than or equal to 100%.

Also, in case of variable amount, there should be validation to check for the product price & discount price
Additional Information
TagsNo tags attached.
Relationships
duplicate of defect 0050739 scheduled Rajesh_18 Discount is not properly applied when user defined discount is applied 
related to defect 0053027 closed Rajesh_18 [23Q3] Receipt Properties button is not shown in a Return order 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-07-05 07:00sreehariNew Issue
2023-07-05 07:00sreehariAssigned To => Retail
2023-07-05 07:00sreehariTriggers an Emergency Pack => No
2023-08-10 08:21Rajesh_18Assigned ToRetail => Rajesh_18
2023-08-10 08:22Rajesh_18Statusnew => scheduled
2023-08-11 08:29hgbotNote Added: 0153439
2023-08-18 08:35hgbotResolutionopen => fixed
2023-08-18 08:35hgbotStatusscheduled => closed
2023-08-18 08:35hgbotFixed in Version => 23Q4
2023-08-18 08:35hgbotNote Added: 0153644
2023-08-18 08:35hgbotNote Added: 0153645
2023-08-31 14:37Rajesh_18Relationship addedduplicate of 0050739
2023-09-05 13:10sreehariRelationship addedrelated to 0053027

Notes
(0153439)
hgbot   
2023-08-11 08:29   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2009 [^]
(0153644)
hgbot   
2023-08-18 08:35   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 161b0c9c2317e23dd7833750759d6187e9ca7463
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 18-08-2023 06:35:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/161b0c9c2317e23dd7833750759d6187e9ca7463 [^]

Fixes ISSUE-52923: Validation for line Discounts when modifying discount. Discounts greater than 100% will not be possible to be applied.

---
M web-jspack/org.openbravo.pos2/src/components/ButtonBar1/ButtonBar1-DraftReturn.config.json
M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/ApplyDiscountButton/ApplyDiscountButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountInputAmountCell/DiscountInputAmountCell.jsx
---
(0153645)
hgbot   
2023-08-18 08:35   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2009 [^]