Openbravo Issue Tracking System - POS2
View Issue Details
0052881POS2POSpublic2023-05-31 09:292023-07-11 23:32
noemieroussel 
ranjith_qualiantech_com 
highmajorhave not tried
closedfixed 
5
 
23Q3 
Packaging and release
2022-10-04
https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/d6a1d4f03f0a48eaa5793b783e45ce3c70c13f5e [^]
No
0052881: Pos 2: promotions wrongly configured block the access to the WebPOS
When we configure a promotion wrongly, the expected behavior is to have an error message in Back Office when activating a promotion where a mandatory filter is missing (for Combo for example, the error occurs when there is no record registered in Family subtab), but not in the WEBPOS.

If I configure a promotion with an error or a missing filter, I should still be able to log in to WebPOS and do a sale, and the promotion that is not correctly set up will not be available.

We need to know which configuration can cause this blocking error.
Go to the backoffice

Create a new record in "Discounts and Promotions" : a Combo promotion without adding family. Set it as active.

Try to enter in the WebPOS. -> POS can't be opened

Then, go to the backoffice and deactivate the promotion.

Go to the POS and refresh, see that POS is now accesible.

Go to the backoffice and activate the promotion.

Go to the POS and refresh, see that POS is now unaccesible.
We need to know which configuration can cause this blocking error.
No tags attached.
blocks defect 0052618 closed ranjith_qualiantech_com Pos 2: promotions wrongly configured block the access to the WebPOS 
Issue History
2023-06-29 06:50ranjith_qualiantech_comTypedefect => backport
2023-06-29 06:50ranjith_qualiantech_comTarget Version => 23Q3
2023-07-11 14:14hgbotNote Added: 0152318
2023-07-11 14:14hgbotNote Added: 0152319
2023-07-11 14:14hgbotNote Added: 0152320
2023-07-11 23:31hgbotNote Added: 0152358
2023-07-11 23:31hgbotNote Added: 0152359
2023-07-11 23:32hgbotNote Added: 0152360
2023-07-11 23:32hgbotNote Added: 0152361
2023-07-11 23:32hgbotResolutionopen => fixed
2023-07-11 23:32hgbotStatusscheduled => closed
2023-07-11 23:32hgbotNote Added: 0152362
2023-07-11 23:32hgbotNote Added: 0152363

Notes
(0152318)
hgbot   
2023-07-11 14:14   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/34 [^]
(0152319)
hgbot   
2023-07-11 14:14   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1168 [^]
(0152320)
hgbot   
2023-07-11 14:14   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/567 [^]
(0152358)
hgbot   
2023-07-11 23:31   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: a6f5f86969281035c281a771a7887ecaa5e180a1
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 11-07-2023 15:22:23
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/a6f5f86969281035c281a771a7887ecaa5e180a1 [^]

Related to ISSUE-52881: Error should be handled when loading terminal data

---
M web-jspack/org.openbravo.core2/src/core/terminal/TerminalDataMasterdataHooks.js
---
(0152359)
hgbot   
2023-07-11 23:31   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1168 [^]
(0152360)
hgbot   
2023-07-11 23:32   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 64c493459b784adc3087c1556531d979000b290e
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 11-07-2023 21:32:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/64c493459b784adc3087c1556531d979000b290e [^]

Related to ISSUE-52881: Removed recursion function in MasterData hooks

---
M web/org.openbravo.mobile.core/app/model/masterdata/MasterdataController.js
---
(0152361)
hgbot   
2023-07-11 23:32   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/567 [^]
(0152362)
hgbot   
2023-07-11 23:32   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 201b7d76e5f8d908366d300f0b3923f87a3cf3aa
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 11-07-2023 21:32:12
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/201b7d76e5f8d908366d300f0b3923f87a3cf3aa [^]

Fixed ISSUE-52881: Added InitialValidation for ComboFixedPrice discount

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/discounts/combo/master/DiscountComboValidation.java
---
(0152363)
hgbot   
2023-07-11 23:32   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/34 [^]