0052830: There should be no mentions of UserActions in mobile.core (TerminalLogEventProcessor)

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0052830

Retail Modules

Web POS

public

2023-06-22 14:05

2023-06-22 14:11

Reporter

cberner

Assigned To

Retail

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0052830: There should be no mentions of UserActions in mobile.core (TerminalLogEventProcessor)

Description

There are mentions of UserActions in TerminalLogEventProcessor.java to allow processing log of different types for user actions. This should not be there, as that doesn't exist in mobile.core or the modules that this one extends.

This logic should be made extendable and we should be able to add extra log types to be processed by terminal log from other modules.

Keeping the current behaviour means that each time a new terminal log user action type is added to core2/pos2, we would have a problem because it is not part of TerminalLogEventProcessor and will result in it not being properly handled or saved.

TerminalLogEventProcessor: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/0dc40b12e05dd8ed9d15cdde7a8c672ae2a69de7/src/org/openbravo/mobile/core/terminallog/TerminalLogEventProcessor.java#L121 [^]

Steps To Reproduce

Proposed Solution

Additional Information