Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052829Retail ModulesWeb POSpublic2023-06-22 12:092024-05-22 12:51
Reporterranjith_qualiantech_com 
Assigned Toradhakrishnan 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052829: TwoFamiliesCombo junit tests are not included in ci
DescriptionTwoFamiliesCombo junit tests are not included in ci
Steps To ReproduceCheck ci try-retail nightly build.
TwoFamiliesCombo junit tests are not executed
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0051189 closed ranjith_qualiantech_com Discount amount is more than Line amount when applying Two Families Discount 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-06-22 12:09ranjith_qualiantech_comNew Issue
2023-06-22 12:09ranjith_qualiantech_comAssigned To => Triage Omni OMS
2023-06-22 12:09ranjith_qualiantech_comTriggers an Emergency Pack => No
2023-06-22 12:16aferrazRelationship addedrelated to 0051189
2023-07-05 07:18radhakrishnanAssigned ToTriage Omni OMS => radhakrishnan
2023-07-05 07:18radhakrishnanStatusnew => scheduled
2023-07-13 09:21hgbotNote Added: 0152426
2023-07-13 09:23hgbotNote Added: 0152427
2023-07-13 09:30hgbotNote Added: 0152428
2024-05-22 12:50hgbotNote Added: 0164964
2024-05-22 12:50hgbotResolutionopen => fixed
2024-05-22 12:50hgbotStatusscheduled => closed
2024-05-22 12:50hgbotNote Added: 0164965
2024-05-22 12:51hgbotNote Added: 0164966
2024-05-22 12:51hgbotNote Added: 0164967
2024-05-22 12:51hgbotNote Added: 0164968
2024-05-22 12:51hgbotNote Added: 0164969

Notes
(0152426)
hgbot   
2023-07-13 09:21   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/37 [^]
(0152427)
hgbot   
2023-07-13 09:23   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discount.twofamiliescombo/-/merge_requests/5 [^]
(0152428)
hgbot   
2023-07-13 09:30   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.discounts.tests/-/merge_requests/6 [^]
(0164964)
hgbot   
2024-05-22 12:50   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.discounts.tests/-/merge_requests/6 [^]
(0164965)
hgbot   
2024-05-22 12:50   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.discounts.tests [^]
Changeset: a9e154a482ac9b8ef2c0fdfdcd92afed79789cc6
Author: Radhakrishnan Seeman <radhakrishnan.seeman.ext@openbravo.com>
Date: 22-05-2024 10:50:47
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.discounts.tests/-/commit/a9e154a482ac9b8ef2c0fdfdcd92afed79789cc6 [^]

Fixes ISSUE-52829: Added twofamiliescombo test suite to CI

---
M src-test/org/openbravo/retail/discounts/tests/DiscountsMainTestSuite.java
---
(0164966)
hgbot   
2024-05-22 12:51   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discount.twofamiliescombo [^]
Changeset: b2811143dd579ddeb7c6897ad90eea70847157f3
Author: Radhakrishnan Seeman <radhakrishnan.seeman.ext@openbravo.com>
Date: 22-05-2024 10:50:59
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discount.twofamiliescombo/-/commit/b2811143dd579ddeb7c6897ad90eea70847157f3 [^]

Related to ISSUE-52829: Changed the family name in order to apply discount properly

---
M src-test/org/openbravo/discount/twofamiliescombo/test/unittests/I32421_TwoFamiliesWithSameProductTest.java
M src-test/org/openbravo/discount/twofamiliescombo/test/unittests/I32526_TwoFamiliesWithSameTwoProductsTest.java
M web/org.openbravo.retail.discount.twofamiliescombo/app/model/business-logic/discounts-engine/engine/rules/two-families-combo-discount.js
---
(0164967)
hgbot   
2024-05-22 12:51   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discount.twofamiliescombo/-/merge_requests/5 [^]
(0164968)
hgbot   
2024-05-22 12:51   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 1e5ff82797123a9b69dc5362aa0670b3635d14cc
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 21-05-2024 10:16:57
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/1e5ff82797123a9b69dc5362aa0670b3635d14cc [^]

Related to ISSUE-52829: ComboProductFamily should be order by name

---
M src/org/openbravo/retail/discounts/combo/ComboDataHook.java
---
(0164969)
hgbot   
2024-05-22 12:51   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/37 [^]