Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052815POS2Corepublic2023-06-21 12:562023-06-28 12:58
Reporteralostale 
Assigned ToTriage Platform Base 
PriorityimmediateSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version23Q2.2Fixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression levelProduction - QA Approved
Regression date2023-06-03
Regression introduced in release23Q2
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/2790803e6a83e03ba0aec4f05009f236d32c8102 [^]
Triggers an Emergency PackNo
Summary0052815: error saving "afc" terminal log
DescriptionWhen using pos2 some terminal log does not get properly inserted in DB.
Steps To ReproduceIt can be seen in openbravo.log from livebuilds pos2 there are logs like:

 WARN org.openbravo.mobile.core.terminallog.TerminalLogEventProcessor - Event afc no supported
 ERROR org.openbravo.mobile.core.terminallog.StoreTerminalLogEventInDatabase - Could not save UserEvent log with info: ...

For example, one of the problematic events would be:

{
 "d": 1687340787953,
 "o": true,
 "n": "OBPOS2_DeleteTicket",
 "e": "action",
 "c": "792CD0206CBEEFA0BAB837F8AA9F3BBF",
 "i": "userActionsInProgress: [\"OBPOS2_DeleteTicket\"]",
 "t": "afc"
}
Proposed SolutionImplement afc event type in TerminalLogEventProcessor [1].

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/d4a4e06f137cc0450d95fdded7191f1529f9480d/src/org/openbravo/mobile/core/terminallog/TerminalLogEventProcessor.java#L150 [^]
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0052814 closed Triage Platform Base error saving "afc" terminal log 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-06-21 13:00alostaleTypedefect => backport
2023-06-21 13:00alostaleTarget Version => 23Q2.2
2023-06-22 09:32hgbotMerge Request Status => open
2023-06-22 09:32hgbotNote Added: 0151477
2023-06-22 14:10hgbotMerge Request Statusopen => approved
2023-06-28 12:58hgbotNote Added: 0151747
2023-06-28 12:58hgbotResolutionopen => fixed
2023-06-28 12:58hgbotStatusscheduled => closed
2023-06-28 12:58hgbotFixed in Version => RR23Q2.2
2023-06-28 12:58hgbotNote Added: 0151748

Notes
(0151477)
hgbot   
2023-06-22 09:32   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/557 [^]
(0151747)
hgbot   
2023-06-28 12:58   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/557 [^]
(0151748)
hgbot   
2023-06-28 12:58   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: b9e8fa55fcc250ab586cbe0e8c6f0cccb1913992
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 22-06-2023 14:09:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/b9e8fa55fcc250ab586cbe0e8c6f0cccb1913992 [^]

Fixes ISSUE-52815: User action cancellation messages are not being stored in logclient

The search key of those messages (afc) were not being taken into account, and those messages where being discarded

Also adds a commentary to explain usage of user actions in mobile.core,
which shouldn't be present here.

---
M src/org/openbravo/mobile/core/terminallog/TerminalLogEventProcessor.java
---