Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052814POS2Corepublic2023-06-21 12:562023-06-28 12:57
Reporteralostale 
Assigned ToTriage Platform Base 
PriorityimmediateSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date2023-06-03
Regression introduced in release23Q2
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/2790803e6a83e03ba0aec4f05009f236d32c8102 [^]
Triggers an Emergency PackNo
Summary0052814: error saving "afc" terminal log
DescriptionWhen using pos2 some terminal log does not get properly inserted in DB.
Steps To ReproduceIt can be seen in openbravo.log from livebuilds pos2 there are logs like:

 WARN org.openbravo.mobile.core.terminallog.TerminalLogEventProcessor - Event afc no supported
 ERROR org.openbravo.mobile.core.terminallog.StoreTerminalLogEventInDatabase - Could not save UserEvent log with info: ...

For example, one of the problematic events would be:

{
 "d": 1687340787953,
 "o": true,
 "n": "OBPOS2_DeleteTicket",
 "e": "action",
 "c": "792CD0206CBEEFA0BAB837F8AA9F3BBF",
 "i": "userActionsInProgress: [\"OBPOS2_DeleteTicket\"]",
 "t": "afc"
}
Proposed SolutionImplement afc event type in TerminalLogEventProcessor [1].

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/d4a4e06f137cc0450d95fdded7191f1529f9480d/src/org/openbravo/mobile/core/terminallog/TerminalLogEventProcessor.java#L150 [^]
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005281523Q2.2 closed Triage Platform Base POS2 error saving "afc" terminal log 
caused by feature request 0051274 closed gdagnesses POS2 Improve log when a user action is cancelled 
related to design defect 0052830 new Retail Retail Modules There should be no mentions of UserActions in mobile.core (TerminalLogEventProcessor) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-06-21 12:56alostaleNew Issue
2023-06-21 12:56alostaleAssigned To => Triage Platform Base
2023-06-21 12:56alostaleTriggers an Emergency Pack => No
2023-06-21 12:58alostaleRegression level => Production - QA Approved
2023-06-21 12:58alostaleRegression date => 2023-06-03
2023-06-21 12:58alostaleRegression introduced in release => 23Q2
2023-06-21 12:58alostaleRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/2790803e6a83e03ba0aec4f05009f236d32c8102 [^]
2023-06-21 12:58alostalePrioritynormal => immediate
2023-06-21 12:58alostaleSeveritymajor => minor
2023-06-21 12:59alostaleRelationship addedcaused by 0051274
2023-06-21 13:00alostaleStatusnew => scheduled
2023-06-22 00:06hgbotNote Added: 0151466
2023-06-22 14:11cbernerRelationship addedrelated to 0052830
2023-06-28 12:57hgbotResolutionopen => fixed
2023-06-28 12:57hgbotStatusscheduled => closed
2023-06-28 12:57hgbotNote Added: 0151745
2023-06-28 12:57hgbotFixed in Version => RR23Q4
2023-06-28 12:57hgbotNote Added: 0151746

Notes
(0151466)
hgbot   
2023-06-22 00:06   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/556 [^]
(0151745)
hgbot   
2023-06-28 12:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/556 [^]
(0151746)
hgbot   
2023-06-28 12:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 8d83b4c4535983d3ef6989111535cbcb873f2369
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 28-06-2023 10:57:31
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/8d83b4c4535983d3ef6989111535cbcb873f2369 [^]

Fixes ISSUE-52814: User action cancellation messages are not being stored in logclient

The search key of those messages (afc) were not being taken into account, and those messages where being discarded

Also adds a commentary to explain usage of user actions in mobile.core,
which shouldn't be present here.

---
M src/org/openbravo/mobile/core/terminallog/TerminalLogEventProcessor.java
---