Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052761POS2Corepublic2023-06-15 22:142023-08-04 15:52
Reporterjarmendariz 
Assigned Tojarmendariz 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q4 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052761: Full Refresh Throttling
DescriptionServer should be able to tell a Terminal that it should log in in Offline mode, so the service worker should not update the terminal's sources and the masterdata should not change.

This feature could be used to limit by Organization the number of terminals that are refreshing (either their sources or masterdata) at the same time, and can be monitored via a JMX endpoint.
Steps To ReproduceSee description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate feature request 0049857 closed jarmendariz Full Refresh Throttling 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-06-15 22:14jarmendarizNew Issue
2023-06-15 22:14jarmendarizAssigned To => jarmendariz
2023-06-15 22:14jarmendarizOBNetwork customer => No
2023-06-15 22:14jarmendarizTriggers an Emergency Pack => No
2023-06-15 22:14jarmendarizStatusnew => scheduled
2023-06-19 12:22hgbotMerge Request Status => open
2023-06-19 12:22hgbotNote Added: 0151293
2023-06-19 12:46hgbotNote Added: 0151299
2023-07-19 23:28hgbotNote Added: 0152675
2023-08-04 07:52hgbotMerge Request Statusopen => approved
2023-08-04 08:54jarmendarizRelationship addedhas duplicate 0049857
2023-08-04 14:03hgbotNote Added: 0153233
2023-08-04 14:03hgbotNote Added: 0153234
2023-08-04 14:04hgbotNote Added: 0153235
2023-08-04 14:04hgbotNote Added: 0153236
2023-08-04 14:07hgbotResolutionopen => fixed
2023-08-04 14:07hgbotStatusscheduled => closed
2023-08-04 14:07hgbotFixed in Version => 23Q4
2023-08-04 14:07hgbotNote Added: 0153241
2023-08-04 14:07hgbotNote Added: 0153242
2023-08-04 15:52hgbotNote Added: 0153254

Notes
(0151293)
hgbot   
2023-06-19 12:22   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1139 [^]
(0151299)
hgbot   
2023-06-19 12:46   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/555 [^]
(0152675)
hgbot   
2023-07-19 23:28   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1966 [^]
(0153233)
hgbot   
2023-08-04 14:03   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 8b68a41fab9fba563f6d0c59e64b4b91d5a4a87a
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 04-08-2023 12:03:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/8b68a41fab9fba563f6d0c59e64b4b91d5a4a87a [^]

Related to ISSUE-52761: Adding terminal name to check server status params

---
M web/org.openbravo.mobile.core/app/integration/remote-server/BackendServer.js
---
(0153234)
hgbot   
2023-08-04 14:03   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/555 [^]
(0153235)
hgbot   
2023-08-04 14:04   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c0da6c148915acf8f1ecee27f7fdfbb0f061b387
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 04-08-2023 14:04:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c0da6c148915acf8f1ecee27f7fdfbb0f061b387 [^]

Related to ISSUE-52761: Full Refresh Throttling

---
A src-test/org/openbravo/pos2/utility/CheckTerminalFullRefreshTest.java
A src/org/openbravo/pos2/login/POS2LoginHandlerAdditionalResponse.java
A src/org/openbravo/pos2/login/TerminalForceOfflineCheck.java
A src/org/openbravo/pos2/master/JmxFullMasterdataRefresh.java
A src/org/openbravo/pos2/master/JmxFullMasterdataRefreshMBean.java
A src/org/openbravo/pos2/service/FullRefreshFinish.java
A src/org/openbravo/pos2/service/FullRefreshStart.java
A src/org/openbravo/pos2/service/TerminalFullRefreshStartTimeUpdate.java
A src/org/openbravo/pos2/utility/CheckTerminalFullRefresh.java
A web-jspack/org.openbravo.pos2/src/core/masterdata/registerFullMasterdataRefreshNotificationHook.js
M src-db/database/model/modifiedTables/AD_ORG.xml
M src-db/database/model/modifiedTables/OBPOS_APPLICATIONS.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
M src-test/org/openbravo/pos2/StandaloneTestSuite.java
M src/org/openbravo/pos2/POS2Initializer.java
M src/org/openbravo/pos2/login/POS2LoginUtilsServlet.java
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0153236)
hgbot   
2023-08-04 14:04   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1966 [^]
(0153241)
hgbot   
2023-08-04 14:07   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: decaae25d24a62dc52ae6ee56da626d09e80595c
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 04-08-2023 14:04:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/decaae25d24a62dc52ae6ee56da626d09e80595c [^]

Fixed ISSUE-52761: Full Refresh Throttling

This project adds the following features:
- Control application's sources upgrade: Sources can only be updated after a successful online login
- Control Terminal's online/offline status
- Limit amount of simultaneous terminals fully refreshing Masterdata per Organization
- JMX endpoint to monitor terminals fully refreshing masterdata in realtime

---
M web-jspack/org.openbravo.core2/src/core/authentication/InitializeAppData.js
M web-jspack/org.openbravo.core2/src/core/authentication/LoginProcess.js
M web-jspack/org.openbravo.core2/src/core/authentication/RestoreSession.js
M web-jspack/org.openbravo.core2/src/registerServiceWorker.js
M web-jspack/org.openbravo.core2/src/serviceWorkerRegistration.js
---
(0153242)
hgbot   
2023-08-04 14:07   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1139 [^]
(0153254)
hgbot   
2023-08-04 15:52   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: aa11fd523d23840ce0fa8807dad77171c9f28f2d
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 04-08-2023 15:49:57
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/aa11fd523d23840ce0fa8807dad77171c9f28f2d [^]

Related to ISSUE-52761: Fixed unit test

CheckServerAvailability request responds with an JSON object that contains a response object.
In case there is an error, the response would be as follows: { response: { error: 'msg'}}.
Up to now it is not usual to receive an error message from server, but in this project does and we
discovered that the message was not correctly extracted from the response. This change caused this test
to fail.

---
M web-test/integration/remote-server/BackendServer.test.js
---