Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052737POS2POSpublic2023-06-13 17:492023-06-20 16:14
Reporterrafaroda 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052737: Cashup is possible even with ticket with payments (without ticket lines)
DescriptionCashup is possible even with ticket with payments (without ticket lines)

This shoudl NOT be allowed and you should have the same message display that you have when trying cashup with tickets with lines

See video https://drive.google.com/file/d/1wFtqtQhgpi_q5pAakjy2w8IMbGHshBgi/view?usp=drive_link [^]
Steps To ReproduceSee video https://drive.google.com/file/d/1wFtqtQhgpi_q5pAakjy2w8IMbGHshBgi/view?usp=drive_link [^]

In Live Builds https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql/web/pos/?terminal=VBS-2 [^]
1) Create a ticket in POS 2 and add some lines
2) Click in Menu > Close Till: you have a message saying "There are pending receipts, cashup can not be started": this is correct OK
3) Add some payment in cash, and come back to the ticket
4) delete the 2 lines
5) Click on Menu > Close Till: youa re able to start the cashup, this is KO incorrect
Proposed SolutionIn Step 5 you should have the exact same message than in Step 2 saying There are pending receipts, cashup can not be started"
Additional Information
TagsNo tags attached.
Relationships
related to defect 0052539 closed sreehari POS2 RM-6309 Overpayment Not Allowed: this condition is not properly evaluated in the case of removing products 
related to defect 0052209 closed ranjith_qualiantech_com Retail Modules POS Payment error when finishing a cashup 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-06-13 17:49rafarodaNew Issue
2023-06-13 17:49rafarodaAssigned To => Retail
2023-06-13 17:49rafarodaOBNetwork customer => No
2023-06-13 17:49rafarodaTriggers an Emergency Pack => No
2023-06-13 17:49rafarodaRelationship addedrelated to 0052539
2023-06-14 09:08rafarodaOBNetwork customerNo => Gold
2023-06-15 11:38ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2023-06-15 11:38ranjith_qualiantech_comStatusnew => scheduled
2023-06-15 12:05ranjith_qualiantech_comRelationship addedrelated to 0052209
2023-06-20 14:38hgbotMerge Request Status => open
2023-06-20 14:38hgbotNote Added: 0151383
2023-06-20 14:38hgbotNote Added: 0151384
2023-06-20 16:13hgbotMerge Request Statusopen => approved
2023-06-20 16:14hgbotNote Added: 0151392
2023-06-20 16:14hgbotNote Added: 0151393
2023-06-20 16:14hgbotResolutionopen => fixed
2023-06-20 16:14hgbotStatusscheduled => closed
2023-06-20 16:14hgbotFixed in Version => 23Q3
2023-06-20 16:14hgbotNote Added: 0151394
2023-06-20 16:14hgbotNote Added: 0151395

Notes
(0151383)
hgbot   
2023-06-20 14:38   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1253 [^]
(0151384)
hgbot   
2023-06-20 14:38   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1907 [^]
(0151392)
hgbot   
2023-06-20 16:14   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1253 [^]
(0151393)
hgbot   
2023-06-20 16:14   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: df0799cd8db109767d75a899c98b199eb77a6de1
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 20-06-2023 14:13:58
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/df0799cd8db109767d75a899c98b199eb77a6de1 [^]

Related to ISSUE-52737: Added getPendingTickets Util method
* When switching to cashup window, event should be prevented
  if pos has pending tickets across sessions

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket-list/TicketListUtils.js
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup/cashup-model.js
---
(0151394)
hgbot   
2023-06-20 16:14   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 6d9a65c0199ea33b71a9a437c48e26d82bb8d0ba
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 20-06-2023 14:14:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/6d9a65c0199ea33b71a9a437c48e26d82bb8d0ba [^]

Fixed ISSUE-52737: Cashup window should not be shown if pos has pending tickets

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SwitchToCashupWindow.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/cashup/CashupWindowHooks.js
---
(0151395)
hgbot   
2023-06-20 16:14   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1907 [^]