Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052715POS2POSpublic2023-06-09 14:452023-08-17 16:19
Reporteradrianromero 
Assigned Tonjimenez 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052715: Refactor payment integration flows as action preparation processes
DescriptionPayment integration flows must be refactored as action preparation functions.
Steps To ReproduceTrying to set manager approval on UserAction DeletePayment.


If you put APPROVAL REQUIRED, then, on the POS when you pay with adyen and after click on the cross to remove the payment line, the refund is sent to the terminal before the approbation popup is displayed.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0052890 closed njimenez Retail Modules Refactor payment integration flow as action preparation 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-06-09 14:45adrianromeroNew Issue
2023-06-09 14:45adrianromeroAssigned To => Retail
2023-06-09 14:45adrianromeroTriggers an Emergency Pack => No
2023-06-09 15:01hgbotNote Added: 0150994
2023-06-09 15:02adrianromeroStatusnew => scheduled
2023-06-21 17:15hgbotNote Added: 0151455
2023-06-29 13:29njimenezRelationship addedblocks 0052890
2023-07-19 14:54njimenezAssigned ToRetail => njimenez
2023-07-19 14:59njimenezRelationship deletedblocks 0052890
2023-07-19 14:59njimenezRelationship addedrelated to 0052890
2023-08-02 09:50hgbotNote Added: 0153091
2023-08-17 16:19hgbotResolutionopen => fixed
2023-08-17 16:19hgbotStatusscheduled => closed
2023-08-17 16:19hgbotFixed in Version => 23Q4
2023-08-17 16:19hgbotNote Added: 0153619
2023-08-17 16:19hgbotNote Added: 0153620

Notes
(0150994)
hgbot   
2023-06-09 15:01   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1886 [^]
(0151455)
hgbot   
2023-06-21 17:15   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1255 [^]
(0153091)
hgbot   
2023-08-02 09:50   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1255 [^]
(0153619)
hgbot   
2023-08-17 16:19   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 0428e87da9dfcb59d75ca75688efbe94dd4bc97c
Author: Adrián Romero <adrian.romero@openbravo.com>
Date: 17-08-2023 16:19:06
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0428e87da9dfcb59d75ca75688efbe94dd4bc97c [^]

Fixes ISSUE-52715: Refactor payment integration flows as action preparation processes

---
M web-jspack/org.openbravo.pos2/src/components/Payments/AuxiliaryPaymentsGrid/RefundLimitsAction.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentButton/PaymentButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/__test__/processReversePayment.test.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/processPaymentVoid.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/processReversePayment.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentList/PaymentActionEvents.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddPayment.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/ReversePayment.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddPayment.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/DeletePayment.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReversePayment.js
---
(0153620)
hgbot   
2023-08-17 16:19   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1886 [^]