Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052679POS2POSpublic2023-06-06 13:162023-06-08 11:23
Reportermalsasua 
Assigned Toprakashmurugesan88 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket66000
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052679: Till is locked with open receipt ticket with a sales representative of other store
DescriptionWhen one paid ticket is loaded in the till (Orders menu option) and the sales representative linked to the ticket does not belong to this store, an error is returned:

TypeError: Cannot read properties of undefined (reading 'undefined')
    at ConfigurableButton.jsx:59:16
    at Array.map (<anonymous>)
    at c (ConfigurableButton.jsx:48:33)
    at ia (react-dom.production.min.js:157:137)
    at Ba (react-dom.production.min.js:180:154)
    at $u (react-dom.production.min.js:269:343)
    at jl (react-dom.production.min.js:250:347)
    at Sl (react-dom.production.min.js:250:278)
    at Ol (react-dom.production.min.js:250:138)
    at ml (react-dom.production.min.js:243:163)
uu @ react-dom.production.min.js:216
Steps To Reproduce. in store1:
1- do login with cashier1 (cashier1 can not access to store2)
2- complete a ticket
. in store2:
3- do login with cashier2
4- click in "Orders" and select the ticket created in 1
-> error:
TypeError: Cannot read properties of undefined (reading 'undefined')
Proposed SolutionLines candidates to be fixed:
if (foundSalesRep) {
        setSalesRepInfo(foundSalesRep ? foundSalesRep[0] : {});
      }
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-06-06 13:16malsasuaNew Issue
2023-06-06 13:16malsasuaAssigned To => Retail
2023-06-06 13:16malsasuaOBNetwork customer => Gold
2023-06-06 13:16malsasuaSupport ticket => 66000
2023-06-06 13:16malsasuaTriggers an Emergency Pack => No
2023-06-06 13:45guillermogilAssigned ToRetail => prakashmurugesan88
2023-06-07 13:09hgbotMerge Request Status => open
2023-06-07 13:09hgbotNote Added: 0150888
2023-06-08 11:22hgbotMerge Request Statusopen => approved
2023-06-08 11:23hgbotResolutionopen => fixed
2023-06-08 11:23hgbotStatusnew => closed
2023-06-08 11:23hgbotFixed in Version => 23Q3
2023-06-08 11:23hgbotNote Added: 0150932
2023-06-08 11:23hgbotNote Added: 0150933

Notes
(0150888)
hgbot   
2023-06-07 13:09   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1878 [^]
(0150932)
hgbot   
2023-06-08 11:23   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: f311822890242c2bd35f61ab9b4028fd972ef36c
Author: Prakash M <prakash@qualiantech.com>
Date: 08-06-2023 09:23:25
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f311822890242c2bd35f61ab9b4028fd972ef36c [^]

Fixes ISSUE-52679: Fixed error while loading ticket with sales representative of other store. If sales representative is not present in the frontend, it will be loaded from the backend.

---
A src/org/openbravo/pos2/master/OBPOS2LoadedSalesRep.java
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/TicketLineSalesRepSelectorField/TicketLineSalesRepSelectorField.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineSalesRepInfo/TicketLineSalesRepInfo.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketMultiLineSalesRepSelectorField/TicketMultiLineSalesRepSelectorField.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketPropertiesPopover/TicketSalesRepSelectorField/TicketSalesRepSelectorField.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketSalesRepButton/TicketSalesRepButton.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/SalesRepresentativeUtils.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddNewTicketActionPreparation.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddProductActionPreparation.js
---
(0150933)
hgbot   
2023-06-08 11:23   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1878 [^]