Openbravo Issue Tracking System - POS2
View Issue Details
0052630POS2Corepublic2023-05-31 16:512023-07-11 00:03
gorka_gil 
Triage Platform Base 
normalminoralways
closedfixed 
5
 
23Q4 
No
0052630: BaseFormKeypad: strange edit behaviour
This issue englobes three incorrect behaviours when editing a BaseFormKeypad field:

- 1) add numbers to the middle of the current value using the keyboard
     - it add one in the midle and the rest at the end

- 1) add numbers to the middle of the current value using the keypad
     - it adds all to the end

- 3) delete after write with the keyboard
     - it deletes all the number instead one character

- 4) it should accept only number, no characters
go to pos2,
go to cash management and click on new deposit,
set the amount to '1111' using the keypad:

problem 1)
put the cursor in the middle and write a '3' with the keyboard,
it will write in the middle but if another '3' is write witht he keyboard it will go to the end: '113113'

problem 2)
having the '1111',
put the focus in the middle,
press the 3 of the keypad,
it will write at the end : '11113'

Problem 3)
write the amount '1111' with the keyboard, press the delete of the keyboard,
it will delete all instead one character
No tags attached.
has duplicate defect 0052631 closed Triage Platform Base BaseFormKeypad: allow only numeric values 
Issue History
2023-05-31 16:51gorka_gilNew Issue
2023-05-31 16:51gorka_gilAssigned To => Triage Platform Base
2023-05-31 16:51gorka_gilTriggers an Emergency Pack => No
2023-05-31 17:06gorka_gilRelationship addedrelated to 0052631
2023-07-02 11:23AugustoMauchDescription Updatedbug_revision_view_page.php?rev_id=26386#r26386
2023-07-02 11:26hgbotNote Added: 0151997
2023-07-02 13:00AugustoMauchRelationship replacedhas duplicate 0052631
2023-07-03 15:11hgbotNote Added: 0152063
2023-07-11 00:03hgbotResolutionopen => fixed
2023-07-11 00:03hgbotStatusnew => closed
2023-07-11 00:03hgbotFixed in Version => 23Q4
2023-07-11 00:03hgbotNote Added: 0152288
2023-07-11 00:03hgbotNote Added: 0152289
2023-07-11 00:03hgbotNote Added: 0152290
2023-07-11 00:03hgbotNote Added: 0152291

Notes
(0151997)
hgbot   
2023-07-02 11:26   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1163 [^]
(0152063)
hgbot   
2023-07-03 15:11   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1938 [^]
(0152288)
hgbot   
2023-07-11 00:03   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: d89bac44377305cda6b4ad4a1104222e5f8dfc10
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 10-07-2023 22:03:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/d89bac44377305cda6b4ad4a1104222e5f8dfc10 [^]

Fixes ISSUE-52630: Improves BaseFormKeypad by using properly useNumberInputFormat

The problem was that BaseFormKeypad was not properly using useNumberInputFormat/useEditNumber. Now the problems
reported in https://issues.openbravo.com/view.php\?id\=52630 [^] are no longer reproducible.

Note that as a consequence of linking the input to the form, some tests in pos2 might need to be updated

---
M web-jspack/org.openbravo.core2/src/components/BaseFormKeypad/BaseFormKeypad.jsx
---
(0152289)
hgbot   
2023-07-11 00:03   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1163 [^]
(0152290)
hgbot   
2023-07-11 00:03   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 171c5f6fed871179f3215a7cfa65786402f5ca01
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 10-07-2023 16:31:14
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/171c5f6fed871179f3215a7cfa65786402f5ca01 [^]

Related to ISSUE-52630: Modifies CashManagementNewMovementForm with the changes done in BaseFormKeypad

---
M web-jspack/org.openbravo.pos2/src-test/cypress/e2e/Features/cashManagement.spec.js
M web-jspack/org.openbravo.pos2/src/components/CashManagement/CashManagementNewMovementForm/CashManagementNewMovementForm.jsx
M web-jspack/org.openbravo.pos2/src/components/CashManagement/CashManagementNewMovementForm/__test__/CashManagementNewMovementForm.test.jsx
---
(0152291)
hgbot   
2023-07-11 00:03   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1938 [^]