Openbravo Issue Tracking System - Retail Modules
View Issue Details
0052628Retail ModulesDiscounts and Promotionspublic2023-05-31 09:292023-07-11 23:31
noemieroussel 
ranjith_qualiantech_com 
highmajorhave not tried
closedfixed 
5
 
RR23Q1.4 
Packaging and release
2022-10-04
RR22Q4
https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/d6a1d4f03f0a48eaa5793b783e45ce3c70c13f5e [^]
No
0052628: Pos 2: promotions wrongly configured block the access to the WebPOS
When we configure a promotion wrongly, the expected behavior is to have an error message in Back Office when activating a promotion where a mandatory filter is missing (for Combo for example, the error occurs when there is no record registered in Family subtab), but not in the WEBPOS.

If I configure a promotion with an error or a missing filter, I should still be able to log in to WebPOS and do a sale, and the promotion that is not correctly set up will not be available.

We need to know which configuration can cause this blocking error.
Go to the backoffice

Create a new record in "Discounts and Promotions" : a Combo promotion without adding family. Set it as active.

Try to enter in the WebPOS. -> POS can't be opened

Then, go to the backoffice and deactivate the promotion.

Go to the POS and refresh, see that POS is now accesible.

Go to the backoffice and activate the promotion.

Go to the POS and refresh, see that POS is now unaccesible.
We need to know which configuration can cause this blocking error.
No tags attached.
blocks defect 0052618 closed ranjith_qualiantech_com POS2 Pos 2: promotions wrongly configured block the access to the WebPOS 
Issue History
2023-05-31 15:10ranjith_qualiantech_comTypedefect => backport
2023-05-31 15:10ranjith_qualiantech_comTarget Version => RR23Q1.4
2023-07-11 14:19hgbotNote Added: 0152324
2023-07-11 14:19hgbotNote Added: 0152325
2023-07-11 14:19hgbotNote Added: 0152326
2023-07-11 23:30hgbotNote Added: 0152352
2023-07-11 23:30hgbotNote Added: 0152353
2023-07-11 23:30hgbotNote Added: 0152354
2023-07-11 23:30hgbotNote Added: 0152355
2023-07-11 23:31hgbotResolutionopen => fixed
2023-07-11 23:31hgbotStatusscheduled => closed
2023-07-11 23:31hgbotNote Added: 0152356
2023-07-11 23:31hgbotNote Added: 0152357

Notes
(0152324)
hgbot   
2023-07-11 14:19   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/36 [^]
(0152325)
hgbot   
2023-07-11 14:19   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1170 [^]
(0152326)
hgbot   
2023-07-11 14:19   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/569 [^]
(0152352)
hgbot   
2023-07-11 23:30   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 3bddef646aa66f8603d70a60f1643c5b4b1a1225
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 11-07-2023 15:13:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/3bddef646aa66f8603d70a60f1643c5b4b1a1225 [^]

Related to ISSUE-52628: Error should be handled when loading terminal data

---
M web-jspack/org.openbravo.core2/src/core/terminal/TerminalDataMasterdataHooks.js
---
(0152353)
hgbot   
2023-07-11 23:30   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1170 [^]
(0152354)
hgbot   
2023-07-11 23:30   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 2d48a3da0a68e7f7f5a40983c2c8f559c8ecddae
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 11-07-2023 21:30:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/2d48a3da0a68e7f7f5a40983c2c8f559c8ecddae [^]

Related to ISSUE-52628: Removed recursion function in MasterData hooks

---
M web/org.openbravo.mobile.core/app/model/masterdata/MasterdataController.js
---
(0152355)
hgbot   
2023-07-11 23:30   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/569 [^]
(0152356)
hgbot   
2023-07-11 23:31   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 4327ca287094fc10f4d1628d85fb23d2dd5a8ed7
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 11-07-2023 21:31:15
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/4327ca287094fc10f4d1628d85fb23d2dd5a8ed7 [^]

Fixed ISSUE-52628: Added InitialValidation for ComboFixedPrice discount

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/discounts/combo/master/DiscountComboValidation.java
---
(0152357)
hgbot   
2023-07-11 23:31   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/36 [^]