Openbravo Issue Tracking System - Retail Modules
View Issue Details
0052627Retail ModulesDiscounts and Promotionspublic2023-05-31 09:292023-07-11 14:32
noemieroussel 
ranjith_qualiantech_com 
highmajorhave not tried
closedfixed 
5
 
RR23Q2.2 
Packaging and release
2022-10-04
RR22Q4
https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/d6a1d4f03f0a48eaa5793b783e45ce3c70c13f5e [^]
No
0052627: Pos 2: promotions wrongly configured block the access to the WebPOS
When we configure a promotion wrongly, the expected behavior is to have an error message in Back Office when activating a promotion where a mandatory filter is missing (for Combo for example, the error occurs when there is no record registered in Family subtab), but not in the WEBPOS.

If I configure a promotion with an error or a missing filter, I should still be able to log in to WebPOS and do a sale, and the promotion that is not correctly set up will not be available.

We need to know which configuration can cause this blocking error.
Go to the backoffice

Create a new record in "Discounts and Promotions" : a Combo promotion without adding family. Set it as active.

Try to enter in the WebPOS. -> POS can't be opened

Then, go to the backoffice and deactivate the promotion.

Go to the POS and refresh, see that POS is now accesible.

Go to the backoffice and activate the promotion.

Go to the POS and refresh, see that POS is now unaccesible.
We need to know which configuration can cause this blocking error.
No tags attached.
blocks defect 0052618 closed ranjith_qualiantech_com POS2 Pos 2: promotions wrongly configured block the access to the WebPOS 
Issue History
2023-05-31 15:10ranjith_qualiantech_comTypedefect => backport
2023-05-31 15:10ranjith_qualiantech_comTarget Version => RR23Q2.2
2023-07-11 14:17hgbotNote Added: 0152321
2023-07-11 14:17hgbotNote Added: 0152322
2023-07-11 14:17hgbotNote Added: 0152323
2023-07-11 14:32hgbotNote Added: 0152333
2023-07-11 14:32hgbotNote Added: 0152334
2023-07-11 14:32hgbotNote Added: 0152335
2023-07-11 14:32hgbotNote Added: 0152336
2023-07-11 14:32hgbotNote Added: 0152337
2023-07-11 14:32hgbotResolutionopen => fixed
2023-07-11 14:32hgbotStatusscheduled => closed
2023-07-11 14:32hgbotNote Added: 0152338

Notes
(0152321)
hgbot   
2023-07-11 14:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/35 [^]
(0152322)
hgbot   
2023-07-11 14:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1169 [^]
(0152323)
hgbot   
2023-07-11 14:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/568 [^]
(0152333)
hgbot   
2023-07-11 14:32   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 16bebf1cd0afc4eecd2a8843175c538f5257fec5
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 11-07-2023 12:32:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/16bebf1cd0afc4eecd2a8843175c538f5257fec5 [^]

Related to ISSUE-52627: Removed recursion function in MasterData hooks

---
M web/org.openbravo.mobile.core/app/model/masterdata/MasterdataController.js
---
(0152334)
hgbot   
2023-07-11 14:32   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/568 [^]
(0152335)
hgbot   
2023-07-11 14:32   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 64f815cbdcb0bdf5006d15e4caffff99d36aeed5
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 11-07-2023 15:12:06
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/64f815cbdcb0bdf5006d15e4caffff99d36aeed5 [^]

Related to ISSUE-52627: Error should be handled when loading terminal data

---
M web-jspack/org.openbravo.core2/src/core/terminal/TerminalDataMasterdataHooks.js
---
(0152336)
hgbot   
2023-07-11 14:32   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1169 [^]
(0152337)
hgbot   
2023-07-11 14:32   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/35 [^]
(0152338)
hgbot   
2023-07-11 14:32   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 6f49546d60b565d2b12541a452a9029db9dc8edb
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 11-07-2023 12:32:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/6f49546d60b565d2b12541a452a9029db9dc8edb [^]

Fixed ISSUE-52627: Added InitialValidation for ComboFixedPrice discount

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/discounts/combo/master/DiscountComboValidation.java
---