Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052613POS2Corepublic2023-05-30 18:122024-04-15 13:34
Reporterkchoperena 
Assigned ToAugustoMauch 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version24Q3 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052613: Login fails when there is a User Action Reason configured with SwitchToMainWindow user action
DescriptionReact POS login fails when there is a "User Action Reason" configured with "SwitchToMainWindow" user action
Steps To ReproducePREREQUIREMENTS:
In the backoffice, create a User Action Reason that uses "SwitchToMainWindow" User ACtion

STEPS:
1.- Try to login in React POS

RESULT:
The login fails because of a Javascript error (see attached image)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng image (3).png (67,703) 2023-05-30 18:12
https://issues.openbravo.com/file_download.php?file_id=18600&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2023-05-30 18:12kchoperenaNew Issue
2023-05-30 18:12kchoperenaAssigned To => Triage Platform Base
2023-05-30 18:12kchoperenaFile Added: image (3).png
2023-05-30 18:12kchoperenaTriggers an Emergency Pack => No
2024-04-09 12:59AugustoMauchStatusnew => acknowledged
2024-04-09 13:41AugustoMauchNote Added: 0162991
2024-04-09 13:59AugustoMauchAssigned ToTriage Platform Base => AugustoMauch
2024-04-09 13:59AugustoMauchStatusacknowledged => scheduled
2024-04-09 19:59hgbotNote Added: 0163002
2024-04-15 08:44AugustoMauchStatusscheduled => resolved
2024-04-15 08:44AugustoMauchResolutionopen => fixed
2024-04-15 13:34hgbotStatusresolved => closed
2024-04-15 13:34hgbotFixed in Version => 24Q3
2024-04-15 13:34hgbotNote Added: 0163225
2024-04-15 13:34hgbotNote Added: 0163226

Notes
(0162991)
AugustoMauch   
2024-04-09 13:41   
InputDataDialog is rendered here: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/App/App.jsx#L35 [^]

Before that App is rendered, a user action that asks for an input is invoked. To determine: what to do in this case, probably only option will be to ignore the request for input
(0163002)
hgbot   
2024-04-09 19:59   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1447 [^]
(0163225)
hgbot   
2024-04-15 13:34   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 5b135c0ca5019ab40d35be3699f5101afc694535
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 15-04-2024 11:34:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/5b135c0ca5019ab40d35be3699f5101afc694535 [^]

Fixes ISSUE-52613: Improves error management in requestInputData

Now if requestInputData cannot be properly executed because inputData is not available, it will:
- throw an exception if no fallbackData is provided
- return fallbackData otherwise

---
A web-jspack/org.openbravo.core2/src/components/InputDataDialog/__test__/requestInputData.error.test.js
M web-jspack/org.openbravo.core2/src/components/InputDataDialog/InputDataDialog.jsx
M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/StandardInputDataDialog.jsx
M web-jspack/org.openbravo.core2/src/core/security/requestInputAndApproval.js
---
(0163226)
hgbot   
2024-04-15 13:34   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1447 [^]