Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052571POS2POSpublic2023-05-26 05:522023-06-02 08:42
Reporterhcurbelo 
Assigned ToRetail 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052571: Wrong value in "lastOpenClosedDate"
DescriptionWe found an issue in the closingstore webhook. The date sent in "lastOpenClosedDate" is not good.
Steps To Reproduce1. No closing store on april 6th evening

2. At the openning on april 7th, the POS ask to close the store because the business date is not today

3. The vendor cashup the POS and close the store
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-05-26 05:52hcurbeloNew Issue
2023-05-26 05:52hcurbeloAssigned To => Retail
2023-05-26 05:52hcurbeloTriggers an Emergency Pack => No
2023-05-31 16:50hgbotResolutionopen => fixed
2023-05-31 16:50hgbotStatusnew => resolved
2023-05-31 16:50hgbotNote Added: 0150557
2023-05-31 16:50hgbotNote Added: 0150558
2023-05-31 16:51marvintmReview Assigned To => marvintm
2023-05-31 16:51marvintmStatusresolved => closed
2023-05-31 16:51marvintmFixed in Version => 23Q3
2023-06-01 12:17hgbotNote Added: 0150586
2023-06-01 12:19marvintmNote Added: 0150587
2023-06-01 12:19marvintmStatusclosed => new
2023-06-01 12:19marvintmResolutionfixed => open
2023-06-01 12:19marvintmFixed in Version23Q3 =>
2023-06-01 16:29hgbotNote Added: 0150608
2023-06-02 08:42hgbotNote Added: 0150643
2023-06-02 08:42hgbotResolutionopen => fixed
2023-06-02 08:42hgbotStatusnew => closed
2023-06-02 08:42hgbotNote Added: 0150644

Notes
(0150557)
hgbot   
2023-05-31 16:50   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 32470e6766952667f81b2256368fd5a884aaa964
Author: HECTOR CURBELO BARRIOS <HECTOR.CURBELO@SMFCONSULTING.ES>
Date: 26-05-2023 23:19:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/32470e6766952667f81b2256368fd5a884aaa964 [^]

Fixed ISSUE-52571 Wrong value in lastOpenClosedDate when no closing store and open the next day

---
M web-jspack/org.openbravo.retail.sessions/src/model/till/actions/CloseTillInServer.js
---
(0150558)
hgbot   
2023-05-31 16:50   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 06615ab6b576d817d60334a16c1f56f0c9f96c3e
Author: HECTOR CURBELO BARRIOS <HECTOR.CURBELO@SMFCONSULTING.ES>
Date: 30-05-2023 21:06:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/06615ab6b576d817d60334a16c1f56f0c9f96c3e [^]

Fixed ISSUE-52571 Change Date format

---
M src/org/openbravo/retail/sessions/WebPOSCloseStore.java
M web-jspack/org.openbravo.retail.sessions/src/model/till/actions/CloseTillInServer.js
---
(0150586)
hgbot   
2023-06-01 12:17   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 8ecd28c851d498fa5e968a69d505e9a686186503
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 01-06-2023 12:17:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/8ecd28c851d498fa5e968a69d505e9a686186503 [^]

Related to ISSUE-52571: reverted change as it was breaking the Jest tests

---
M src/org/openbravo/retail/sessions/WebPOSCloseStore.java
M web-jspack/org.openbravo.retail.sessions/src/model/till/actions/CloseTillInServer.js
---
(0150587)
marvintm   
2023-06-01 12:19   
Reverted because the change was breaking integration
(0150608)
hgbot   
2023-06-01 16:29   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/83 [^]
(0150643)
hgbot   
2023-06-02 08:42   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/83 [^]
(0150644)
hgbot   
2023-06-02 08:42   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 1a49d3ebdbc4440d9d5617046b6e582a840a49c9
Author: Hector Curbelo Barrios <hector.curbelo@smfconsulting.es>
Date: 02-06-2023 06:42:14
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/1a49d3ebdbc4440d9d5617046b6e582a840a49c9 [^]

Fixed ISSUE-52571: Fix date formatting so that the closeBusinessDate is correctly set in the organization

---
M src/org/openbravo/retail/sessions/WebPOSCloseStore.java
M web-jspack/org.openbravo.retail.sessions/src/model/till/actions/CloseTillInServer.js
M web-jspack/org.openbravo.retail.sessions/src/model/till/actions/__test__/CloseTillInServer.test.js
---