Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052552POS2POSpublic2023-05-17 14:462023-05-25 09:53
Reporterruben_jimenez 
Assigned Toruben_jimenez 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version23Q2.1Fixed in Version23Q2.1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052552: RM-6155: It is possible to create sales with a delivery mode that is not allowed for a specific schema.
DescriptionThe issue arises because we store the delivery mode in the order lines, and the deleted lines are kept in the order records. The deleted lines may have a different delivery mode than the rest.
Steps To Reproduce1- Select a product in a schema where the allowed delivery mode is 'PickupInStore'.
2- Delete the product.
3- Switch to a different schema where the delivery mode allowed is not 'PickupInStore'.
4- Select a product.
5- Proceed with the payment.
If you open the ticket through the order screen, the delivery mode of the ticket will be "PickupInStore" instead of "PickAndCarry," which is the only allowed delivery mode for the current schema.
Proposed SolutionIgnore the deleted lines when determining the delivery mode.
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0052473main closed ruben_jimenez RM-6155: It is possible to create sales with a delivery mode that is not allowed for a specific schema. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-05-24 12:58nicola_uvaTypedesign defect => backport
2023-05-24 12:58nicola_uvaTarget Versionmain => 23Q2.1
2023-05-24 14:22hgbotNote Added: 0150222
2023-05-24 14:30hgbotNote Added: 0150227
2023-05-25 09:52hgbotResolutionopen => fixed
2023-05-25 09:52hgbotStatusscheduled => closed
2023-05-25 09:52hgbotNote Added: 0150264
2023-05-25 09:52hgbotFixed in Version => RR23Q2.1
2023-05-25 09:52hgbotNote Added: 0150265
2023-05-25 09:53hgbotFixed in VersionRR23Q2.1 => 23Q2.1
2023-05-25 09:53hgbotNote Added: 0150267
2023-05-25 09:53hgbotNote Added: 0150268

Notes
(0150222)
hgbot   
2023-05-24 14:22   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1840 [^]
(0150227)
hgbot   
2023-05-24 14:30   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1211 [^]
(0150264)
hgbot   
2023-05-25 09:52   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1211 [^]
(0150265)
hgbot   
2023-05-25 09:52   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 2a06af68b417feffc2acdad24290a56e30e5d0e3
Author: ruben.jimenez <ruben.jimenez@openbravo.com>
Date: 24-05-2023 14:27:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/2a06af68b417feffc2acdad24290a56e30e5d0e3 [^]

Fixed ISSUE-52552:Ignore deleted lines to get delivery mode in sales orders

---
M src/org/openbravo/retail/posterminal/PaidReceiptsFilterProperties.java
---
(0150267)
hgbot   
2023-05-25 09:53   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 4b7deef4be85ed6de190133e12c5e8b4aebbffdd
Author: ruben.jimenez <ruben.jimenez@openbravo.com>
Date: 25-05-2023 07:53:07
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4b7deef4be85ed6de190133e12c5e8b4aebbffdd [^]

Fixed ISSUE-52552: Ignored deleted lines to get delivery mode in sales orders

---
M src/org/openbravo/pos2/master/PaidReceiptProperties.java
---
(0150268)
hgbot   
2023-05-25 09:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1840 [^]