Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052540POS2POSpublic2023-05-24 03:342023-06-12 09:36
Reporterhcurbelo 
Assigned Tohcurbelo 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q3 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052540: SALES REPRESENTATIVE : Display only sellers and managers of the store
DescriptionThe current flag “Is Sales Representative” inside the Business Partner table (C_BPartner) should be moved to the User table (AD_User). A module script is also needed to move the value of this flag in existing instances.
Steps To ReproduceThere should be a way to display/edit in the POS the “Sales Representative” at both header and lines level, based on permissions. Add a new field “Sales Representative” in both “Receipt Properties” and “Receipt Line Properties”

Add two new User Actions (one for the header and another one for the lines) to let define permissions to determine which users can change the “Sales Representative”.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Screenshot 2023-05-23 at 20.34.29.png (256,320) 2023-05-24 03:34
https://issues.openbravo.com/file_download.php?file_id=18568&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2023-05-24 03:34hcurbeloNew Issue
2023-05-24 03:34hcurbeloAssigned To => Triage Platform Base
2023-05-24 03:34hcurbeloFile Added: Screenshot 2023-05-23 at 20.34.29.png
2023-05-24 03:34hcurbeloTriggers an Emergency Pack => No
2023-05-24 16:41hgbotNote Added: 0150235
2023-05-24 16:45hgbotNote Added: 0150236
2023-05-29 16:36marvintmAssigned ToTriage Platform Base => Retail
2023-05-29 16:36marvintmCategoryCore => POS
2023-05-31 07:27guillermogilAssigned ToRetail => hcurbelo
2023-05-31 07:28guillermogilStatusnew => scheduled
2023-06-02 08:34hgbotResolutionopen => fixed
2023-06-02 08:34hgbotStatusscheduled => closed
2023-06-02 08:34hgbotFixed in Version => PR23Q3
2023-06-02 08:34hgbotNote Added: 0150633
2023-06-02 08:34hgbotNote Added: 0150636
2023-06-02 08:34hgbotNote Added: 0150637
2023-06-02 08:35hgbotFixed in VersionPR23Q3 => 23Q3
2023-06-02 08:35hgbotNote Added: 0150638
2023-06-02 08:35hgbotNote Added: 0150639
2023-06-02 08:35hgbotNote Added: 0150640
2023-06-02 08:35hgbotNote Added: 0150641
2023-06-02 08:35hgbotNote Added: 0150642
2023-06-02 09:07hgbotNote Added: 0150645
2023-06-02 09:50hgbotNote Added: 0150647
2023-06-02 09:52hgbotNote Added: 0150648
2023-06-02 09:53hgbotNote Added: 0150649
2023-06-02 09:59hgbotNote Added: 0150650
2023-06-12 09:36hgbotNote Added: 0151020

Notes
(0150235)
hgbot   
2023-05-24 16:41   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/893 [^]
(0150236)
hgbot   
2023-05-24 16:45   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1841 [^]
(0150633)
hgbot   
2023-06-02 08:34   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: dac51401ceeed6542a145e0d50749dc1b3c83028
Author: HECTOR CURBELO BARRIOS <HECTOR.CURBELO@SMFCONSULTING.ES>
Date: 02-06-2023 08:33:52
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/dac51401ceeed6542a145e0d50749dc1b3c83028 [^]

Fixed ISSUE-52540 Sales Representative Display only sellers and managers of the store

---
A src-util/modulescript/build/classes/org/openbravo/modulescript/PopulateUserSalesRepresentative.class
A src-util/modulescript/build/classes/org/openbravo/modulescript/PopulateUserSalesRepresentativeData.class
A src-util/modulescript/src/org/openbravo/modulescript/PopulateUserSalesRepresentative.java
A src-util/modulescript/src/org/openbravo/modulescript/PopulateUserSalesRepresentative_data.xsql
M src-db/database/model/tables/AD_USER.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0150636)
hgbot   
2023-06-02 08:34   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 5fc02fb63cd6aa54fa91996e7fb3897436022892
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 02-06-2023 08:34:30
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/5fc02fb63cd6aa54fa91996e7fb3897436022892 [^]

Fixed ISSUE-52540: Merge branch 'fr/52540'

---
A src-util/modulescript/build/classes/org/openbravo/modulescript/PopulateUserSalesRepresentative.class
A src-util/modulescript/build/classes/org/openbravo/modulescript/PopulateUserSalesRepresentativeData.class
A src-util/modulescript/src/org/openbravo/modulescript/PopulateUserSalesRepresentative.java
A src-util/modulescript/src/org/openbravo/modulescript/PopulateUserSalesRepresentative_data.xsql
M src-db/database/model/tables/AD_USER.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0150637)
hgbot   
2023-06-02 08:34   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/893 [^]
(0150638)
hgbot   
2023-06-02 08:35   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 563b756ab06040184cc05d8e24354dc238628695
Author: HECTOR CURBELO BARRIOS <HECTOR.CURBELO@SMFCONSULTING.ES>
Date: 01-06-2023 07:46:28
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/563b756ab06040184cc05d8e24354dc238628695 [^]

Fixed ISSUE-52540 Sales Representative Display only sellers and managers of the store

---
M src/org/openbravo/pos2/master/OBPOS2SalesRepresentative.java
---
(0150639)
hgbot   
2023-06-02 08:35   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: b0b026878ad2cf3e0e6b143918be0ab9deab487f
Author: HECTOR CURBELO BARRIOS <HECTOR.CURBELO@SMFCONSULTING.ES>
Date: 01-06-2023 07:46:28
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/b0b026878ad2cf3e0e6b143918be0ab9deab487f [^]

Fixed ISSUE-52540 Validation Channel Touchpoint Type Sales Representative New Orders

---
A web-jspack/org.openbravo.pos2/src/model/ticket/SalesRepresentativeUtils.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddNewTicketActionPreparation.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddProductActionPreparation.js
---
(0150640)
hgbot   
2023-06-02 08:35   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1841 [^]
(0150641)
hgbot   
2023-06-02 08:35   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: dfc07da0ad9499cb641533e57dc009c4a10b2316
Author: HECTOR CURBELO BARRIOS <HECTOR.CURBELO@SMFCONSULTING.ES>
Date: 01-06-2023 17:43:43
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/dfc07da0ad9499cb641533e57dc009c4a10b2316 [^]

Fixed ISSUE-52540 Jest Error on Validate Users Sales Representative test

---
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddProductActionPreparation.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/__test__/AddNewTicketActionPreparation.test.js
---
(0150642)
hgbot   
2023-06-02 08:35   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 0c48527457f79a547575ec45106af14d259443c3
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 02-06-2023 08:35:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0c48527457f79a547575ec45106af14d259443c3 [^]

Fixed ISSUE-52540: :Merge branch 'fr/52540'

---
A web-jspack/org.openbravo.pos2/src/model/ticket/SalesRepresentativeUtils.js
M src/org/openbravo/pos2/master/OBPOS2SalesRepresentative.java
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddProductActionPreparation.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddNewTicketActionPreparation.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddProductActionPreparation.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/__test__/AddNewTicketActionPreparation.test.js
---
(0150645)
hgbot   
2023-06-02 09:07   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata [^]
Changeset: b4522a69763c21bbae03454a52ad54c3597ea676
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 02-06-2023 09:07:47
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/commit/b4522a69763c21bbae03454a52ad54c3597ea676 [^]

Related to ISSUE-52540: Fixed sampledata consistency

---
M referencedata/sampledata/The_White_Valley_Group/AD_USER.xml
---
(0150647)
hgbot   
2023-06-02 09:50   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: cdda4f1520a89214e061f47cb4604f8c3dded5e6
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 02-06-2023 09:50:46
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/cdda4f1520a89214e061f47cb4604f8c3dded5e6 [^]

Related to ISSUE-52540: Fix dbcons problem

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0150648)
hgbot   
2023-06-02 09:52   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata [^]
Changeset: 03740258d82c9befc31b792bba7873e499516a3b
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 02-06-2023 09:52:33
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/commit/03740258d82c9befc31b792bba7873e499516a3b [^]

Related to ISSUE-52540: Fix dbconsistency problem

---
M referencedata/sampledata/Retail_Test/AD_USER.xml
---
(0150649)
hgbot   
2023-06-02 09:53   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: fccbb49fad5532cb35beddc9d6ce3d8255f1f61f
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 02-06-2023 09:53:19
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/fccbb49fad5532cb35beddc9d6ce3d8255f1f61f [^]

Related to ISSUE-52540: Fix dbconsistency problem

---
M referencedata/sampledata/The_White_Valley_Group/AD_USER.xml
---
(0150650)
hgbot   
2023-06-02 09:59   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 2bf081a198101caddf795de54901c0c80ecaecbb
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 02-06-2023 09:58:55
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/2bf081a198101caddf795de54901c0c80ecaecbb [^]

Related to ISSUE-52540: Ensure modulescript is not executed on install

---
M src-util/modulescript/build/classes/org/openbravo/modulescript/PopulateUserSalesRepresentative.class
M src-util/modulescript/src/org/openbravo/modulescript/PopulateUserSalesRepresentative.java
---
(0151020)
hgbot   
2023-06-12 09:36   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 92e675dca76cf69144f06a7c5dfb83b01fb8bc19
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 12-06-2023 09:36:13
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/92e675dca76cf69144f06a7c5dfb83b01fb8bc19 [^]

Related to ISSUE-52540: Fixed license copyright and added comment to explain reason for the modulescript

---
M src-util/modulescript/src/org/openbravo/modulescript/PopulateUserSalesRepresentative.java
---