Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052507POS2POSpublic2023-05-17 14:462023-05-25 10:42
Reporterruben_jimenez 
Assigned Toruben_jimenez 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version23Q1.3Fixed in Version23Q1.3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052507: RM-6155: It is possible to create sales with a delivery mode that is not allowed for a specific schema.
DescriptionThe issue arises because we store the delivery mode in the order lines, and the deleted lines are kept in the order records. The deleted lines may have a different delivery mode than the rest.
Steps To Reproduce1- Select a product in a schema where the allowed delivery mode is 'PickupInStore'.
2- Delete the product.
3- Switch to a different schema where the delivery mode allowed is not 'PickupInStore'.
4- Select a product.
5- Proceed with the payment.
If you open the ticket through the order screen, the delivery mode of the ticket will be "PickupInStore" instead of "PickAndCarry," which is the only allowed delivery mode for the current schema.
Proposed SolutionIgnore the deleted lines when determining the delivery mode.
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0052473main closed ruben_jimenez RM-6155: It is possible to create sales with a delivery mode that is not allowed for a specific schema. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-05-22 13:30nicola_uvaTypedesign defect => backport
2023-05-22 13:30nicola_uvaTarget Versionmain => 23Q1.3
2023-05-25 09:14hgbotNote Added: 0150258
2023-05-25 09:23hgbotNote Added: 0150260
2023-05-25 10:41hgbotMerge Request Statusopen => approved
2023-05-25 10:41hgbotResolutionopen => fixed
2023-05-25 10:41hgbotStatusscheduled => closed
2023-05-25 10:41hgbotNote Added: 0150284
2023-05-25 10:41hgbotFixed in Version => RR23Q1.3
2023-05-25 10:41hgbotNote Added: 0150285
2023-05-25 10:42hgbotFixed in VersionRR23Q1.3 => 23Q1.3
2023-05-25 10:42hgbotNote Added: 0150286
2023-05-25 10:42hgbotNote Added: 0150287

Notes
(0150258)
hgbot   
2023-05-25 09:14   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1842 [^]
(0150260)
hgbot   
2023-05-25 09:23   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1212 [^]
(0150284)
hgbot   
2023-05-25 10:41   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1212 [^]
(0150285)
hgbot   
2023-05-25 10:41   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: a461bb3c11fd58310efe80f2c85cb358cf79b505
Author: ruben.jimenez <ruben.jimenez@openbravo.com>
Date: 25-05-2023 09:22:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a461bb3c11fd58310efe80f2c85cb358cf79b505 [^]

Fixed ISSUE-52507: Ignored deleted lines to get delivery mode in sales orders

---
M src/org/openbravo/retail/posterminal/PaidReceiptsFilterProperties.java
---
(0150286)
hgbot   
2023-05-25 10:42   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 62b20211eedb835b1f9e9c0813f806c4c0fc3267
Author: Ruben Jimenez <ruben.jimenez@openbravo.com>
Date: 25-05-2023 08:42:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/62b20211eedb835b1f9e9c0813f806c4c0fc3267 [^]

Fixed ISSUE-52507: Ignored deleted lines to get delivery mode in sales orders

---
M src/org/openbravo/pos2/master/PaidReceiptProperties.java
---
(0150287)
hgbot   
2023-05-25 10:42   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1842 [^]