Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052500Retail ModulesWeb POSpublic2023-05-18 03:162023-05-29 07:40
Reporteraxelmercado 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR23Q2.1Fixed in VersionRR23Q2.1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date2023-03-27
Regression introduced in releaseRR23Q2
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/b714a2ffb27e9bb3f3fa0a0b570263365f9c0f0d [^]
Triggers an Emergency PackNo
Summary0052500: WebPos - Functional BUG of the 'Overpayment' control
DescriptionWhen we have a configuration of a payment type with supplier and overpayment control at 0, when paying a ticket in several methods and depending on the amount (calculation rounding issue), an 'Overpayment' message appears when it is not.
Steps To Reproduce1- In the backoffice, configure a payment method (for example credit card) with a payment provider and overpayment at 0.
2- In the POS, make a sale and pay a part in cash and another part with the configured payment method.
3- Verify that the error 'Overpayment' is displayed, when in fact it is not.





Steps to Reproduce in livebuilds pos2 modules VBS-1
Backoffice
1) Create rounding payment in payment method(Channel Touchpoint type) and payment type (Channel Touchpoint - "VBS-1")
2) Update "Overpayment/Change limit" and "Max Limit Amount" as 0 for Card Payment Method (Channel Touchpoint type)
3) Add Payment Rounding for Card Payment Method (Channel Touchpoint type)
   With Up Rounding 0.5 (For Sales & Returns)
4) Update Product Price "Expedition tent 4 season 2 person" to 350.25


POS VBS-1
1) Add Product "Expedition tent 4 season 2 person"
2) Pay with credit card
3) Error occurred "Overpayment not available"

POS2 VBS-1
1) Add Product "Expedition tent 4 season 2 person"
2) Pay with credit card
3) Error occurred "Overpayment not available"
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0052478 closed ranjith_qualiantech_com WebPos - Functional BUG of the 'Overpayment' control 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-05-22 07:12ranjith_qualiantech_comTypedefect => backport
2023-05-22 07:12ranjith_qualiantech_comTarget Version => RR23Q2.1
2023-05-23 03:43hgbotNote Added: 0150120
2023-05-23 03:43hgbotNote Added: 0150121
2023-05-24 09:28hgbotNote Added: 0150190
2023-05-24 09:28hgbotNote Added: 0150191
2023-05-24 09:28hgbotNote Added: 0150192
2023-05-24 09:28hgbotResolutionopen => fixed
2023-05-24 09:28hgbotStatusscheduled => closed
2023-05-24 09:28hgbotFixed in Version => RR23Q2.1
2023-05-24 09:28hgbotNote Added: 0150193
2023-05-29 07:33ranjith_qualiantech_comNote Added: 0150358
2023-05-29 07:33ranjith_qualiantech_comStatusclosed => new
2023-05-29 07:33ranjith_qualiantech_comResolutionfixed => open
2023-05-29 07:33ranjith_qualiantech_comFixed in VersionRR23Q2.1 =>
2023-05-29 07:33ranjith_qualiantech_comStatusnew => scheduled
2023-05-29 07:35hgbotNote Added: 0150359
2023-05-29 07:40hgbotResolutionopen => fixed
2023-05-29 07:40hgbotNote Added: 0150360
2023-05-29 07:40hgbotStatusscheduled => closed
2023-05-29 07:40hgbotFixed in Version => RR23Q2.1
2023-05-29 07:40hgbotNote Added: 0150361

Notes
(0150120)
hgbot   
2023-05-23 03:43   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1834 [^]
(0150121)
hgbot   
2023-05-23 03:43   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1208 [^]
(0150190)
hgbot   
2023-05-24 09:28   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 16f1088be82201a4fafaaffe7f198c232ca0f337
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 24-05-2023 07:28:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/16f1088be82201a4fafaaffe7f198c232ca0f337 [^]

Related to ISSUE-52500: Original payment amount should be used for payment validation
* When paying amount with payment provider and rounding is configured,
  then original amount should be used for overpayment and other validation

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/processPayment.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/PaymentMethods.jsx
---
(0150191)
hgbot   
2023-05-24 09:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1834 [^]
(0150192)
hgbot   
2023-05-24 09:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1208 [^]
(0150193)
hgbot   
2023-05-24 09:28   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 203e97daedd5b1076eb8012c1eeb079ecfae6e86
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 24-05-2023 07:28:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/203e97daedd5b1076eb8012c1eeb079ecfae6e86 [^]

Fixed ISSUE-52500: Original Payment amount should be used for payment validation
* When paying amount with payment provider and rounding is configured,
  then original amount should be used for overpayment calculation

---
M web/org.openbravo.retail.posterminal/js/components/mockpayments.js
M web/org.openbravo.retail.posterminal/js/components/modalpayment.js
M web/org.openbravo.retail.posterminal/js/components/modalprovidergroup.js
---
(0150358)
ranjith_qualiantech_com   
2023-05-29 07:33   
Overpayment not available popup appears
Backoffice:
1) Configure credit card with Payment provider
POS
1) Add product with price 30.95
2) Make partial payment of 3.60 in cash.
3) Pay remaining with Credit Card
4) Message 'Overpayment not available' appears.
(0150359)
hgbot   
2023-05-29 07:35   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1216 [^]
(0150360)
hgbot   
2023-05-29 07:40   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1216 [^]
(0150361)
hgbot   
2023-05-29 07:40   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 5ff4a780025223ee5ecc70b1f512e13cd09f672c
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 29-05-2023 11:04:25
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/5ff4a780025223ee5ecc70b1f512e13cd09f672c [^]

Fixed ISSUE-52500: Added Decimal operation for validating overpayment

---
M web/org.openbravo.retail.posterminal/js/components/mockpayments.js
M web/org.openbravo.retail.posterminal/js/components/modalprovidergroup.js
---