Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052492POS2POSpublic2023-05-17 12:542023-05-19 14:00
Reportercberner 
Assigned Tocberner 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version23Q2.1Fixed in Version23Q2.1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052492: Session timeout dialog bypass pos2 blocked application
DescriptionWhen 2 pos2 are open in different tabs/windows, one of them is marked as blocked and we shouldn't be able to use it until it is refreshed.

This can be bypassed by the session timeout dialog, which appears after the set period of time for the session to expire and allows us to login again and work with an incorrect state.
Steps To Reproduce1. Setup a small session timeout by going to backoffice -> Preferences. Add a new record with property Web POS Session Timeout of 3 mins for example, and mark it as selected and visible to all users.
2. Login WebPOS
3. Open in another tab the same WebPOS and complete a ticket in this one
4. Go back to the other tab and wait for session timeout to happen, then login again
5. After logging in, a duplicate ticket error appears as part of the console and terminal log, this shows us that we're using the incorrect state.
Proposed SolutionDon't allow dialogUIHandler dialogs to appear on a blocked terminal.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0052468 closed cberner Session timeout dialog bypass pos2 blocked application 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-05-19 12:59AugustoMauchTypedefect => backport
2023-05-19 12:59AugustoMauchTarget Version => 23Q2.1
2023-05-19 13:34hgbotNote Added: 0149981
2023-05-19 13:35hgbotNote Added: 0149982
2023-05-19 14:00hgbotNote Added: 0149986
2023-05-19 14:00hgbotNote Added: 0149987
2023-05-19 14:00hgbotResolutionopen => fixed
2023-05-19 14:00hgbotStatusscheduled => closed
2023-05-19 14:00hgbotFixed in Version => 23Q2.1
2023-05-19 14:00hgbotNote Added: 0149988
2023-05-19 14:00hgbotNote Added: 0149989

Notes
(0149981)
hgbot   
2023-05-19 13:34   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1109 [^]
(0149982)
hgbot   
2023-05-19 13:35   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/525 [^]
(0149986)
hgbot   
2023-05-19 14:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1109 [^]
(0149987)
hgbot   
2023-05-19 14:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/525 [^]
(0149988)
hgbot   
2023-05-19 14:00   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 37f994be1556abe2a3c897570dc6d519b00be21a
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 19-05-2023 13:33:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/37f994be1556abe2a3c897570dc6d519b00be21a [^]

Fixes ISSUE-52492: Session timeout dialog bypasses the terminal block when two pos terminals are open

---
M web-jspack/org.openbravo.core2/src/core/user-interface/BrowserTab.js
M web-jspack/org.openbravo.core2/src/core/user-interface/View.js
---
(0149989)
hgbot   
2023-05-19 14:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 1b0c717ab682507ff41cd8c76024d03882916ef6
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 19-05-2023 13:34:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/1b0c717ab682507ff41cd8c76024d03882916ef6 [^]

Related to ISSUE-52492: Session timeout on a blocked terminal allows bypassing the block

---
M web/org.openbravo.mobile.core/app/integration/remote-server/BackendServer.js
M web/org.openbravo.mobile.core/app/view/DialogUIHandler.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---