Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052478Retail ModulesWeb POSpublic2023-05-18 03:162023-05-29 07:18
Reporteraxelmercado 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR23Q3 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date2023-03-27
Regression introduced in releaseRR23Q2
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/b714a2ffb27e9bb3f3fa0a0b570263365f9c0f0d [^]
Triggers an Emergency PackNo
Summary0052478: WebPos - Functional BUG of the 'Overpayment' control
DescriptionWhen we have a configuration of a payment type with supplier and overpayment control at 0, when paying a ticket in several methods and depending on the amount (calculation rounding issue), an 'Overpayment' message appears when it is not.
Steps To Reproduce1- In the backoffice, configure a payment method (for example credit card) with a payment provider and overpayment at 0.
2- In the POS, make a sale and pay a part in cash and another part with the configured payment method.
3- Verify that the error 'Overpayment' is displayed, when in fact it is not.





Steps to Reproduce in livebuilds pos2 modules VBS-1
Backoffice
1) Create rounding payment in payment method(Channel Touchpoint type) and payment type (Channel Touchpoint - "VBS-1")
2) Update "Overpayment/Change limit" and "Max Limit Amount" as 0 for Card Payment Method (Channel Touchpoint type)
3) Add Payment Rounding for Card Payment Method (Channel Touchpoint type)
   With Up Rounding 0.5 (For Sales & Returns)
4) Update Product Price "Expedition tent 4 season 2 person" to 350.25


POS VBS-1
1) Add Product "Expedition tent 4 season 2 person"
2) Pay with credit card
3) Error occurred "Overpayment not available"

POS2 VBS-1
1) Add Product "Expedition tent 4 season 2 person"
2) Pay with credit card
3) Error occurred "Overpayment not available"
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0052500RR23Q2.1 closed ranjith_qualiantech_com WebPos - Functional BUG of the 'Overpayment' control 
caused by design defect 0051431 closed ranjith_qualiantech_com Rounding Issue when Payment Provider is Configured 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-05-18 03:16axelmercadoNew Issue
2023-05-18 03:16axelmercadoAssigned To => Retail
2023-05-18 03:16axelmercadoTriggers an Emergency Pack => No
2023-05-18 08:39PracticsIssue Monitored: Practics
2023-05-18 08:54ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2023-05-18 08:54ranjith_qualiantech_comStatusnew => scheduled
2023-05-18 09:26ranjith_qualiantech_comRelationship addedcaused by 0051431
2023-05-18 09:27ranjith_qualiantech_comRegression date => 2023-03-27
2023-05-18 09:27ranjith_qualiantech_comRegression introduced in release => RR23Q2
2023-05-18 09:27ranjith_qualiantech_comRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/b714a2ffb27e9bb3f3fa0a0b570263365f9c0f0d [^]
2023-05-20 11:22hgbotNote Added: 0150001
2023-05-20 11:22hgbotNote Added: 0150002
2023-05-20 11:22hgbotNote Added: 0150003
2023-05-22 07:07ranjith_qualiantech_comSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=26098#r26098
2023-05-22 07:11hgbotNote Added: 0150008
2023-05-22 07:11hgbotNote Added: 0150009
2023-05-22 07:11hgbotNote Added: 0150010
2023-05-22 07:11hgbotNote Added: 0150011
2023-05-22 07:11hgbotResolutionopen => fixed
2023-05-22 07:11hgbotStatusscheduled => closed
2023-05-22 07:11hgbotFixed in Version => RR23Q3
2023-05-22 07:11hgbotNote Added: 0150012
2023-05-22 07:11hgbotNote Added: 0150013
2023-05-22 07:12ranjith_qualiantech_comNote Added: 0150014
2023-05-22 07:12ranjith_qualiantech_comStatusclosed => new
2023-05-22 07:12ranjith_qualiantech_comResolutionfixed => open
2023-05-22 07:12ranjith_qualiantech_comFixed in VersionRR23Q3 =>
2023-05-22 07:12ranjith_qualiantech_comStatusnew => scheduled
2023-05-22 07:13ranjith_qualiantech_comStatusscheduled => closed
2023-05-22 07:13ranjith_qualiantech_comResolutionopen => fixed
2023-05-25 11:19ranjith_qualiantech_comNote Added: 0150292
2023-05-25 11:19ranjith_qualiantech_comStatusclosed => new
2023-05-25 11:19ranjith_qualiantech_comResolutionfixed => open
2023-05-25 11:20ranjith_qualiantech_comStatusnew => scheduled
2023-05-28 07:40hgbotNote Added: 0150349
2023-05-29 07:18hgbotResolutionopen => fixed
2023-05-29 07:18hgbotStatusscheduled => closed
2023-05-29 07:18hgbotNote Added: 0150356
2023-05-29 07:18hgbotFixed in Version => RR23Q3
2023-05-29 07:18hgbotNote Added: 0150357

Notes
(0150001)
hgbot   
2023-05-20 11:22   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1825 [^]
(0150002)
hgbot   
2023-05-20 11:22   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1205 [^]
(0150003)
hgbot   
2023-05-20 11:22   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.selfcheckout/-/merge_requests/42 [^]
(0150008)
hgbot   
2023-05-22 07:11   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.selfcheckout [^]
Changeset: 36813b456c4158b16116714643770abd05e4e0cd
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 18-05-2023 16:08:52
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.selfcheckout/-/commit/36813b456c4158b16116714643770abd05e4e0cd [^]

Related to ISSUE-52478: Rounding payment should not be shown in payment panel

---
M web/org.openbravo.retail.selfcheckout/source/components/providerGroupPanel.js
M web/org.openbravo.retail.selfcheckout/source/panels/selectPaymentPanel.js
---
(0150009)
hgbot   
2023-05-22 07:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.selfcheckout/-/merge_requests/42 [^]
(0150010)
hgbot   
2023-05-22 07:11   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 2304feba0d2b591d33ab5498c3308a3cbc7eb11f
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 20-05-2023 14:51:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/2304feba0d2b591d33ab5498c3308a3cbc7eb11f [^]

Related to ISSUE-52478: Original payment amount should be used for payment validation
* When paying amount with payment provider and rounding is configured,
  then original amount should be used for overpayment and other validation

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/processPayment.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/PaymentMethods.jsx
---
(0150011)
hgbot   
2023-05-22 07:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1825 [^]
(0150012)
hgbot   
2023-05-22 07:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1205 [^]
(0150013)
hgbot   
2023-05-22 07:11   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 794e012aa95f6c0288eb6407672964a5ddd96347
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 20-05-2023 14:50:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/794e012aa95f6c0288eb6407672964a5ddd96347 [^]

Fixed ISSUE-52478: Original Payment amount should be used for payment validation
* When paying amount with payment provider and rounding is configured,
  then original amount should be used for overpayment calculation

---
M web/org.openbravo.retail.posterminal/js/components/mockpayments.js
M web/org.openbravo.retail.posterminal/js/components/modalpayment.js
M web/org.openbravo.retail.posterminal/js/components/modalprovidergroup.js
---
(0150014)
ranjith_qualiantech_com   
2023-05-22 07:12   
Reopening for creating backports
(0150292)
ranjith_qualiantech_com   
2023-05-25 11:19   
Overpayment not available popup appears
Backoffice:
1) Configure credit card with Payment provider
POS
1) Add product with price 30.95
2) Make partial payment of 3.60 in cash.
3) Pay remaining with Credit Card
4) Message 'Overpayment not available' appears.
(0150349)
hgbot   
2023-05-28 07:40   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1214 [^]
(0150356)
hgbot   
2023-05-29 07:18   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1214 [^]
(0150357)
hgbot   
2023-05-29 07:18   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: cf2d4c84d3eea2803ade50b89cc83f50f330765f
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 26-05-2023 10:56:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/cf2d4c84d3eea2803ade50b89cc83f50f330765f [^]

Fixed ISSUE-52478: Added Decimal operation for validating overpayment

---
M web/org.openbravo.retail.posterminal/js/components/mockpayments.js
M web/org.openbravo.retail.posterminal/js/components/modalprovidergroup.js
---