Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052473POS2POSpublic2023-05-17 14:462023-05-25 10:19
Reporterruben_jimenez 
Assigned Toruben_jimenez 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionmainFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052473: RM-6155: It is possible to create sales with a delivery mode that is not allowed for a specific schema.
DescriptionThe issue arises because we store the delivery mode in the order lines, and the deleted lines are kept in the order records. The deleted lines may have a different delivery mode than the rest.
Steps To Reproduce1- Select a product in a schema where the allowed delivery mode is 'PickupInStore'.
2- Delete the product.
3- Switch to a different schema where the delivery mode allowed is not 'PickupInStore'.
4- Select a product.
5- Proceed with the payment.
If you open the ticket through the order screen, the delivery mode of the ticket will be "PickupInStore" instead of "PickAndCarry," which is the only allowed delivery mode for the current schema.
Proposed SolutionIgnore the deleted lines when determining the delivery mode.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005250723Q1.3 closed ruben_jimenez RM-6155: It is possible to create sales with a delivery mode that is not allowed for a specific schema. 
depends on backport 005255223Q2.1 closed ruben_jimenez RM-6155: It is possible to create sales with a delivery mode that is not allowed for a specific schema. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-05-17 14:46ruben_jimenezNew Issue
2023-05-17 14:46ruben_jimenezAssigned To => ruben_jimenez
2023-05-17 14:46ruben_jimenezOBNetwork customer => No
2023-05-17 14:46ruben_jimenezTriggers an Emergency Pack => No
2023-05-17 14:47ruben_jimenezStatusnew => scheduled
2023-05-17 14:47ruben_jimenezSummaryIt is possible to create sales with a delivery mode that is not allowed for a specific schema. => RM-6155: It is possible to create sales with a delivery mode that is not allowed for a specific schema.
2023-05-17 14:55hgbotMerge Request Status => open
2023-05-17 14:55hgbotNote Added: 0149885
2023-05-17 15:00hgbotNote Added: 0149886
2023-05-22 12:43nicola_uvaIssue Monitored: nicola_uva
2023-05-22 13:30nicola_uvaStatusscheduled => acknowledged
2023-05-22 13:30nicola_uvaStatusacknowledged => scheduled
2023-05-24 08:20hgbotMerge Request Statusopen => approved
2023-05-24 08:21hgbotResolutionopen => fixed
2023-05-24 08:21hgbotStatusscheduled => closed
2023-05-24 08:21hgbotNote Added: 0150180
2023-05-24 08:21hgbotFixed in Version => RR23Q3
2023-05-24 08:21hgbotNote Added: 0150181
2023-05-24 08:21hgbotFixed in VersionRR23Q3 => 23Q3
2023-05-24 08:21hgbotNote Added: 0150182
2023-05-24 08:21hgbotNote Added: 0150183
2023-05-24 12:58nicola_uvaStatusclosed => new
2023-05-24 12:58nicola_uvaResolutionfixed => open
2023-05-24 12:58nicola_uvaFixed in Version23Q3 =>
2023-05-24 12:58nicola_uvaStatusnew => acknowledged
2023-05-24 12:58nicola_uvaStatusacknowledged => scheduled
2023-05-24 12:58nicola_uvaStatusscheduled => resolved
2023-05-24 12:58nicola_uvaResolutionopen => fixed
2023-05-25 10:19ruben_jimenezStatusresolved => closed

Notes
(0149885)
hgbot   
2023-05-17 14:55   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1812 [^]
(0149886)
hgbot   
2023-05-17 15:00   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1194 [^]
(0150180)
hgbot   
2023-05-24 08:21   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1194 [^]
(0150181)
hgbot   
2023-05-24 08:21   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: fa16db594cb0126e786c6dd66d2a3e37b10ae2d2
Author: Ruben Jimenez <ruben.jimenez@openbravo.com>
Date: 24-05-2023 06:21:08
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/fa16db594cb0126e786c6dd66d2a3e37b10ae2d2 [^]

Fixed ISSUE-52473: Ignore deleted lines to get delivery mode in sales orders

---
M src/org/openbravo/retail/posterminal/PaidReceiptsFilterProperties.java
---
(0150182)
hgbot   
2023-05-24 08:21   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 32493c0b698eae6d68af228364193d614d956396
Author: Ruben Jimenez <ruben.jimenez@openbravo.com>
Date: 24-05-2023 06:21:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/32493c0b698eae6d68af228364193d614d956396 [^]

Fixed ISSUE-52473: Ignore deleted lines to get delivery mode in sales orders

---
M src/org/openbravo/pos2/master/PaidReceiptProperties.java
---
(0150183)
hgbot   
2023-05-24 08:21   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1812 [^]