Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052468POS2POSpublic2023-05-17 12:542023-05-19 13:25
Reportercberner 
Assigned Tocberner 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q3 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052468: Session timeout dialog bypass pos2 blocked application
DescriptionWhen 2 pos2 are open in different tabs/windows, one of them is marked as blocked and we shouldn't be able to use it until it is refreshed.

This can be bypassed by the session timeout dialog, which appears after the set period of time for the session to expire and allows us to login again and work with an incorrect state.
Steps To Reproduce1. Setup a small session timeout by going to backoffice -> Preferences. Add a new record with property Web POS Session Timeout of 3 mins for example, and mark it as selected and visible to all users.
2. Login WebPOS
3. Open in another tab the same WebPOS and complete a ticket in this one
4. Go back to the other tab and wait for session timeout to happen, then login again
5. After logging in, a duplicate ticket error appears as part of the console and terminal log, this shows us that we're using the incorrect state.
Proposed SolutionDon't allow dialogUIHandler dialogs to appear on a blocked terminal.
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0051016 closed Retail Prevent opening the same application in more than one tab 
depends on backport 005249223Q2.1 closed cberner Session timeout dialog bypass pos2 blocked application 
depends on backport 005249323Q1.3 closed cberner Session timeout dialog bypass pos2 blocked application 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-05-17 12:54cbernerNew Issue
2023-05-17 12:54cbernerAssigned To => Retail
2023-05-17 12:54cbernerTriggers an Emergency Pack => No
2023-05-17 12:54cbernerAssigned ToRetail => cberner
2023-05-17 12:59hgbotNote Added: 0149875
2023-05-17 13:01hgbotNote Added: 0149876
2023-05-18 11:56rafarodaRelationship addedrelated to 0051016
2023-05-18 15:05ngarciaIssue Monitored: ngarcia
2023-05-19 12:59AugustoMauchStatusnew => scheduled
2023-05-19 13:25hgbotResolutionopen => fixed
2023-05-19 13:25hgbotStatusscheduled => closed
2023-05-19 13:25hgbotNote Added: 0149976
2023-05-19 13:25hgbotFixed in Version => 23Q3
2023-05-19 13:25hgbotNote Added: 0149977
2023-05-19 13:25hgbotNote Added: 0149978
2023-05-19 13:25hgbotNote Added: 0149979

Notes
(0149875)
hgbot   
2023-05-17 12:59   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/520 [^]
(0149876)
hgbot   
2023-05-17 13:01   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1106 [^]
(0149976)
hgbot   
2023-05-19 13:25   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1106 [^]
(0149977)
hgbot   
2023-05-19 13:25   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 29deca4e2650b89d1617411caf372f4cd6d6c213
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 19-05-2023 11:25:15
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/29deca4e2650b89d1617411caf372f4cd6d6c213 [^]

Fixes ISSUE-52468: Session timeout dialog bypasses the terminal block when two pos terminals are open

---
M web-jspack/org.openbravo.core2/src/core/user-interface/BrowserTab.js
M web-jspack/org.openbravo.core2/src/core/user-interface/View.js
---
(0149978)
hgbot   
2023-05-19 13:25   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 56fdb1c41ed96b4e1e408e4dd5bbbce533a407df
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 19-05-2023 11:25:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/56fdb1c41ed96b4e1e408e4dd5bbbce533a407df [^]

Related to ISSUE-52468: Session timeout on a blocked terminal allows bypassing the block

---
M web/org.openbravo.mobile.core/app/integration/remote-server/BackendServer.js
M web/org.openbravo.mobile.core/app/view/DialogUIHandler.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0149979)
hgbot   
2023-05-19 13:25   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/520 [^]