Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052460POS2POSpublic2023-05-16 12:302023-07-05 11:35
Reporterablasco 
Assigned Tosreehari 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052460: Sortable Icon in Grid checkbox header column should not break alignment with body container
DescriptionSortable Icon in verified returns header dialog appears on the first column with checkbox.

Checkbox in Header should be aligned with checkboxes in the body with the same columns grid format.

If some fields are sortable, sortable icon appears and breaks the alignment because there is not enough space for both in the same column.

Issue 52286 fix it in portrait mode, but sortable property should work on Portrait totally aligned on grid layout for checkboxes.
Steps To Reproduce*Sortable if true in portrait - Temporal Fix on Issue 52286
- Login
- Open Orders window
- Select an order and open verified returns.

At first, there is no alignment problem, but we should inspect hoy many buttons are on the checkbox header inside, and we would discover a hidden sortable icon.

An overwriting CSS rule in grid is hiding this element.
Proposed SolutionSortable Icon should be in the second column for Label, in this case OrderLine.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0052286 closed ablasco Verified Returns Checkboxes not aligned. 
related to defect 0053009 closed sreehari Hidden Sortable Button in Portrait Follow Up Files 
Attached Filespng Screenshot from 2023-05-15 12-17-21.png (70,088) 2023-05-16 12:30
https://issues.openbravo.com/file_download.php?file_id=18532&type=bug
png

png Screenshot from 2023-05-15 12-18-35.png (79,788) 2023-05-16 12:31
https://issues.openbravo.com/file_download.php?file_id=18533&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2023-05-16 12:30ablascoNew Issue
2023-05-16 12:30ablascoAssigned To => Retail
2023-05-16 12:30ablascoFile Added: Screenshot from 2023-05-15 12-17-21.png
2023-05-16 12:30ablascoTriggers an Emergency Pack => No
2023-05-16 12:31ablascoFile Added: Screenshot from 2023-05-15 12-18-35.png
2023-05-22 07:54sreehariAssigned ToRetail => sreehari
2023-05-22 08:52ablascoRelationship addedrelated to 0052286
2023-05-22 08:59ablascoDescription Updatedbug_revision_view_page.php?rev_id=26100#r26100
2023-05-22 08:59ablascoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=26102#r26102
2023-05-22 08:59ablascoProposed Solution updated
2023-05-23 11:18sreehariStatusnew => scheduled
2023-05-30 06:31hgbotNote Added: 0150451
2023-05-30 06:33hgbotNote Added: 0150452
2023-07-05 11:33hgbotResolutionopen => fixed
2023-07-05 11:33hgbotStatusscheduled => closed
2023-07-05 11:33hgbotFixed in Version => 23Q4
2023-07-05 11:33hgbotNote Added: 0152128
2023-07-05 11:33hgbotNote Added: 0152129
2023-07-05 11:35hgbotNote Added: 0152131
2023-07-05 11:35hgbotNote Added: 0152130
2023-07-20 08:09ablascoRelationship addedrelated to 0053009

Notes
(0150451)
hgbot   
2023-05-30 06:31   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1851 [^]
(0150452)
hgbot   
2023-05-30 06:33   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1114 [^]
(0152128)
hgbot   
2023-07-05 11:33   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 3d17b92a7c84d05a5b025c08a08de08ec1384764
Author: Sreehari Venkataraman <sreehari@qualiantech.com>
Date: 05-07-2023 11:31:39
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/3d17b92a7c84d05a5b025c08a08de08ec1384764 [^]

Fixes ISSUE-52460: Added sortable property to listViewColumns
*changed sortable to use false instead of isPortrait

---
M web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsGrid/VerifiedReturnsGrid.jsx
---
(0152129)
hgbot   
2023-07-05 11:33   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1851 [^]
(0152130)
hgbot   
2023-07-05 11:35   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1114 [^]
(0152131)
hgbot   
2023-07-05 11:35   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 28181ac107d10ea1fce3bff5a67eaf9c303b9d65
Author: Sreehari Venkataraman <sreehari@qualiantech.com>
Date: 05-07-2023 11:34:06
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/28181ac107d10ea1fce3bff5a67eaf9c303b9d65 [^]

Fixes ISSUE-52460: Added firstSortableColumnIndex for showing sortable icon

---
M web-jspack/org.openbravo.core2/src/components/Grid/DataGrid/BaseHeaderRender.jsx
---