0052456: Import Entry post process hook not executed when processing node is changed

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0052456

Openbravo ERP

A. Platform

public

2023-05-16 10:17

2023-06-01 10:50

Reporter

gorkaion

Assigned To

caristu

Priority

high

Severity

major

Reproducibility

random

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

approved

Review Assigned To

OBNetwork customer

Gold

Web browser

Modules

Core

Support ticket

64183

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0052456: Import Entry post process hook not executed when processing node is changed

Description

On a clustered environment with 2 application nodes.

If the node handling import entries is changed from node A to node B while node A is still processing Import Entries.

When the node B start processing it searches import entries and queue some that are also queued and to be processed in node A. This means that those import entries are processed in both nodes.

In some cases the Import Entry is processed but the status is left in error with the error message:
"Import entry {importEntryId} could not be processed in node {node A} because active node is {node B}"

We observe that when this happens the process is committed into the database but the Import Entry PostProcess hook is not executed.

We reproduce this problem in a customer that has a postprocess hook on Order requests. When the node switch is done we see some Order requests with the "could not be processed" error in the Import Entry. On these Import Entries but the Sales Order already exists in the database but the related records created by the PostProcess hook are not generated.

There are 2 possible scenarios that could produce above case:
* Scenario 1 When the Import Entry is processed in Node A the Order is committed to the database before the handling check is executed.
* Scenario 2 The processing in Node A does the rollback and leaves the Import Entry with that error. Later the record is processed in Node B and the order is properly generated and committed but the status is not changed to Processed so the post process hook is not executed.

Steps To Reproduce

Rough steps:
- Build a cluster environment with node A and B.
- Generate some Import Entries.
- When all Import Entries are queued in node A switch to node B.
- node B queue all the Import Entries again.
- Make the processing in node B slower so a Import Entry is processed first in node A
- Check that the import entry is left in Error status.

Proposed Solution

- Improve the is handling check to be done before the Import Entry starts to process.
- Check the management of the "could not be processed" OBException to ensure proper rollback is done.

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0052455	closed	caristu	Import Entry processed twice when processing node is changed
related to	defect	0052457	closed	Triage Platform Conn	On cluster environments processing node can be switch even if current node is alive
related to	defect	0052445	closed	AugustoMauch	The margin when checking if we need to replace a cluster instance is too small