Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052454Openbravo ERPA. Platformpublic2023-05-16 09:412023-05-16 10:53
Reportercaristu 
Assigned ToTriage Platform Conn 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052454: API Change: replaced protocol column in c_external_system with ad_protocol_id
DescriptionAs part of the changes introduced with 0051088, the protocol column in c_external_system table has been replaced with the ad_protocol_id column, because now it is a foreign key to the new ad_protocol table. This implies the following API changes:

Model Changes

- Removed column: C_EXTERNAL_SYSTEM.PROTOCOL

Data Changes

- Removed row from table AD_COLUMN - ID: CF08BF5580AB4FDB992AC33D8215A81B
- Removed row from table AD_ELEMENT - ID: 5FB59E57DCF74ED4BA9D3E4C8E7A3CEC
- Removed row from table AD_FIELD - ID: EE2FA47297D6475E9F3652B6637B8511
- Removed row from table AD_REFERENCE - ID: 80D5DD608D9942978C21898D0706C0E4
- Removed row from table AD_REF_LIST - ID: EE1C2F7CCACA42F390A2DBF3E82656BA

Public Java API Changes

- removed method org.openbravo.service.externalsystem.ExternalSystemData.getProtocol(): type java.lang.String
- removed method org.openbravo.service.externalsystem.ExternalSystemData.setProtocol(java.lang.String)
Steps To Reproduce.
Proposed Solution
Additional Information
TagsApproved
Relationships
related to design defect 0051088 closed adrianromero Retail Modules [Payment Limit validation] Event payment limit management should be configurable at organization or touchpoint type level 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-05-16 09:41caristuNew Issue
2023-05-16 09:41caristuAssigned To => Triage Platform Base
2023-05-16 09:41caristuOBNetwork customer => No
2023-05-16 09:41caristuModules => Core
2023-05-16 09:41caristuTriggers an Emergency Pack => No
2023-05-16 09:42caristuRelationship addedrelated to 0051088
2023-05-16 09:56AugustoMauchAssigned ToTriage Platform Base => Triage Platform Conn
2023-05-16 10:18hgbotMerge Request Status => open
2023-05-16 10:18hgbotNote Added: 0149777
2023-05-16 10:19caristuDescription Updatedbug_revision_view_page.php?rev_id=26085#r26085
2023-05-16 10:19caristuDescription Updatedbug_revision_view_page.php?rev_id=26086#r26086
2023-05-16 10:20caristuDescription Updatedbug_revision_view_page.php?rev_id=26087#r26087
2023-05-16 10:23adrianromeroTag Attached: Approved
2023-05-16 10:23caristuSummaryAPI Change: Protocol column in c_external_system is now A => API Change: replaced protocol column in c_external_system with ad_protocol_id
2023-05-16 10:23hgbotMerge Request Statusopen => approved
2023-05-16 10:25hgbotResolutionopen => fixed
2023-05-16 10:25hgbotStatusnew => closed
2023-05-16 10:25hgbotNote Added: 0149778
2023-05-16 10:25hgbotNote Added: 0149779
2023-05-16 10:31caristuDescription Updatedbug_revision_view_page.php?rev_id=26088#r26088
2023-05-16 10:53hgbotNote Added: 0149787

Notes
(0149777)
hgbot   
2023-05-16 10:18   
Merge Request created: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/42 [^]
(0149778)
hgbot   
2023-05-16 10:25   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/backoffice-api [^]
Changeset: 2c056a7bdfcd9ad7a49e2c0309225cf84bcae7ae
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 16-05-2023 08:25:39
URL: https://gitlab.com/openbravo/ci/backoffice-api/-/commit/2c056a7bdfcd9ad7a49e2c0309225cf84bcae7ae [^]

fixes BUG-52454: API changes due to C_External_System.Protocol column removal

---
M java/reference/java.japi.gz
M model/src-db/database/model/tables/C_EXTERNAL_SYSTEM.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_ELEMENT.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
M model/src-db/database/sourcedata/AD_REFERENCE.xml
M model/src-db/database/sourcedata/AD_REF_LIST.xml
---
(0149779)
hgbot   
2023-05-16 10:25   
Merge request merged: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/42 [^]
(0149787)
hgbot   
2023-05-16 10:53   
Repository: https://gitlab.com/openbravo/ci/backoffice-api [^]
Changeset: f30b1d7f466b49c4c4819641c8fede8c8c5e7087
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 16-05-2023 10:53:20
URL: https://gitlab.com/openbravo/ci/backoffice-api/-/commit/f30b1d7f466b49c4c4819641c8fede8c8c5e7087 [^]

related to BUG-52454: push correct java.japi.gz

---
M java/reference/java.japi.gz
---