Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052436Retail ModulesWeb POSpublic2023-05-12 12:082023-05-22 07:48
ReporterLeyre 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR23Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket64274
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052436: The "Web POS Change Service Price Need Approval" preference is not working
DescriptionThe "Web POS Change Service Price Need Approval" preference is not working
Steps To Reproduce1. In the Backend, define the preference "The "Web POS Change Service Price Need Approval":
   * Value = N
   * User = "Vall Blanca Store User"
2. Open the Web POS. Access with the user vallblanca
3. Add a product with a service
4. Modify the price of the service

Result: No approval is shown
Expected result: Show approval
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0041143 closed guillermogil Change price approval should be configurable for services 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-05-12 12:08LeyreNew Issue
2023-05-12 12:08LeyreAssigned To => Retail
2023-05-12 12:08LeyreOBNetwork customer => OBPS
2023-05-12 12:08LeyreSupport ticket => 64274
2023-05-12 12:08LeyreTriggers an Emergency Pack => No
2023-05-12 12:11PracticsIssue Monitored: Practics
2023-05-15 13:25ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2023-05-15 13:25ranjith_qualiantech_comStatusnew => scheduled
2023-05-15 14:06ranjith_qualiantech_comRelationship addedrelated to 0041143
2023-05-18 07:05hgbotMerge Request Status => open
2023-05-18 07:05hgbotNote Added: 0149908
2023-05-22 07:48guillermogilNote Added: 0150022
2023-05-22 07:48hgbotMerge Request Statusopen => approved
2023-05-22 07:48hgbotResolutionopen => fixed
2023-05-22 07:48hgbotStatusscheduled => closed
2023-05-22 07:48hgbotNote Added: 0150023
2023-05-22 07:48hgbotFixed in Version => RR23Q3
2023-05-22 07:48hgbotNote Added: 0150024

Notes
(0149908)
hgbot   
2023-05-18 07:05   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1197 [^]
(0150022)
guillermogil   
2023-05-22 07:48   
Pref "Web POS Change Service Price Need Approval" is not an approval preference.

If Pref "Web POS Change Service Price Need Approval" is enabled,
then approval will be asked if Pref. "Web POS set Price approval" is configured

If Pref "Web POS Change Service Price Need Approval" is disabled,
then approval will not be asked
(0150023)
hgbot   
2023-05-22 07:48   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1197 [^]
(0150024)
hgbot   
2023-05-22 07:48   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 6dae367270d8ed10e9ba20fe05d2203b26ef2e5e
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 22-05-2023 05:48:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/6dae367270d8ed10e9ba20fe05d2203b26ef2e5e [^]

Fixed ISSUE-52436: Approval should be asked if service produce price is changed
* Pref "Web POS Change Service Price Need Approval" is not an approval preference.
* If Pref "Web POS Change Service Price Need Approval" is enabled,
    then approval will be asked if Pref. "Web POS set Price approval" is configured
* If Pref "Web POS Change Service Price Need Approval" is disabled,
    then approval will not be asked

---
M web/org.openbravo.retail.posterminal/js/actionpreparation/SetLinePriceApproval.js
---