Openbravo Issue Tracking System - POS2
View Issue Details
0052427POS2Corepublic2023-05-11 19:302023-06-05 12:20
gorka_gil 
AugustoMauch 
highminorN/A
closedfixed 
5
 
23Q3 
No
0052427: FilterBar: disable debounce when filter is not an input text
The filters of a filterable grid uses a debounce to avoid doing a request in each key pressed, which is ok.

But when the filter it is a combo, a check box or any other type different of a input text, we should not use a debounce.

Also when the user is writing in the input text and press enter, on that case we also don't want to use a debounce.
Go to cash management,
change from cash to usa cash,
Problem -> the grid takes some time (500ms) to render the changes

Without the debounce it is inmediate
No tags attached.
Issue History
2023-05-11 19:30gorka_gilNew Issue
2023-05-11 19:30gorka_gilAssigned To => Triage Platform Base
2023-05-11 19:30gorka_gilTriggers an Emergency Pack => No
2023-05-31 18:07hgbotNote Added: 0150559
2023-05-31 19:49AugustoMauchAssigned ToTriage Platform Base => AugustoMauch
2023-06-05 12:20hgbotResolutionopen => fixed
2023-06-05 12:20hgbotStatusnew => closed
2023-06-05 12:20hgbotNote Added: 0150734
2023-06-05 12:20hgbotFixed in Version => 23Q3
2023-06-05 12:20hgbotNote Added: 0150735

Notes
(0150559)
hgbot   
2023-05-31 18:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1121 [^]
(0150734)
hgbot   
2023-06-05 12:20   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1121 [^]
(0150735)
hgbot   
2023-06-05 12:20   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: f6b0a9dab9aceee834f3b99df7c162a655b964a0
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 05-06-2023 10:19:42
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/f6b0a9dab9aceee834f3b99df7c162a655b964a0 [^]

Fixes ISSUE-52427: Debounce in only needed on text filters in FilterBar

The onChange function should only be debounced when editing a text filter, to avoid doing too many onChange calls
while the user is typing. When any other filter is updated, or when filters are cleared, it is better if the
onChange function is directly invoked

---
M web-jspack/org.openbravo.core2/src/components/FilterableGrid/FilterBar.jsx
---