Openbravo Issue Tracking System - POS2 | |||||
View Issue Details | |||||
ID | Project | Category | View Status | Date Submitted | Last Update |
0052402 | POS2 | Core | public | 2023-05-09 19:40 | 2023-06-29 15:57 |
Reporter | gorka_gil | ||||
Assigned To | meriem_azaf | ||||
Priority | high | Severity | minor | Reproducibility | N/A |
Status | closed | Resolution | fixed | ||
Platform | OS | 5 | OS Version | ||
Product Version | |||||
Target Version | Fixed in Version | 23Q4 | |||
Merge Request Status | |||||
Review Assigned To | |||||
OBNetwork customer | |||||
Support ticket | |||||
Regression level | |||||
Regression date | |||||
Regression introduced in release | |||||
Regression introduced by commit | |||||
Triggers an Emergency Pack | No | ||||
Summary | 0052402: WrapTextParams: not working with $ symbol and when the name of the params appears more than once | ||||
Description | WrapTextParams makes parameters of a message to transfrom into a span that can be set css styles. but it firsts reemplace the parameters and then replace the params with the html span components In this example label: 'a %1 b %2 c' Problem 1: %1 = $ -> it doesn't create the span because the regex don't recognize it since the $ it has meaning in regex Example: Message: "You are going to deposit $8 in USA Cash" Parameters: ['$8', 'USA Cash'] Expected: "You are going to deposit <span>$8</span> in <span>USA Cash</span>" Received: "You are going to deposit $8 in <span>USA Cash</span>" Problem 2: %2 = c -> it gives an error in console because it setting the same span in two ocassions, since the c value exists so try to create 2 spans for it instead one. Example: Parameter: "Cash" Message: "You are going to add Cash with Cashier shift event." Expected: "You are going to add [[Cash]] with Cashier shift event." Received: "You are going to add [[Cash]] with [[Cash]]ier shift event." | ||||
Steps To Reproduce | - Login in POS2 - Open Cash Management option in the menu - Do a New Deposit in Cash of 10 with "Other Cash Deposit" - Check the error in the console log (check attached screenshot) - Do a New Deposit in USA Cash of 5 with any event - Check that the confirm popup is highlighting "deposit" word instead of "$8" | ||||
Proposed Solution | |||||
Additional Information | |||||
Tags | No tags attached. | ||||
Relationships | |||||
Attached Files | Screenshot from 2023-05-09 11-28-28.png (108,664) 2023-05-10 12:11 https://issues.openbravo.com/file_download.php?file_id=18511&type=bug WarningFix.diff (895) 2023-05-10 13:21 https://issues.openbravo.com/file_download.php?file_id=18513&type=bug | ||||
Issue History | |||||
Date Modified | Username | Field | Change | ||
2023-05-09 19:40 | gorka_gil | New Issue | |||
2023-05-09 19:40 | gorka_gil | Assigned To | => Triage Platform Base | ||
2023-05-09 19:40 | gorka_gil | Triggers an Emergency Pack | => No | ||
2023-05-10 08:38 | migueldejuana | Description Updated | bug_revision_view_page.php?rev_id=26056#r26056 | ||
2023-05-10 12:10 | migueldejuana | Description Updated | bug_revision_view_page.php?rev_id=26057#r26057 | ||
2023-05-10 12:10 | migueldejuana | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=26059#r26059 | ||
2023-05-10 12:11 | migueldejuana | File Added: Screenshot from 2023-05-09 11-28-28.png | |||
2023-05-10 12:19 | migueldejuana | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=26060#r26060 | ||
2023-05-10 12:20 | migueldejuana | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=26061#r26061 | ||
2023-05-10 13:21 | migueldejuana | File Added: WarningFix.diff | |||
2023-05-10 13:35 | migueldejuana | Note Added: 0149561 | |||
2023-06-21 11:21 | AugustoMauch | Assigned To | Triage Platform Base => meriem_azaf | ||
2023-06-22 12:18 | hgbot | Note Added: 0151495 | |||
2023-06-22 14:04 | AugustoMauch | Status | new => scheduled | ||
2023-06-29 15:57 | hgbot | Note Added: 0151864 | |||
2023-06-29 15:57 | hgbot | Resolution | open => fixed | ||
2023-06-29 15:57 | hgbot | Status | scheduled => closed | ||
2023-06-29 15:57 | hgbot | Fixed in Version | => 23Q4 | ||
2023-06-29 15:57 | hgbot | Note Added: 0151865 |
Notes | |||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|