Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052379POS2POSpublic2023-05-08 12:062023-06-19 15:09
Reporterebecerra 
Assigned Toebecerra 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052379: The payment information shown in HWM display must be relative to prepayment or split check
DescriptionWhen using prepaid or split checks, the payment information displayed in the HWM must be linked to the subtotal which is selected instead off for the whole ticket.

Case 1: For normal payments must be like currently (no changes)(Use whole ticket)

Case 2: Ticket with prepayments

Case 3. Ticket with split check
Steps To ReproduceCase 1:

In this example the ticket total amount is 17.90

1. Create a ticket and add products
2. Overpay it with Cash

     Check the HWM display:
       - Paid: Total ticket amount
       - Change: Cash change amount

     See: I_52379-Standard.png

Case 2 (Terminal must be configured to allow prepayments):

Pre: prepayments are configured as 50% and the ticket total amount is 17.90

1. Create a ticket and add products
2. Select a business partner
3. Select a delivery condition different from "Pick and Carry"
4. Select the prepayment section (subtotal 1) and overpay it with Cash (10.00)
     
     Check the HWM display:
       - Paid: 8.95
       - Change: 1.05
  
     See: I_52379-Prepayment.png

5. Select the "Subtotal remaining" section
     
     Check the HWM display:
       - Paid: 0.00
       - Remaining to pay: 8.95
  
     See: I_52379-SplitCheck-Remaining.png

Case 3:

In this example the ticket total amount is 17.90 and split check in two equals parts
 
1. Create a ticket and add products
2. Go to payment window and "Split Check" in two equals parts
3. Select the "Subtotal - 1" section

       - Paid: 0.00
       - Remaining to pay: 8.95

add a payment to overpay it with Cash (10.00)
     
     Check the HWM display:
       - Paid: 8.95
       - Change: 1.05
  
     See: I_52379-SplitCheck-Sub1.png

4. Select the "Subtotal - 2" section

       - Paid: 0.00
       - Remaining to pay: 8.95

and overpay it with Card (10.00)
     
     Check the HWM display:
       - Paid: 8.95
       - Overpayment: 1.05
  
     See: I_52379-SplitCheck-Sub2.png

5. Select the "Subtotal remaining" section
     
     Check the HWM display:
       - Paid: 17.90
       - Remaining to pay: 0.00
  
     See: I_52379-SplitCheck-Remaining.png
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005238023Q2.2 closed ebecerra The payment information shown in HWM display must be relative to prepayment or split check 
depends on backport 005238123Q1.4 closed ebecerra The payment information shown in HWM display must be relative to prepayment or split check 
Attached Filespng I_52379-Standard.png (54,062) 2023-05-08 12:08
https://issues.openbravo.com/file_download.php?file_id=18496&type=bug
png

png I_52379-Prepayment.png (66,601) 2023-05-08 12:30
https://issues.openbravo.com/file_download.php?file_id=18497&type=bug
png

png I_52379-Prepayment-Remaining.png (68,598) 2023-05-08 12:30
https://issues.openbravo.com/file_download.php?file_id=18498&type=bug
png

png I_52379-SplitCheck-Sub1.png (70,216) 2023-05-08 12:31
https://issues.openbravo.com/file_download.php?file_id=18499&type=bug
png

png I_52379-SplitCheck-Sub2.png (71,098) 2023-05-08 12:31
https://issues.openbravo.com/file_download.php?file_id=18500&type=bug
png

png I_52379-SplitCheck-Remaining.png (70,897) 2023-05-08 12:31
https://issues.openbravo.com/file_download.php?file_id=18501&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2023-05-08 12:06ebecerraNew Issue
2023-05-08 12:06ebecerraAssigned To => Retail
2023-05-08 12:06ebecerraTriggers an Emergency Pack => No
2023-05-08 12:08ebecerraFile Added: I_52379-Standard.png
2023-05-08 12:30ebecerraAssigned ToRetail => ebecerra
2023-05-08 12:30ebecerraStatusnew => scheduled
2023-05-08 12:30ebecerraDescription Updatedbug_revision_view_page.php?rev_id=26020#r26020
2023-05-08 12:30ebecerraSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=26022#r26022
2023-05-08 12:30ebecerraFile Added: I_52379-Prepayment.png
2023-05-08 12:30ebecerraFile Added: I_52379-Prepayment-Remaining.png
2023-05-08 12:31ebecerraFile Added: I_52379-SplitCheck-Sub1.png
2023-05-08 12:31ebecerraFile Added: I_52379-SplitCheck-Sub2.png
2023-05-08 12:31ebecerraFile Added: I_52379-SplitCheck-Remaining.png
2023-05-08 12:31ebecerraDescription Updatedbug_revision_view_page.php?rev_id=26023#r26023
2023-05-08 12:37ebecerraStatusscheduled => acknowledged
2023-05-08 12:38ebecerraStatusacknowledged => scheduled
2023-05-08 14:21guilleaerDescription Updatedbug_revision_view_page.php?rev_id=26026#r26026
2023-05-08 14:21guilleaerSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=26027#r26027
2023-05-09 10:06hgbotNote Added: 0149473
2023-05-09 10:12hgbotNote Added: 0149474
2023-06-19 15:08hgbotNote Added: 0151307
2023-06-19 15:08hgbotResolutionopen => fixed
2023-06-19 15:08hgbotStatusscheduled => closed
2023-06-19 15:08hgbotFixed in Version => RR23Q3
2023-06-19 15:08hgbotNote Added: 0151308
2023-06-19 15:09hgbotNote Added: 0151309
2023-06-19 15:09hgbotNote Added: 0151310

Notes
(0149473)
hgbot   
2023-05-09 10:06   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1182 [^]
(0149474)
hgbot   
2023-05-09 10:12   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1769 [^]
(0151307)
hgbot   
2023-06-19 15:08   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1182 [^]
(0151308)
hgbot   
2023-06-19 15:08   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: a3f3f944a83d08a53c9f6f6cfe60fb3a967922fd
Author: Eduardo Becerra (OB) <eduardo.becerra@openbravo.com>
Date: 19-06-2023 13:08:25
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a3f3f944a83d08a53c9f6f6cfe60fb3a967922fd [^]

Fixes ISSUE-52379: The payment information shown in the HWM display shows info about the current subtotal

---
M web-test/external-device/printing/PrintTemplateGeneration.test.js
M web-test/external-device/printing/PrintUtils.test.js
M web-test/external-device/printing/TicketPrinter.test.js
M web/org.openbravo.retail.posterminal/app/external-device/printing/PrintUtils.js
M web/org.openbravo.retail.posterminal/app/external-device/printing/TicketPrinter.js
M web/org.openbravo.retail.posterminal/res/displaytotal.xml
---
(0151309)
hgbot   
2023-06-19 15:09   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: a4f94f4f9701e22d30f327f12e9c6704c7597a09
Author: Eduardo Becerra (OB) <eduardo.becerra@openbravo.com>
Date: 19-06-2023 13:09:57
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/a4f94f4f9701e22d30f327f12e9c6704c7597a09 [^]

Related to ISSUE-52379: The payment information shown in the HWM display shows info about the current subtotal

---
A web-jspack/org.openbravo.pos2/src/model/global/__test__/SetCurrentPaymentSubtotal.test.js
A web-jspack/org.openbravo.pos2/src/model/global/actions/SetCurrentPaymentSubtotal.js
A web-jspack/org.openbravo.pos2/src/model/global/actions/SetSelectedPaymentSubtotal.js
A web-jspack/org.openbravo.pos2/src/model/ticket/actions/PaymentDisplay.js
A web-jspack/org.openbravo.pos2/src/model/ticket/actions/__test__/PaymentDisplay.test.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentList/SubtotalsGrid.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanel/__mock__/paymentsInitialization.js
M web-jspack/org.openbravo.pos2/src/model/global/GlobalExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/RevertUnpaidSubtotalsUserAction.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/SplitFromOrderUserAction.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/SplitPaymentEqualPartsUserAction.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/RevertUnpaidSubtotals.useraction.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/SplitFromOrder.useraction.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/SplitPaymentByAmount.useraction.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/SplitPaymentEqualParts.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/UIExtension.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SwitchToPayments.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/SwitchToPayments.js
R web-jspack/org.openbravo.pos2/src/model/user-interface/actions/SetSelectedPaymentSubtotal.js
---
(0151310)
hgbot   
2023-06-19 15:09   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1769 [^]