Openbravo Issue Tracking System - POS2 |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0052378 | POS2 | POS | public | 2023-05-08 10:19 | 2023-07-28 10:00 |
|
| Reporter | asier_perez | |
| Assigned To | javierRodriguez | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0052378: 'Order is not found' error message appears when switching between two existing orders |
| Description | When there are two new open orders, and we try to switch from one to the other, an error message appears, saying that the order is not found when it is. |
| Steps To Reproduce | 1) Log in POS2
2) Add any product to the current order
3) Click 'New Order'
4) Add any product to the new order
5) Click 'Switch Order'
6) Select the first order => The error message appears |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0052342 | | closed | caristu | POS2 | No error feedback provided in the UI when some requests fail | | depends on | backport | 0053096 | 23Q3 | closed | javierRodriguez | POS2 | 'Order is not found' error message appears when switching between two existing orders | | has duplicate | defect | 0052827 | | closed | | POS2 | [SALES] Error 'Order not found' when switching between draft tickets | | related to | defect | 0053425 | | closed | ranjith_qualiantech_com | Retail Modules | POS draft tickets should be validated in backoffice when completing/deleting the ticket |
|
| Attached Files |  ordererror.png (112,393) 2023-05-08 10:19
https://issues.openbravo.com/file_download.php?file_id=18495&type=bug
|
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2023-05-08 10:19 | asier_perez | New Issue | |
| 2023-05-08 10:19 | asier_perez | Assigned To | => Retail |
| 2023-05-08 10:19 | asier_perez | File Added: ordererror.png | |
| 2023-05-08 10:19 | asier_perez | Regression level | => Automated tests |
| 2023-05-08 10:19 | asier_perez | Regression date | => 2023-05-05 |
| 2023-05-08 10:19 | asier_perez | Triggers an Emergency Pack | => No |
| 2023-05-08 10:37 | asier_perez | Regression introduced by commit | => https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1080 [^] |
| 2023-05-09 12:21 | hgbot | Note Added: 0149485 | |
| 2023-05-09 12:23 | asier_perez | Regression level | Automated tests => |
| 2023-05-09 12:23 | asier_perez | Regression date | 2023-05-05 => |
| 2023-05-09 12:23 | asier_perez | Regression introduced by commit | https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1080 [^] => |
| 2023-05-09 12:23 | asier_perez | Assigned To | Retail => javierRodriguez |
| 2023-05-09 12:23 | asier_perez | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=26049#r26049 |
| 2023-05-09 12:25 | asier_perez | Description Updated | bug_revision_view_page.php?rev_id=26051#r26051 |
| 2023-05-09 12:25 | caristu | Relationship added | related to 0052342 |
| 2023-05-09 12:28 | asier_perez | Summary | Order is not found when switching from an order to another => 'Order is not found' error message appears when switching between two existing orders |
| 2023-05-09 12:29 | asier_perez | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=26052#r26052 |
| 2023-05-09 13:13 | hgbot | Note Added: 0149490 | |
| 2023-05-09 21:25 | hgbot | Note Added: 0149522 | |
| 2023-05-18 10:48 | javierRodriguez | Status | new => scheduled |
| 2023-05-24 17:15 | hgbot | Resolution | open => fixed |
| 2023-05-24 17:15 | hgbot | Status | scheduled => closed |
| 2023-05-24 17:15 | hgbot | Note Added: 0150237 | |
| 2023-05-24 17:15 | hgbot | Fixed in Version | => RR23Q3 |
| 2023-05-24 17:15 | hgbot | Note Added: 0150238 | |
| 2023-05-24 17:15 | hgbot | Note Added: 0150239 | |
| 2023-05-24 17:15 | hgbot | Note Added: 0150240 | |
| 2023-05-24 17:15 | hgbot | Note Added: 0150241 | |
| 2023-05-25 17:33 | asier_perez | Note Added: 0150303 | |
| 2023-05-25 17:33 | asier_perez | Status | closed => new |
| 2023-05-25 17:33 | asier_perez | Resolution | fixed => open |
| 2023-05-25 17:33 | asier_perez | Fixed in Version | RR23Q3 => |
| 2023-05-25 17:35 | asier_perez | Note Edited: 0150303 | bug_revision_view_page.php?bugnote_id=0150303#r26134 |
| 2023-05-25 18:23 | hgbot | Resolution | open => fixed |
| 2023-05-25 18:23 | hgbot | Status | new => closed |
| 2023-05-25 18:23 | hgbot | Fixed in Version | => RR23Q3 |
| 2023-05-25 18:23 | hgbot | Note Added: 0150309 | |
| 2023-06-27 11:52 | marvintm | Status | closed => new |
| 2023-06-27 11:52 | marvintm | Resolution | fixed => open |
| 2023-06-27 11:52 | marvintm | Fixed in Version | RR23Q3 => |
| 2023-06-27 11:52 | marvintm | Relationship added | has duplicate 0052827 |
| 2023-06-27 15:43 | hgbot | Note Added: 0151673 | |
| 2023-07-06 12:10 | hgbot | Note Added: 0152158 | |
| 2023-07-07 16:11 | hgbot | Note Added: 0152197 | |
| 2023-07-12 08:46 | hgbot | Note Added: 0152368 | |
| 2023-07-12 09:05 | guilleaer | Note Deleted: 0151673 | |
| 2023-07-12 09:05 | guilleaer | Note Deleted: 0152368 | |
| 2023-07-12 09:06 | hgbot | Resolution | open => fixed |
| 2023-07-12 09:06 | hgbot | Status | new => closed |
| 2023-07-12 09:06 | hgbot | Note Added: 0152369 | |
| 2023-07-12 09:06 | hgbot | Fixed in Version | => RR23Q4 |
| 2023-07-12 09:06 | hgbot | Note Added: 0152370 | |
| 2023-07-12 09:07 | hgbot | Note Added: 0152371 | |
| 2023-07-12 09:07 | hgbot | Note Added: 0152372 | |
| 2023-07-12 09:44 | hgbot | Note Added: 0152375 | |
| 2023-07-12 11:19 | hgbot | Note Added: 0152376 | |
| 2023-07-12 11:19 | hgbot | Note Added: 0152377 | |
| 2023-07-28 10:00 | guilleaer | Status | closed => new |
| 2023-07-28 10:00 | guilleaer | Resolution | fixed => open |
| 2023-07-28 10:00 | guilleaer | Fixed in Version | RR23Q4 => |
| 2023-07-28 10:00 | guilleaer | Status | new => scheduled |
| 2023-07-28 10:00 | guilleaer | Status | scheduled => resolved |
| 2023-07-28 10:00 | guilleaer | Resolution | open => fixed |
| 2023-07-28 10:00 | guilleaer | Status | resolved => closed |
| 2023-12-28 10:33 | ranjith_qualiantech_com | Relationship added | related to 0053425 |
|
Notes |
|
|
(0149485)
|
|
hgbot
|
|
2023-05-09 12:21
|
|
|
|
|
(0149490)
|
|
hgbot
|
|
2023-05-09 13:13
|
|
|
|
|
(0149522)
|
|
hgbot
|
|
2023-05-09 21:25
|
|
|
|
|
(0150237)
|
|
hgbot
|
|
2023-05-24 17:15
|
|
|
|
|
(0150238)
|
|
hgbot
|
|
2023-05-24 17:15
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 10a0e14e494339ad7d7be8fb195087d6e73bcffa
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 24-05-2023 15:15:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/10a0e14e494339ad7d7be8fb195087d6e73bcffa [^]
Fixed ISSUE-52378: Refactor duplicated order id sanity check
Instead of using paid receipt request to validate if an order id has been used for any other order,
a new web service is created to check it
Paid receipt web service fails if the order id which the application is trying to check does not exist.
This fail action makes the application to show an error as a notification.
For that reason, a new web service is created. This ws only fails due to technical errors. If the order exist,
the response has an exist parametes set to true, otherwise, false
- Create utility java class to find orders and avoid to have duplicated code
- Create new web service
- Refactor isOrderIdUsedInBackend function to use this new ws
---
A src/org/openbravo/retail/posterminal/CheckOrderExist.java
A src/org/openbravo/retail/posterminal/utility/OrderFinder.java
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/LoadTicketUtils.js
---
|
|
|
|
(0150239)
|
|
hgbot
|
|
2023-05-24 17:15
|
|
|
|
|
(0150240)
|
|
hgbot
|
|
2023-05-24 17:15
|
|
|
|
|
(0150241)
|
|
hgbot
|
|
2023-05-24 17:15
|
|
|
|
|
(0150303)
|
|
asier_perez
|
2023-05-25 17:33
(edited on: 2023-05-25 17:35) |
|
The fix should have been executed against try-pos2 since the error reported was causing some Cypress tests to fail. The fix is incomplete because it causes more errors on try-pos2. These errors can be seen here: https://builds.openbravo.com/job/mod-cypress/2712/ [^]
Once the fix is ready, but before merging it, skipped tests should be unskipped in order to check if everything is fixed. These tests are mainworkflows.spec and the last test of returnOrder.spec.
|
|
|
|
(0150309)
|
|
hgbot
|
|
2023-05-25 18:23
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: b05834346e9f613038af31cc5215ebf64b216d7a
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 25-05-2023 18:23:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/b05834346e9f613038af31cc5215ebf64b216d7a [^]
Revert " Related to ISSUE-52378: Improve log error message if something went wrong"
This reverts commit 7a008914ab97d7da3a96417d409bd77953259386.
Revert "Related to ISSUE-52378: Create message to send on error"
This reverts commit 4a1409097e8dbe7e9a2f98bca8f5177ac4be8637.
Revert "Related to ISSUE-52378: Refactor json to send if something went wrong during execution"
This reverts commit ac5f5be31b054698ad3d6ccacd4fd78b3e0a5f62.
Revert "Fixed ISSUE-52378: Refactor duplicated order id sanity check"
This reverts commit 10a0e14e494339ad7d7be8fb195087d6e73bcffa.
---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/LoadTicketUtils.js
R src/org/openbravo/retail/posterminal/CheckOrderExist.java
R src/org/openbravo/retail/posterminal/utility/OrderFinder.java
---
|
|
|
|
(0152158)
|
|
hgbot
|
|
2023-07-06 12:10
|
|
|
|
|
(0152197)
|
|
hgbot
|
|
2023-07-07 16:11
|
|
|
|
|
(0152369)
|
|
hgbot
|
|
2023-07-12 09:06
|
|
|
|
|
(0152370)
|
|
hgbot
|
|
2023-07-12 09:06
|
|
|
|
|
(0152371)
|
|
hgbot
|
|
2023-07-12 09:07
|
|
|
|
|
(0152372)
|
|
hgbot
|
|
2023-07-12 09:07
|
|
|
|
|
(0152375)
|
|
hgbot
|
|
2023-07-12 09:44
|
|
|
|
|
(0152376)
|
|
hgbot
|
|
2023-07-12 11:19
|
|
|
|
|
(0152377)
|
|
hgbot
|
|
2023-07-12 11:19
|
|
|