Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052366POS2POSpublic2023-05-05 14:462023-05-12 12:55
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052366: Follow up form in portrait mode does not have a proper layout
DescriptionThe landscape Follow Up form divides its fields in columns:
- In the left it shows fields under the "Information" label such us Service Provider, Estimation Date, Customer, etc
- In the left it shows dates related to status changes of the follow up under the "Dates" label such us Created on, Sent on, etc

The problem is that the way we automatically transform the forms to be rendered in single-column in portrait, fields from the "Information" and "Dates" groups are being mixed
Steps To ReproduceIn the backoffice:
- Configure a service (i.e. Installation Pack) to require a follow up file
- Create a new entry in the Service Provider window, assign it to the organization of the POS terminal you will use

In POS2:
- Add a new GPS handled to the ticket
- Associate to it the Installation Pack service
- Complete the ticket, fill in the follow up information
- Switch to portrait mode
- Open the Follow Up Files menu entry
- Click in the first row of the grid. Note that the form that is open is mixing up fields from the Information and Dates groups.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-05-05 14:46AugustoMauchNew Issue
2023-05-05 14:46AugustoMauchAssigned To => Retail
2023-05-05 14:46AugustoMauchTriggers an Emergency Pack => No
2023-05-05 14:48hgbotNote Added: 0149371
2023-05-05 14:49AugustoMauchAssigned ToRetail => AugustoMauch
2023-05-05 14:49AugustoMauchStatusnew => scheduled
2023-05-12 12:55hgbotResolutionopen => fixed
2023-05-12 12:55hgbotStatusscheduled => closed
2023-05-12 12:55hgbotNote Added: 0149657
2023-05-12 12:55hgbotNote Added: 0149658

Notes
(0149371)
hgbot   
2023-05-05 14:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/merge_requests/26 [^]
(0149658)
hgbot   
2023-05-12 12:55   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/merge_requests/26 [^]
(0149657)
hgbot   
2023-05-12 12:55   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider [^]
Changeset: 7d3133d91e248c65eeb2c30e2555ef3608d48dc5
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 12-05-2023 10:55:12
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/commit/7d3133d91e248c65eeb2c30e2555ef3608d48dc5 [^]

Fixes ISSUE-52366: Ensures Information and Dates fields are not mixed in portrait mode

Because the standard way of transforming a form to a single-column layout does not work for the modified form, we instead
are creating a portrait mode version for it with the expected layout

---
A web-jspack/org.openbravo.pos2.service.provider/src/components/FollowUpServiceWindow/FollowUpServiceDialog/FollowUpServiceDialog.portrait.config.json
M web-jspack/org.openbravo.pos2.service.provider/src/components/FollowUpServiceWindow/FollowUpServiceDialog/FollowUpServiceDialog.config.json
M web-jspack/org.openbravo.pos2.service.provider/src/ob-init.js
---