Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052326POS2POSpublic2023-03-30 20:392023-05-03 18:10
Reporterablasco 
Assigned Toablasco 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version23Q2Fixed in Version23Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052326: TicketLines height in Portrait grid affects landscape
DescriptionHeights in Ticketlines grid in Portrait mode is affecting in Landscape mode.

Grid in TicketLines is redefined in Portrait mode, but adaptation affects Landscape mode heights.

Also alignment when ticketline checkbox is clicked ( in portrait long pressed ) should be adapted.
Steps To Reproduce- Login
- Add Products

TicketLines heights are not correct
Proposed Solution- Redefine different Grid in portrait mode for Ticketlines component
- Define heights correctly in TicketlineCheckboxes.
- Adapt paddings and avoid margins in Checkboxes.
- Related Services should be reviewed.
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0052021 closed ablasco TicketLines height in Portrait grid affects landscape 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-05-03 13:14AugustoMauchTypedesign defect => backport
2023-05-03 13:14AugustoMauchTarget Version => 23Q2
2023-05-03 13:31priyamIssue Monitored: priyam
2023-05-03 13:51hgbotNote Added: 0149211
2023-05-03 18:10hgbotResolutionopen => fixed
2023-05-03 18:10hgbotStatusscheduled => closed
2023-05-03 18:10hgbotFixed in Version => 23Q2
2023-05-03 18:10hgbotNote Added: 0149260
2023-05-03 18:10hgbotNote Added: 0149261
2023-05-03 18:10hgbotNote Added: 0149262

Notes
(0149211)
hgbot   
2023-05-03 13:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1754 [^]
(0149260)
hgbot   
2023-05-03 18:10   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 3d6b4bce009329ecca4f28e6d159837f4f33c019
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 03-05-2023 13:47:52
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/3d6b4bce009329ecca4f28e6d159837f4f33c019 [^]

Fixed ISSUE-52326: TicketLines Height redefined in landscape to adapt properly with components in SwipeButton

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLine.config.json
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineCheckbox.scss
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineLite.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineView.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLines.scss
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLinesLite.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLinesLite.scss
---
(0149261)
hgbot   
2023-05-03 18:10   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1754 [^]
(0149262)
hgbot   
2023-05-03 18:10   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: e83f22fa5d80fbab599397c834a398fd456d9b1e
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 03-05-2023 18:03:43
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/e83f22fa5d80fbab599397c834a398fd456d9b1e [^]

Related to ISSUE-52326 Ticketlines Fine Tuning

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineCheckbox.scss
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLines.scss
---