Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052316POS2Corepublic2023-05-03 10:422023-05-03 16:56
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version23Q1.3Fixed in Version23Q1.2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052316: Popup should not be displayed when the application is refreshed programatically
DescriptionWhen the user tries to refresh the browser manually, a popup is displayed to ensure the state is persisted before refreshing the browser.

But that popup is not needed when the application is refreshed programatically, we could automatically force the persistence of the state as part of that programatical refresh.
Steps To Reproduce- Open POS2
- Log in
- In the back office, do a change in a terminal property (i.e. change the default business partner and address)
- In POS2, refresh the master data. A refresh will be tried because there were changes in the terminal, and the intrusive popup will be displayed that will allow the user to skip the refresh resulting in inconsistencies
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0052314 closed AugustoMauch Popup should not be displayed when the application is refreshed programatically 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-05-03 10:42AugustoMauchTypedefect => backport
2023-05-03 10:42AugustoMauchTarget Version => 23Q1.3
2023-05-03 16:27hgbotNote Added: 0149229
2023-05-03 16:27hgbotResolutionopen => fixed
2023-05-03 16:27hgbotStatusscheduled => closed
2023-05-03 16:27hgbotNote Added: 0149230
2023-05-03 16:27hgbotFixed in Version => RR23Q1.2
2023-05-03 16:27hgbotNote Added: 0149231
2023-05-03 16:34hgbotNote Added: 0149232
2023-05-03 16:56hgbotNote Added: 0149241
2023-05-03 16:56hgbotFixed in VersionRR23Q1.2 => 23Q1.2
2023-05-03 16:56hgbotNote Added: 0149242

Notes
(0149229)
hgbot   
2023-05-03 16:27   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/511 [^]
(0149230)
hgbot   
2023-05-03 16:27   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/511 [^]
(0149231)
hgbot   
2023-05-03 16:27   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 7df99c8cd1f5fd111076786d82fe2855095dad8d
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 03-05-2023 16:19:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/7df99c8cd1f5fd111076786d82fe2855095dad8d [^]

Fixes ISSUE-52316: Adds a function to reload the properly reload the application programatically

The new function OB.App.reload will ensure the state is flushed before the reload, and will also unregister the
onbeforeunload listener to prevent the reload popup from appearing

---
M web/org.openbravo.mobile.core/app/model/application-state/StatePersistence.js
---
(0149232)
hgbot   
2023-05-03 16:34   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1077 [^]
(0149241)
hgbot   
2023-05-03 16:56   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1077 [^]
(0149242)
hgbot   
2023-05-03 16:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 8d601dc96723df0b81e306e693a93c4525af905d
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 03-05-2023 16:46:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/8d601dc96723df0b81e306e693a93c4525af905d [^]

Fixes ISSUE-52316: Uses OB.App.reload instead of window.location.reload

The OB.App.reload function will ensure that the state is persisted before reload and also that the
popup that is open when the user refreshes manually to have time to persist the state is not rendered

---
M web-jspack/org.openbravo.core2/src/components/AppBar/ProfileSelector/ProfileSelector.jsx
M web-jspack/org.openbravo.core2/src/components/AppBar/ProfileSelector/__test__/ProfileSelector.test.jsx
M web-jspack/org.openbravo.core2/src/components/ErrorFallback/ErrorFallback.jsx
M web-jspack/org.openbravo.core2/src/core/authentication/LoginProcess.js
M web-jspack/org.openbravo.core2/src/core/authentication/__test__/LoginProcess.test.js
M web-jspack/org.openbravo.core2/src/core/masterdata/MasterdataRefresh.js
M web-jspack/org.openbravo.core2/src/model/user-interface/user-actions/RefreshMasterdata.js
M web-jspack/org.openbravo.core2/src/registerServiceWorker.js
M web-jspack/org.openbravo.core2/src/serviceWorkerRegistration.js
---