Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052314POS2Corepublic2023-05-03 10:422023-09-26 15:07
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052314: Popup should not be displayed when the application is refreshed programatically
DescriptionWhen the user tries to refresh the browser manually, a popup is displayed to ensure the state is persisted before refreshing the browser.

But that popup is not needed when the application is refreshed programatically, we could automatically force the persistence of the state as part of that programatical refresh.
Steps To Reproduce- Open POS2
- Log in
- In the back office, do a change in a terminal property (i.e. change the default business partner and address)
- In POS2, refresh the master data. A refresh will be tried because there were changes in the terminal, and the intrusive popup will be displayed that will allow the user to skip the refresh resulting in inconsistencies
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005231523Q2.1 closed AugustoMauch Popup should not be displayed when the application is refreshed programatically 
depends on backport 005231623Q1.3 closed AugustoMauch Popup should not be displayed when the application is refreshed programatically 
depends on backport 005276522Q4.2 closed AugustoMauch Popup should not be displayed when the application is refreshed programatically 
depends on backport 005276422Q3.2 closed AugustoMauch Popup should not be displayed when the application is refreshed programatically 
Attached Filesgz 52314_22Q2.tar.gz (2,117) 2023-09-26 15:07
https://issues.openbravo.com/file_download.php?file_id=18996&type=bug
Issue History
Date ModifiedUsernameFieldChange
2023-05-03 10:42AugustoMauchNew Issue
2023-05-03 10:42AugustoMauchAssigned To => AugustoMauch
2023-05-03 10:42AugustoMauchOBNetwork customer => No
2023-05-03 10:42AugustoMauchTriggers an Emergency Pack => No
2023-05-03 10:42AugustoMauchStatusnew => scheduled
2023-05-03 11:39hgbotMerge Request Status => open
2023-05-03 11:39hgbotNote Added: 0149190
2023-05-03 11:46hgbotMerge Request Statusopen => approved
2023-05-03 11:47hgbotMerge Request Statusapproved => open
2023-05-03 12:07hgbotNote Added: 0149192
2023-05-03 13:08hgbotMerge Request Statusopen => approved
2023-05-03 15:46hgbotResolutionopen => fixed
2023-05-03 15:46hgbotStatusscheduled => closed
2023-05-03 15:46hgbotNote Added: 0149221
2023-05-03 15:46hgbotFixed in Version => RR23Q3
2023-05-03 15:46hgbotNote Added: 0149222
2023-05-03 15:46hgbotNote Added: 0149223
2023-05-03 15:46hgbotFixed in VersionRR23Q3 => 23Q3
2023-05-03 15:46hgbotNote Added: 0149224
2023-06-16 08:41AugustoMauchStatusclosed => new
2023-06-16 08:41AugustoMauchResolutionfixed => open
2023-06-16 08:41AugustoMauchFixed in Version23Q3 =>
2023-06-16 08:41AugustoMauchStatusnew => scheduled
2023-06-16 08:41AugustoMauchStatusscheduled => resolved
2023-06-16 08:41AugustoMauchResolutionopen => fixed
2023-06-16 08:41AugustoMauchStatusresolved => closed
2023-06-16 08:42AugustoMauchIssue cloned0052764
2023-06-21 09:26AugustoMauchRelationship addeddepends on 0052765
2023-06-21 09:26AugustoMauchRelationship addeddepends on 0052764
2023-09-26 15:07malsasuaFile Added: 52314_22Q2.tar.gz

Notes
(0149190)
hgbot   
2023-05-03 11:39   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/507 [^]
(0149192)
hgbot   
2023-05-03 12:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1074 [^]
(0149221)
hgbot   
2023-05-03 15:46   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/507 [^]
(0149222)
hgbot   
2023-05-03 15:46   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 003b36ecf8d3534bbee8ffeaca004c64a0162478
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 03-05-2023 11:38:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/003b36ecf8d3534bbee8ffeaca004c64a0162478 [^]

Fixes ISSUE-52314: Adds a function to reload the properly reload the application programatically

The new function OB.App.reload will ensure the state is flushed before the reload, and will also unregister the
onbeforeunload listener to prevent the reload popup from appearing

---
M web/org.openbravo.mobile.core/app/model/application-state/StatePersistence.js
---
(0149223)
hgbot   
2023-05-03 15:46   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1074 [^]
(0149224)
hgbot   
2023-05-03 15:46   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 36f26027a4d5f98d9ccb020829bbe27d300666a7
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 03-05-2023 13:45:22
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/36f26027a4d5f98d9ccb020829bbe27d300666a7 [^]

Fixes ISSUE-52314: Uses OB.App.reload instead of window.location.reload

The OB.App.reload function will ensure that the state is persisted before reload and also that the
popup that is open when the user refreshes manually to have time to persist the state is not rendered

---
M web-jspack/org.openbravo.core2/src/components/AppBar/ProfileSelector/ProfileSelector.jsx
M web-jspack/org.openbravo.core2/src/components/AppBar/ProfileSelector/__test__/ProfileSelector.test.jsx
M web-jspack/org.openbravo.core2/src/components/ErrorFallback/ErrorFallback.jsx
M web-jspack/org.openbravo.core2/src/core/authentication/LoginProcess.js
M web-jspack/org.openbravo.core2/src/core/authentication/__test__/LoginProcess.test.js
M web-jspack/org.openbravo.core2/src/core/masterdata/MasterdataRefresh.js
M web-jspack/org.openbravo.core2/src/model/user-interface/user-actions/RefreshMasterdata.js
M web-jspack/org.openbravo.core2/src/registerServiceWorker.js
M web-jspack/org.openbravo.core2/src/serviceWorkerRegistration.js
---