Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052268Openbravo ERPA. Platformpublic2023-04-26 18:032024-02-12 16:06
Reportershuehner 
Assigned Tomeriem_azaf 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR24Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052268: Update fileUpload library is outdated and should be updated to the latest release to use FileUploadBase#setFileCountMax
DescriptionThis library is outdated (version 1.4) and should be updated to the latest version (1.5)

https://github.com/apache/commons-fileupload/ [^]

That allows us to use FileUploadBase#setFileCountMax which should be either:
- set hardcoded
- make configurable but with sane default value applied by default
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0044937 closed caristu Update fileUpload library 
causes defect 0055292 closed meriem_azaf [24Q2] [BO] Error when importing Inventory via CSV file in Business API Data Load 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-04-26 18:03shuehnerNew Issue
2023-04-26 18:03shuehnerAssigned To => Triage Platform Base
2023-04-26 18:03shuehnerOBNetwork customer => No
2023-04-26 18:03shuehnerModules => Core
2023-04-26 18:03shuehnerTriggers an Emergency Pack => No
2023-04-26 18:03shuehnerIssue generated from0044937
2023-04-26 18:03shuehnerRelationship addedrelated to 0044937
2023-04-26 18:05shuehnerSummaryUpdate fileUpload library is outdated and should be updated to the latest release => Update fileUpload library is outdated and should be updated to the latest release to use FileUploadBase#setFileCountMax
2023-04-26 18:05shuehnerDescription Updatedbug_revision_view_page.php?rev_id=25972#r25972
2023-05-05 10:51shuehnerOBNetwork customerNo => OBPS
2023-05-24 07:18alostaleTypefeature request => defect
2023-05-29 09:27AugustoMauchNote Added: 0150365
2023-05-29 09:27AugustoMauchAssigned ToTriage Platform Base => meriem_azaf
2023-05-31 12:52hgbotMerge Request Status => open
2023-05-31 12:52hgbotNote Added: 0150540
2024-02-12 16:06hgbotMerge Request Statusopen => approved
2024-02-12 16:06hgbotNote Added: 0160633
2024-02-12 16:06hgbotResolutionopen => fixed
2024-02-12 16:06hgbotStatusnew => closed
2024-02-12 16:06hgbotFixed in Version => PR24Q2
2024-02-12 16:06hgbotNote Added: 0160634
2024-04-26 15:33alostaleRelationship addedcauses 0055292

Notes
(0150365)
AugustoMauch   
2023-05-29 09:27   
https://github.com/advisories/GHSA-hfrx-6qgj-fp6c [^]
(0150540)
hgbot   
2023-05-31 12:52   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/899 [^]
(0160633)
hgbot   
2024-02-12 16:06   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/899 [^]
(0160634)
hgbot   
2024-02-12 16:06   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 8069e182437fc9573ea241f6c467f6635e0acd16
Author: Meriem Azaf <meriem.azaf@openbravo.com>
Date: 12-02-2024 16:05:59
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/8069e182437fc9573ea241f6c467f6635e0acd16 [^]

Fixes ISSUE-52268: Update fileUpload library to its latest vesrion (1.5)

Update fileUpload library to the latest version (1.5) to use FileUploadBase#setFileCountMax.

The BaseProcessActionHandler class now uses the new setFileCountMax API to limit the number of file uploads it will support. The exact number is
obtained by checking how many upload parameters are defined for the given process. We need to include as part of the max number the number of
other parameters (such as processId, windowId, etc)

---
A lib/runtime/commons-fileupload-1.5.jar
M legal/Licensing.txt
M modules/org.openbravo.client.application/src/org/openbravo/client/application/process/BaseProcessActionHandler.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
M src-core/.classpath
R lib/runtime/commons-fileupload-1.4.jar
---