Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052191Retail ModulesReturn Receiptpublic2023-04-20 19:202023-04-26 07:44
Reportersofidossant 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionRR23Q3 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression levelPre packaging ( pi )
Regression date2023-03-20
Regression introduced in releaseRR23Q1
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/88694b5b41093f5fdc824cafe373a351923fed3c [^]
Triggers an Emergency PackNo
Summary0052191: EWI org.codehaus.jettison.json.JSONException: JSONObject["deletedLines"] is not a JSONArray.
DescriptionWhen I open a verify return (from cross store) and delete the lines, and continue as an order.
When I pay it, the ewi is generated.

org.codehaus.jettison.json.JSONException: JSONObject["deletedLines"] is not a JSONArray.
    at org.codehaus.jettison.json.JSONObject.getJSONArray(JSONObject.java:440)
    at org.openbravo.retail.productonthefly.hooks.PreOrderLoaderOTFHook.saveProductOnTheFlyProducts(PreOrderLoaderOTFHook.java:54)
    at org.openbravo.retail.productonthefly.hooks.PreOrderLoaderOTFHook.exec(PreOrderLoaderOTFHook.java:44)
    at org.openbravo.retail.productonthefly.hooks.PreOrderLoaderOTFHook$Proxy$_$$_WeldClientProxy.exec(Unknown Source)
    at org.openbravo.retail.posterminal.OrderLoader.executeOrderLoaderPreProcessHook(OrderLoader.java:883)
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:307)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:214)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:165)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:97)
    at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:57)
    at org.openbravo.retail.posterminal.importprocess.OrderImportEntryProcessor$OrderLoaderRunnable.processEntry(OrderImportEntryProcessor.java:64)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:430)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:347)
    at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
    at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at java.base/java.lang.Thread.run(Thread.java:829)
Steps To Reproduce1- Open terminal
2- Verificate Return for another organization (cross store).
3- Select lines.
4- Deleted lines.
5- Add product
6- Pay the sales order.

Check the backoffice with the ewi.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0052235RR23Q2 closed ranjith_qualiantech_com EWI org.codehaus.jettison.json.JSONException: JSONObject["deletedLines"] is not a JSONArray. 
caused by defect 0051588 closed ranjith_qualiantech_com Order goes to Errors While Importing POS Data with OBSecurityException if cross-store return line is deleted 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-04-20 19:20sofidossantNew Issue
2023-04-20 19:20sofidossantAssigned To => Retail
2023-04-20 19:20sofidossantTriggers an Emergency Pack => No
2023-04-24 08:07ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2023-04-24 08:24ranjith_qualiantech_comRelationship addedcaused by 0051588
2023-04-24 08:24ranjith_qualiantech_comRegression level => Pre packaging ( pi )
2023-04-24 08:24ranjith_qualiantech_comRegression date => 2023-03-20
2023-04-24 08:24ranjith_qualiantech_comRegression introduced in release => RR23Q1
2023-04-24 08:24ranjith_qualiantech_comRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/88694b5b41093f5fdc824cafe373a351923fed3c [^]
2023-04-24 08:25ranjith_qualiantech_comStatusnew => scheduled
2023-04-24 14:55maiteIssue Monitored: maite
2023-04-25 07:48ramprakashIssue Monitored: ramprakash
2023-04-25 07:50hgbotNote Added: 0148817
2023-04-25 08:30sreehariAssigned Toranjith_qualiantech_com => sreehari
2023-04-25 12:59ranjith_qualiantech_comAssigned Tosreehari => ranjith_qualiantech_com
2023-04-26 07:44marvintmStatusscheduled => acknowledged
2023-04-26 07:44marvintmStatusacknowledged => scheduled
2023-04-26 07:44hgbotResolutionopen => fixed
2023-04-26 07:44hgbotStatusscheduled => closed
2023-04-26 07:44hgbotNote Added: 0148886
2023-04-26 07:44hgbotFixed in Version => RR23Q3
2023-04-26 07:44hgbotNote Added: 0148887

Notes
(0148817)
hgbot   
2023-04-25 07:50   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1155 [^]
(0148886)
hgbot   
2023-04-26 07:44   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1155 [^]
(0148887)
hgbot   
2023-04-26 07:44   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: c943bf4e2acb6681263d2d8514c8b431ce2fe51a
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 26-04-2023 05:44:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c943bf4e2acb6681263d2d8514c8b431ce2fe51a [^]

Fixed ISSUE-52191: Ticket deletedLines should be initialized with empty array
* When resetting ticket properties, ticket deletedLines
  should be initialized with empty array

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeleteLine.js
---