Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052176POS2POSpublic2023-04-19 13:392023-05-08 07:18
Reporterranjith_qualiantech_com 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version23Q2.1Fixed in Version23Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression levelPackaging and release
Regression date2022-10-19
Regression introduced in release23Q1
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/89948ee8b3e269c090d5868aada87e7560f35a5c [^]
Triggers an Emergency PackNo
Summary0052176: Amount to Keep step should be shown in Close Till
DescriptionAmount to Keep step should be shown in Close Till even there is no sales
Steps To ReproduceLivebuilds pos2 modules
1) Open Store
2) Initial Count Cash (With Amount - 0 for all payment methods)
3) Close Till (without any sales)
4) Only 2 steps (Count Payment method & Post, print & Close) are showing. <-- KO
   Cash to Keep step should be shown

Note: If there is any sales/expected amount, close till without amount to keep. And repeat step from 1 to 4
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0052168 closed ranjith_qualiantech_com Amount to Keep step should be shown in Close Till 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-04-20 08:05ranjith_qualiantech_comTypedefect => backport
2023-04-20 08:05ranjith_qualiantech_comTarget Version => 23Q2
2023-05-02 16:36marvintmTarget Version23Q2 => 23Q2.1
2023-05-03 05:12hgbotNote Added: 0149160
2023-05-08 07:17hgbotMerge Request Statusopen => approved
2023-05-08 07:18hgbotResolutionopen => fixed
2023-05-08 07:18hgbotStatusscheduled => closed
2023-05-08 07:18hgbotNote Added: 0149409
2023-05-08 07:18hgbotFixed in Version => 23Q2
2023-05-08 07:18hgbotNote Added: 0149410

Notes
(0149160)
hgbot   
2023-05-03 05:12   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1751 [^]
(0149409)
hgbot   
2023-05-08 07:18   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1751 [^]
(0149410)
hgbot   
2023-05-08 07:18   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: ad77bc69d0b5a7cddfd9f3e1afab175a0694e556
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 08-05-2023 05:17:51
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/ad77bc69d0b5a7cddfd9f3e1afab175a0694e556 [^]

Fixed ISSUE-52176: CashToKeep step should be shown in Close Till
* If "Allow Cash to Keep" is configured for payment methods, then
  CashToKeep step should be shown in Close Till even there is no expected amount/sales
* If noncash payment method has "Automate movement to Other Account" checked,
  then it should be shown in KeepAmount step of cashup

---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/PostPrintAndCloseStep/utils/getCashupData.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/OpenCashup.js
---