Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052168POS2POSpublic2023-04-19 13:392023-05-02 07:35
Reporterranjith_qualiantech_com 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression levelPackaging and release
Regression date2022-10-19
Regression introduced in release23Q1
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/89948ee8b3e269c090d5868aada87e7560f35a5c [^]
Triggers an Emergency PackNo
Summary0052168: Amount to Keep step should be shown in Close Till
DescriptionAmount to Keep step should be shown in Close Till even there is no sales
Steps To ReproduceLivebuilds pos2 modules
1) Open Store
2) Initial Count Cash (With Amount - 0 for all payment methods)
3) Close Till (without any sales)
4) Only 2 steps (Count Payment method & Post, print & Close) are showing. <-- KO
   Cash to Keep step should be shown

Note: If there is any sales/expected amount, close till without amount to keep. And repeat step from 1 to 4
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0051200 closed ranjith_qualiantech_com Cash up reports : Payments methods with payments in the session but ‘Count Payment in Cash up’ = No are displayed inPOS2 
depends on backport 005217623Q2.1 closed ranjith_qualiantech_com Amount to Keep step should be shown in Close Till 
depends on backport 005217723Q1.3 closed ranjith_qualiantech_com Amount to Keep step should be shown in Close Till 
caused by defect 0050395 closed ranjith_qualiantech_com EWI when cashup if a payment method is not configured to be counted in cash up 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-04-19 13:39ranjith_qualiantech_comNew Issue
2023-04-19 13:39ranjith_qualiantech_comAssigned To => Retail
2023-04-19 13:39ranjith_qualiantech_comOBNetwork customer => No
2023-04-19 13:39ranjith_qualiantech_comTriggers an Emergency Pack => No
2023-04-19 13:39ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2023-04-19 13:44ranjith_qualiantech_comRelationship addedcaused by 0050395
2023-04-19 13:45ranjith_qualiantech_comRelationship addedrelated to 0051200
2023-04-19 13:45ranjith_qualiantech_comStatusnew => scheduled
2023-04-20 06:47hgbotMerge Request Status => open
2023-04-20 06:47hgbotNote Added: 0148614
2023-04-20 08:03ranjith_qualiantech_comStatusscheduled => acknowledged
2023-04-20 08:05ranjith_qualiantech_comRegression level => Packaging and release
2023-04-20 08:05ranjith_qualiantech_comRegression date => 2022-10-19
2023-04-20 08:05ranjith_qualiantech_comRegression introduced in release => 23Q1
2023-04-20 08:05ranjith_qualiantech_comRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/89948ee8b3e269c090d5868aada87e7560f35a5c [^]
2023-04-20 08:05ranjith_qualiantech_comStatusacknowledged => scheduled
2023-04-26 07:18hgbotMerge Request Statusopen => approved
2023-04-26 07:18hgbotResolutionopen => fixed
2023-04-26 07:18hgbotStatusscheduled => closed
2023-04-26 07:18hgbotFixed in Version => 23Q3
2023-04-26 07:18hgbotNote Added: 0148881
2023-04-26 07:18hgbotNote Added: 0148882
2023-04-27 13:31ranjith_qualiantech_comNote Added: 0148994
2023-04-27 13:31ranjith_qualiantech_comStatusclosed => new
2023-04-27 13:31ranjith_qualiantech_comResolutionfixed => open
2023-04-27 13:31ranjith_qualiantech_comFixed in Version23Q3 =>
2023-04-27 13:31ranjith_qualiantech_comStatusnew => scheduled
2023-04-28 07:17hgbotNote Added: 0149052
2023-05-02 07:35hgbotResolutionopen => fixed
2023-05-02 07:35hgbotStatusscheduled => closed
2023-05-02 07:35hgbotFixed in Version => 23Q3
2023-05-02 07:35hgbotNote Added: 0149100
2023-05-02 07:35hgbotNote Added: 0149101

Notes
(0148614)
hgbot   
2023-04-20 06:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1702 [^]
(0148881)
hgbot   
2023-04-26 07:18   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: de3804aa6dc9410d95b8f9c6e130593fa0e3b316
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 26-04-2023 05:18:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/de3804aa6dc9410d95b8f9c6e130593fa0e3b316 [^]

Fixed ISSUE-52168: CashToKeep step should be shown in Close Till
* If "Allow Cash to Keep" is configured for payment methods, then
  CashToKeep step should be shown in Close Till even there is no expected amount/sales

---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/PostPrintAndCloseStep/utils/getCashupData.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/OpenCashup.js
---
(0148882)
hgbot   
2023-04-26 07:18   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1702 [^]
(0148994)
ranjith_qualiantech_com   
2023-04-27 13:31   
Non cash payment should be shown in Amount to keep step
(0149052)
hgbot   
2023-04-28 07:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1739 [^]
(0149100)
hgbot   
2023-05-02 07:35   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 9247e64c66d0515fdc11c584a4a24bf2ad022446
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 02-05-2023 05:35:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/9247e64c66d0515fdc11c584a4a24bf2ad022446 [^]

Fixed ISSUE-52168: NonCash payment methods should be shown in KeepAmount step
* If noncash payment method has "Automate movement to Other Account" checked,
  then it should be shown in KeepAmount step of cashup

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/OpenCashup.js
---
(0149101)
hgbot   
2023-05-02 07:35   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1739 [^]