Openbravo Issue Tracking System - Retail Modules
View Issue Details
0052118Retail ModulesWeb POSpublic2023-04-13 10:422023-05-03 13:24
gorkaion 
sreehari 
highmajoralways
closedfixed 
5
 
RR23Q3 
approved
Gold
61116
No
0052118: Open Receipt of Verified Return missing isVerifiedReturn flag in line
When a verified return is reopened using the Open Receipt it is not loading all the properties related to verified returns. For example the "isVerifiedReturn" flag in the lines. This cause problems in validations/flows done based on that flag.
- Create a ticket Sale1 with a line.
- Create a verified return VRet1 of the Sale1 ticket.
- On Developer tools check that the lines has the isVerifiedReturn flag:
OB.MobileApp.model.receipt.attributes.lines.models[0].attributes.isVerifiedReturn -> true

- Pay and complete the return.
- Click on Open Receipt and open the VRet1 verified return.
- On Developer tools check that the lines does not have the isVerifiedReturn flag:
OB.MobileApp.model.receipt.attributes.lines.models[0].attributes.isVerifiedReturn -> undefined
No tags attached.
diff FIX-52118-patch.diff (8,107) 2023-05-03 13:23
https://issues.openbravo.com/file_download.php?file_id=18475&type=bug
diff FIX-52188-19q3-backport.diff (1,174) 2023-05-03 13:24
https://issues.openbravo.com/file_download.php?file_id=18476&type=bug
Issue History
2023-04-13 10:42gorkaionNew Issue
2023-04-13 10:42gorkaionAssigned To => Retail
2023-04-13 10:42gorkaionOBNetwork customer => Gold
2023-04-13 10:42gorkaionSupport ticket => 61116
2023-04-13 10:42gorkaionTriggers an Emergency Pack => No
2023-04-15 08:34sreehariAssigned ToRetail => sreehari
2023-04-15 08:34sreehariStatusnew => scheduled
2023-04-25 08:07hgbotMerge Request Status => open
2023-04-25 08:07hgbotNote Added: 0148818
2023-04-26 16:48hgbotMerge Request Statusopen => approved
2023-04-26 16:49hgbotResolutionopen => fixed
2023-04-26 16:49hgbotStatusscheduled => closed
2023-04-26 16:49hgbotNote Added: 0148955
2023-04-26 16:49hgbotFixed in Version => RR23Q3
2023-04-26 16:49hgbotNote Added: 0148956
2023-05-03 13:23sreehariFile Added: FIX-52118-patch.diff
2023-05-03 13:24sreehariFile Added: FIX-52188-19q3-backport.diff

Notes
(0148818)
hgbot   
2023-04-25 08:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1156 [^]
(0148955)
hgbot   
2023-04-26 16:49   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1156 [^]
(0148956)
hgbot   
2023-04-26 16:49   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 85559a7c592d365fe9187bb9df8e68c587fffe90
Author: Sreehari Venkataraman <sreehari@qualiantech.com>
Date: 26-04-2023 14:48:42
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/85559a7c592d365fe9187bb9df8e68c587fffe90 [^]

Fixes ISSUE-52118: Fixed isVerifiedReturn flag missing in Open ReceiptĀ of Verified Return

---
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M web-test/model/business-object/ticket/actions/CreateReplaceTicket.test.js
M web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/tax-rules.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/LoadTicketUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CreateReplaceTicket.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CreateTicketFromQuotation.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/ReactivateQuotation.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---