Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052111Retail ModulesWeb POSpublic2023-04-12 17:462023-05-10 07:25
Reporterranjith_qualiantech_com 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR23Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket57514
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052111: Problem with SVAP adjust price with price Modification & Discount
DescriptionWhen product has both price modification & discount, after adjusting price, line price is less then limit price
Steps To ReproduceBackoffice
1) Preference
   Enable "Web POS Loss Sales Approval" as "Y"
   Enable "Web POS Enable Loss Sales" as "Y"
2) Add Price Modification reasons
3) Add Discount
   Type: Discount Per Total Amount
   Total Receipt: 100
   Amount: 10
4) Product - Avalanche transceiver
   Change Limit Price to "100" for "The White Valley Group Sale Price List Version" price list version

POS
1) Add product "Avalanche transceiver"
2) Change Price to 10 with Price MOdification
3) Click Total Button
4) Adjust Price in the popup
5) After adjusting, discount is added with amount 10. And line price is 90 <-- KO

Current Result <-- KO (Since, line price is less then limit price)
Line Price: 90
Discount Amount: 10

Expected Result
Line Price: 100
Visible Discount Amount: 0

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0051763 closed ranjith_qualiantech_com Problem with SVAP adjust price when you put a modification price reason 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-04-12 17:46ranjith_qualiantech_comNew Issue
2023-04-12 17:46ranjith_qualiantech_comAssigned To => ranjith_qualiantech_com
2023-04-12 17:46ranjith_qualiantech_comOBNetwork customer => No
2023-04-12 17:46ranjith_qualiantech_comTriggers an Emergency Pack => No
2023-04-12 17:47ranjith_qualiantech_comRelationship addedrelated to 0051763
2023-04-13 07:17ranjith_qualiantech_comStatusnew => scheduled
2023-04-20 13:32hgbotMerge Request Status => open
2023-04-20 13:32hgbotNote Added: 0148638
2023-05-05 13:42ngarciaOBNetwork customerNo => Gold
2023-05-05 13:42ngarciaSupport ticket => 57514
2023-05-10 07:25hgbotMerge Request Statusopen => approved
2023-05-10 07:25hgbotResolutionopen => fixed
2023-05-10 07:25hgbotStatusscheduled => closed
2023-05-10 07:25hgbotFixed in Version => RR23Q3
2023-05-10 07:25hgbotNote Added: 0149527
2023-05-10 07:25hgbotNote Added: 0149528

Notes
(0148638)
hgbot   
2023-04-20 13:32   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1149 [^]
(0149527)
hgbot   
2023-05-10 07:25   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: ec2e9630f5e88188c232c9cbfbbe656a1667ac0e
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 10-05-2023 05:25:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/ec2e9630f5e88188c232c9cbfbbe656a1667ac0e [^]

Fixed ISSUE-52111: Discount should be adjusted after adjusting line price
* When adjusting line price, Discount amount should be adjusted
  after line price is adjusted for price modification
* Refactored code by removing discounts filter for each line calculation

---
M web/org.openbravo.retail.posterminal/js/utils/lossSalesUtils.js
---
(0149528)
hgbot   
2023-05-10 07:25   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1149 [^]