Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052090POS2POSpublic2023-04-11 10:322023-04-11 15:45
Reporterandre_montenegro 
Assigned Toasier_perez 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression levelAutomated tests
Regression date2023-04-05
Regression introduced in release
Regression introduced by commithttps://gitlab.com/openbravo/ci/modules/org.openbravo.retail.giftcards.pos2-sampledata/-/commit/26b63317484ad01e278bdbb5f44f36612d640d88 [^]
Triggers an Emergency PackNo
Summary0052090: Cypress tests fails when closing Till due not all payment methods are being taken in account when cash up
DescriptionFailures are caused by the creation of "Gift Cards" as payment method, as they are not taken in account as payment method while closing till and then the Cypress function "cy.matchExpectedAllVisiblePMAmounts()" wrongly defines the number of payment methods to match as it takes the number from:

OB.App.State.getState().UI.cashupInProgress.paymentMethodsInfo.length

As OB.App.State.getState().UI.cashupInProgress.paymentMethodsInfo.length value is 5, test is searching for a 5th line when matching values and as it does not find it, test fails.
Steps To ReproduceExecute automatic Cypress tests.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Cash Up tests -- Close Till -- Goes to Close Till window and completes Cash Up (failed).png (147,850) 2023-04-11 10:32
https://issues.openbravo.com/file_download.php?file_id=18357&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2023-04-11 10:32andre_montenegroNew Issue
2023-04-11 10:32andre_montenegroAssigned To => asier_perez
2023-04-11 10:32andre_montenegroFile Added: Cash Up tests -- Close Till -- Goes to Close Till window and completes Cash Up (failed).png
2023-04-11 10:32andre_montenegroOBNetwork customer => No
2023-04-11 10:32andre_montenegroRegression level => Automated tests
2023-04-11 10:32andre_montenegroRegression date => 2023-04-05
2023-04-11 10:32andre_montenegroRegression introduced by commit => https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.giftcards.pos2-sampledata/-/commit/26b63317484ad01e278bdbb5f44f36612d640d88 [^]
2023-04-11 10:32andre_montenegroTriggers an Emergency Pack => No
2023-04-11 11:58hgbotMerge Request Status => open
2023-04-11 11:58hgbotNote Added: 0148358
2023-04-11 12:10asier_perezStatusnew => scheduled
2023-04-11 15:42hgbotMerge Request Statusopen => approved
2023-04-11 15:45hgbotResolutionopen => fixed
2023-04-11 15:45hgbotStatusscheduled => closed
2023-04-11 15:45hgbotFixed in Version => 23Q3
2023-04-11 15:45hgbotNote Added: 0148363
2023-04-11 15:45hgbotNote Added: 0148364

Notes
(0148358)
hgbot   
2023-04-11 11:58   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1681 [^]
(0148363)
hgbot   
2023-04-11 15:45   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7f7477f641a45fae589c31da474027d37b49be21
Author: Asier Perez <asier.perez@openbravo.com>
Date: 11-04-2023 14:00:39
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7f7477f641a45fae589c31da474027d37b49be21 [^]

Fixes ISSUE-52090: Cypress tests fails when closing Till due not all payment methods are being taken in account when cash up

---
M web-jspack/org.openbravo.pos2/src-test/cypress/functions/countMoney.js
---
(0148364)
hgbot   
2023-04-11 15:45   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1681 [^]