Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052057POS2POSpublic2023-04-04 09:542023-05-11 17:12
Reporterablasco 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052057: Customer Form Layout change ( 1 column to 2 column ) in portrait mode if input field is modified
DescriptionNew Customer Form breaks if any input field is modified.

Form Layout changes from 1 column to two column view, due to adaptation in portrait mode.

When input changes its value, the component renders to 2 columns, which is the case for landscape mode.
Steps To Reproduce- Login
- Search new Customer
- Click on New Customer
- Changes the value of any input field

Customer Form breaks the layout in portrait mode.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesgif VIPCrash.gif (317,330) 2023-04-04 09:54
https://issues.openbravo.com/file_download.php?file_id=18340&type=bug
Issue History
Date ModifiedUsernameFieldChange
2023-04-04 09:54ablascoNew Issue
2023-04-04 09:54ablascoAssigned To => AugustoMauch
2023-04-04 09:54ablascoFile Added: VIPCrash.gif
2023-04-04 09:54ablascoOBNetwork customer => No
2023-04-04 09:54ablascoTriggers an Emergency Pack => No
2023-05-09 17:31hgbotMerge Request Status => open
2023-05-09 17:31hgbotNote Added: 0149508
2023-05-10 09:31AugustoMauchStatusnew => scheduled
2023-05-11 13:36hgbotMerge Request Statusopen => approved
2023-05-11 17:12hgbotResolutionopen => fixed
2023-05-11 17:12hgbotStatusscheduled => closed
2023-05-11 17:12hgbotFixed in Version => 23Q3
2023-05-11 17:12hgbotNote Added: 0149630
2023-05-11 17:12hgbotNote Added: 0149631

Notes
(0149508)
hgbot   
2023-05-09 17:31   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1089 [^]
(0149630)
hgbot   
2023-05-11 17:12   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: bead439e9fff89062dc100ef3d32b354547dd672
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 11-05-2023 15:26:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/bead439e9fff89062dc100ef3d32b354547dd672 [^]

Fixes ISSUE-52057: BaseForm layout conversion to single-column is no longer reversed

The problem was that the conversion to single-column was not being done in the proper place, and as a consequence even
though initially the layout was properly converted, the next time the state was updated, the original layout was restored.

To fix this, the conversion is now done in a central place, when the updateState action is managed in the form reducer.

Also a test has been added to check that the form layout is properly converted to single-column in portrait mode.

---
M web-jspack/org.openbravo.core2/src/components/Form/BaseForm.jsx
M web-jspack/org.openbravo.core2/src/components/Form/__test__/BaseForm.test.jsx
M web-jspack/org.openbravo.core2/src/components/Form/transformToSingleColumn.js
---
(0149631)
hgbot   
2023-05-11 17:12   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1089 [^]