Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052049Openbravo ERP07. Sales managementpublic2023-04-03 17:142023-06-12 12:23
Reporterivazquez 
Assigned Tofrancisco_ofarril 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionPR23Q1.1 
Target VersionPR23Q1.1Fixed in VersionPR23Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket61642
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052049: Error modifying order with goods shipments already created
DescriptionThe ERP lets you complete a delivery note even if you change the product in the associated order line.

Reproduced in: https://livebuilds.openbravo.com/pos2_mp_23Q1.1/ [^]

Demonstration video: https://www.awesomescreenshot.com/video/16187338?key=bcafd0d9106674b057aee4ff128dcf6b [^]
Steps To ReproduceFrom the BackOffice:

-Create a new order with one line
-Complete it
-Create a Goods Shipment related to this order
-Reactive the order and change the product of the line
-Complete the goods shipment, you will see that no verification is done with the order, and the goods shipments are completed without any problems.
-Complete the order, which will also be completed correctly and you will get the order with a different product than the goods shipment.
-When you want to cancel the completed good shipment, it notifies you of the inconsistency of the lines.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-04-03 17:14ivazquezNew Issue
2023-04-03 17:14ivazquezAssigned To => Triage Omni OMS
2023-04-03 17:14ivazquezOBNetwork customer => OBPS
2023-04-03 17:14ivazquezModules => Core
2023-04-03 17:14ivazquezTriggers an Emergency Pack => No
2023-04-03 17:15ivazquezSupport ticket => 61642
2023-04-03 17:17PracticsIssue Monitored: Practics
2023-04-18 14:31francisco_ofarrilAssigned ToTriage Omni OMS => francisco_ofarril
2023-04-18 14:31francisco_ofarrilStatusnew => scheduled
2023-04-18 21:32hgbotMerge Request Status => open
2023-04-18 21:32hgbotNote Added: 0148571
2023-04-21 13:06hgbotMerge Request Statusopen => approved
2023-04-21 15:14hgbotMerge Request Statusapproved => open
2023-04-24 08:59hgbotMerge Request Statusopen => approved
2023-04-24 09:31hgbotResolutionopen => fixed
2023-04-24 09:31hgbotStatusscheduled => closed
2023-04-24 09:31hgbotFixed in Version => RR23Q3
2023-04-24 09:31hgbotNote Added: 0148763
2023-04-24 09:31hgbotNote Added: 0148764
2023-04-28 10:38ngarciaStatusclosed => new
2023-04-28 10:38ngarciaResolutionfixed => open
2023-04-28 10:38ngarciaFixed in VersionRR23Q3 =>
2023-04-28 10:54hgbotResolutionopen => fixed
2023-04-28 10:54hgbotStatusnew => closed
2023-04-28 10:54hgbotFixed in Version => RR23Q3
2023-04-28 10:54hgbotNote Added: 0149065
2023-04-28 11:04hgbotNote Added: 0149066
2023-04-28 11:09ngarciaStatusclosed => new
2023-04-28 11:09ngarciaResolutionfixed => open
2023-04-28 11:09ngarciaFixed in VersionRR23Q3 =>
2023-04-28 12:27hgbotNote Added: 0149073
2023-04-28 14:57hgbotNote Added: 0149081
2023-05-02 12:19hgbotResolutionopen => fixed
2023-05-02 12:19hgbotStatusnew => closed
2023-05-02 12:19hgbotFixed in Version => PR23Q3
2023-05-02 12:19hgbotNote Added: 0149119
2023-05-02 12:19hgbotNote Added: 0149120
2023-05-23 12:54hgbotNote Added: 0150137
2023-06-12 12:23hgbotNote Added: 0151053
2023-06-12 12:23hgbotNote Added: 0151054

Notes
(0148571)
hgbot   
2023-04-18 21:32   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1143 [^]
(0148763)
hgbot   
2023-04-24 09:31   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1143 [^]
(0148764)
hgbot   
2023-04-24 09:31   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 861f4f27d9e919af2fdbf1b87165824bd0fc0f35
Author: Francisco Javier Deler O'Farril <francisco.ofarril@openbravo.com>
Date: 24-04-2023 07:31:23
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/861f4f27d9e919af2fdbf1b87165824bd0fc0f35 [^]

Fixes ISSUE-52049: Error modifying order with goods shipments already created.

---
M src/org/openbravo/retail/posterminal/event/OrderLineEventHandler.java
---
(0149065)
hgbot   
2023-04-28 10:54   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 7344e7806e18cfa16a041712dd0a0d5464120d08
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 28-04-2023 10:47:48
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/7344e7806e18cfa16a041712dd0a0d5464120d08 [^]

Revert "Fixes ISSUE-52049: Error modifying order with goods shipments already created."

This reverts commit 861f4f27d9e919af2fdbf1b87165824bd0fc0f35 as is going to be moved to core

---
M src/org/openbravo/retail/posterminal/event/OrderLineEventHandler.java
---
(0149066)
hgbot   
2023-04-28 11:04   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/866 [^]
(0149073)
hgbot   
2023-04-28 12:27   
Merge request closed: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/866 [^]
(0149081)
hgbot   
2023-04-28 14:57   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/867 [^]
(0149119)
hgbot   
2023-05-02 12:19   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: e90ec458da104a9f1610dfa3c7b99d6158c38860
Author: Francisco Javier Deler O'Farril <francisco.ofarril@openbravo.com>
Date: 02-05-2023 10:19:45
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/e90ec458da104a9f1610dfa3c7b99d6158c38860 [^]

Fixes ISSUE-52049: Error modifying order with goods shipments already created.

---
M src/org/openbravo/event/OrderLineEventHandler.java
---
(0149120)
hgbot   
2023-05-02 12:19   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/867 [^]
(0150137)
hgbot   
2023-05-23 12:54   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/891 [^]
(0151053)
hgbot   
2023-06-12 12:23   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/891 [^]
(0151054)
hgbot   
2023-06-12 12:23   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 4040bd026c8ac9a1d2edad4a59fc8e8dd84225a7
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 12-06-2023 10:23:11
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/4040bd026c8ac9a1d2edad4a59fc8e8dd84225a7 [^]

Fixes ISSUE-52049: Move validation to C_ORDERLINE_TRG trigger

---
M src-db/database/model/triggers/C_ORDERLINE_TRG.xml
M src/org/openbravo/event/OrderLineEventHandler.java
---