Openbravo Issue Tracking System - POS2
View Issue Details
0052036POS2POSpublic2022-04-13 14:292023-04-11 16:53
aferraz 
javierRodriguez 
normalmajorhave not tried
closedfixed 
5
 
23Q1.223Q1.2 
No
0052036: JIRA 2740 - Not possible to cancel and replace a prepaid order
Not possible to cancel and replace a prepaid order
In backoffice:
- Enable "Allow prepayments and partial payments" for "POS2SD VBS POS2 Terminal Type" touchpoint type.
- Change "Prepayment Percentage" to 50 for "Vall Blanca Store" organization.

In POS:
- Create a ticket for John Doo and Pickup in store delivery mode.
- Add one unit of Avalanche transceiver and change the price to 100.
- Click on Pay button and pay only the 50€ asked for prepayment.
- Load previous order and click on Cancel and Replace Order.
- Click on Pay button and check you get following error: "Cannot create subtotals, there are already payments."
It should work in the same way it works in Enyo POS:
- Payments added to the original order should be moved to the replace order.
- A new prepayment amount should be calculated for the replace order.
- If new prepayment amount is equal or lower than paid amount, you should be able to complete the replace order without paying the remaining amount (although you can pay it if you want).
- If new prepayment amount is higher than paid amount, you would need to pay at least the full new prepayment amount.
- If replace order total amount is lower than paid amount, a refund should be done.
No tags attached.
blocks defect 0049054 closed javierRodriguez JIRA 2740 - Not possible to cancel and replace a prepaid order 
Issue History
2023-04-03 10:07guilleaerTypedefect => backport
2023-04-03 10:07guilleaerTarget Version => 23Q1.2
2023-04-05 13:11hgbotNote Added: 0148291
2023-04-05 15:31hgbotNote Added: 0148301
2023-04-11 16:53hgbotNote Added: 0148373
2023-04-11 16:53hgbotNote Added: 0148374
2023-04-11 16:53hgbotNote Added: 0148375
2023-04-11 16:53hgbotResolutionopen => fixed
2023-04-11 16:53hgbotStatusscheduled => closed
2023-04-11 16:53hgbotFixed in Version => 23Q1.2
2023-04-11 16:53hgbotNote Added: 0148376

Notes
(0148291)
hgbot   
2023-04-05 13:11   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1673 [^]
(0148301)
hgbot   
2023-04-05 15:31   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1126 [^]
(0148373)
hgbot   
2023-04-11 16:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1126 [^]
(0148374)
hgbot   
2023-04-11 16:53   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: c25e0400e266d80e74ff45a37c37fa4785af98ca
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 05-04-2023 15:31:59
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c25e0400e266d80e74ff45a37c37fa4785af98ca [^]

Related to ISSUE-52036: [cancel-replace-prepayments] Set id atribute in payments

---
M src/org/openbravo/retail/posterminal/PaidReceipts.java
---
(0148375)
hgbot   
2023-04-11 16:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1673 [^]
(0148376)
hgbot   
2023-04-11 16:53   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 0660809cac56f8d27ed6358bb296d5025f02cc7e
Author: Javier Rodríguez Regueiro <javier.rodriguez@openbravo.com>
Date: 11-04-2023 14:53:49
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0660809cac56f8d27ed6358bb296d5025f02cc7e [^]

Fixed ISSUE-52036: [cancel-replace-prepayments] Create different flow to...

---
A web-jspack/org.openbravo.pos2/src/model/ticket/actions/__test__/splitReplaceTicketPaymentByAmount.test.js
A web-jspack/org.openbravo.pos2/src/model/ticket/actions/splitReplaceTicketPaymentByAmount.js
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentList/SubtotalFunctions.js
M web-jspack/org.openbravo.pos2/src/model/ticket/DivideLinesFillInAmount.js
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketUtils.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/ReplaceTicket.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/SplitPaymentByAmount.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/TicketUtils.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/SplitPaymentByAmount.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/SplitPrepaymentByAmount.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReplaceTicket.js
---