Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052027Openbravo ERP04. Warehouse managementpublic2023-03-31 09:182023-04-21 13:03
Reporterphilippe_mui 
Assigned ToAtulOpenbravo 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052027: [RM-5814][AWO] User with a role without access to AWO appears in the AWO login screen
DescriptionA user with a role without access to AWO, for example Wizeoo AWO with the role ‘Store Seller 001’ shouldn’t appear in the AWO login screen

This affects to HQ roles too that don’t have access to AWO in the ‘Form Access’ subtab either.

See video attached

https://openbravo.atlassian.net/browse/RM-5814 [^]
Steps To Reproduce1. In User screen, User is set to a role without access to AWO
2. In Role screen, its role is store seller without access to AWO

Current result : The user appear in the login page of AWO

Expected result : user shouldn't appear in the login page of AWO
Proposed Solution
Additional Information
TagsFASH
Relationships
Attached Files? Vidéo sans titre ‐ Réalisée avec Clipchamp (1).mp4 (3,591,388) 2023-03-31 09:18
https://issues.openbravo.com/file_download.php?file_id=18333&type=bug
? Untitled 218.mp4 (2,217,676) 2023-04-03 10:46
https://issues.openbravo.com/file_download.php?file_id=18337&type=bug
Issue History
Date ModifiedUsernameFieldChange
2023-03-31 09:18philippe_muiNew Issue
2023-03-31 09:18philippe_muiAssigned To => Triage Omni WMS
2023-03-31 09:18philippe_muiFile Added: Vidéo sans titre ‐ Réalisée avec Clipchamp (1).mp4
2023-03-31 09:18philippe_muiOBNetwork customer => Gold
2023-03-31 09:18philippe_muiModules => Core
2023-03-31 09:18philippe_muiTriggers an Emergency Pack => No
2023-04-03 10:44philippe_muiTag Attached: FASH
2023-04-03 10:46philippe_muiDescription Updatedbug_revision_view_page.php?rev_id=25817#r25817
2023-04-03 10:46philippe_muiFile Added: Untitled 218.mp4
2023-04-03 10:47philippe_muiSummary[AWO] User with a role without access to AWO appears in the AWO login screen => [RM-5814][AWO] User with a role without access to AWO appears in the AWO login screen
2023-04-03 10:47philippe_muiDescription Updatedbug_revision_view_page.php?rev_id=25818#r25818
2023-04-11 10:36mtaalNote Added: 0148353
2023-04-17 17:06AtulOpenbravoStatusnew => scheduled
2023-04-17 17:06AtulOpenbravoAssigned ToTriage Omni WMS => AtulOpenbravo
2023-04-17 17:10hgbotMerge Request Status => open
2023-04-17 17:10hgbotNote Added: 0148503
2023-04-17 17:21AtulOpenbravoNote Added: 0148504
2023-04-18 11:40hgbotMerge Request Statusopen => approved
2023-04-21 13:03hgbotResolutionopen => fixed
2023-04-21 13:03hgbotStatusscheduled => closed
2023-04-21 13:03hgbotNote Added: 0148722
2023-04-21 13:03hgbotNote Added: 0148723

Notes
(0148353)
mtaal   
2023-04-11 10:36   
Updated expiry to be inline with project jira planning by sprint
(0148503)
hgbot   
2023-04-17 17:10   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/130 [^]
(0148504)
AtulOpenbravo   
2023-04-17 17:21   
Test Plan

- In AWO Instance created a Role using Inheritance, make sure it does not have access to "Advanced Mobile Warehouse Operations" in the Form Access.
- Create a new User and add above Role to the user. Set Allow Warehouse Operation flag = Yes.
- Navigate to AWO Front End Login Screen.
- Realize that User is not shown in the screen.
- Navigate to the Role created previously.
- In Form Access, add access to "Advanced Mobile Warehouse Operations" form
- Refresh AWO Front End Login Screen.
- Realize that the User is shown now.
(0148722)
hgbot   
2023-04-21 13:03   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations [^]
Changeset: 6eea4a2106f427c1401cc126e3a9c885cf1ec3e2
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 21-04-2023 11:01:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/commit/6eea4a2106f427c1401cc126e3a9c885cf1ec3e2 [^]

Fixes BUG-0052027: [RM-5814][AWO] User with a role without access
to AWO appears in the AWO login screen

**Exists clause of special form access Advanced Mobile Warehouse
Operations was in the outer query where role was not being used in
the query. Now it is included in the sub query where role is query
in order to filter the records based on special form access also.

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/OBAWOLoginUtilsServlet.java
---
(0148723)
hgbot   
2023-04-21 13:03   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/130 [^]