0005202: Implement display logic for tabs [No new BOM creation possible] - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

ID

Project

Category

View Status

Date Submitted

Last Update

0005202

Openbravo ERP

02. Master data management

public

2008-09-23 13:58

2013-01-08 14:13

Reporter

rgoris

Assigned To

AugustoMauch

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS

5

OS Version

Product Version

pi

Target Version

3.0MP19

Fixed in Version

3.0MP19

Merge Request Status

Review Assigned To

dbaz

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0005202: Implement display logic for tabs [No new BOM creation possible]

Description

Implement display logic for tabs to hide Bill of Material tab when isBOM = N
In Grid Mode show always, but display an error when accessing the tab.
----
In case the user forgot to check BOM for a product, then it is not possible to create a new BOM record. In stead of informing the user that for the selected product it is not possible to create a BOM, the window just remains empty and not further clue is given.

Steps To Reproduce

Proposed Solution

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0000571	2.40	closed	alostale	Cannot see the region tab
related to	design defect	0019595	3.0MP19	closed	AugustoMauch	Enable "Display Logic" clauses to be working in Status Bar fields
related to	defect	0033401		closed	collazoandy4	Move display logic from Region tab fields to the tab itself
related to	defect	0033799		closed	NaroaIriarte	AD_Role_ID system variable not working at tab level
related to	defect	0033998		acknowledged	Triage Platform Base	It is possible to edit the Display Logic field on Tab having no modules in in development status
related to	defect	0037153		closed	caristu	Characteristics Configuration tab display logic does not work properly
related to	defect	0046930		closed	alostale	When in a window there are tabs which have a logic to show, and should not be shown, if I go to dropdown I can add it
blocks	design defect	0022723	3.0MP19	closed	gorkaion	Add display logic to reservations related tabs

Attached Files

gif

No-new-BOM-possible.gif (86,645) 2008-09-23 13:58
https://issues.openbravo.com/file_download.php?file_id=271&type=bug
gif

gif

Issue History

Date Modified

Username

Field

Change

2008-09-23 13:58

New Issue

2008-09-23 13:58

Assigned To

=> cromero

2008-09-23 13:58

sf_bug_id

0 => 2124441

2008-09-23 13:58

File Added: No-new-BOM-possible.gif

2008-09-29 11:12

Status

new => scheduled

2008-09-29 11:12

Note Added: 0009230

2008-09-29 11:12

Assigned To

cromero => alostale

2008-09-29 11:12

fix_in_branch

=> trunk

2008-12-10 09:56

Assigned To

alostale => iperdomo

2008-12-10 15:20

Target Version

=> 2.60

2008-12-10 15:20

fix_in_branch

trunk =>

2009-01-19 13:41

version

=> trunk

2009-02-03 17:44

Type

defect => feature request

2009-02-03 17:44

Summary

No new BOM creation possible => Implement display logic for tabs [No new BOM creation possible]

2009-02-03 17:44

Description Updated

2009-10-16 15:45

Issue Monitored: andreaferaco

2009-11-18 09:10

Relationship added

related to 0000571

2011-05-17 13:21

Target Version

3.0MP0 =>

2011-11-28 18:38

Issue Monitored: RafaelCruz

2012-09-18 09:18

Assigned To

iperdomo => alostale

2012-11-23 08:04

Relationship added

related to 0019595

2012-11-23 08:07

Target Version

=> 3.0MP19

2012-11-23 11:53

Issue Monitored: extra

2012-12-05 10:40

Assigned To

alostale => AugustoMauch

2013-01-02 17:32

Issue Monitored: dbaz

2013-01-02 17:32

Review Assigned To

=> dbaz

2013-01-02 17:32

Triggers an Emergency Pack

=> No

2013-01-03 11:02

Checkin

2013-01-03 11:02

Note Added: 0055316

2013-01-03 11:03

Status

scheduled => resolved

2013-01-03 11:03

Resolution

open => fixed

2013-01-03 11:03

Fixed in SCM revision

=> http://code.openbravo.com/erp/devel/pi/rev/43409b2738c4f7b5550fe572be44d9fef451d652 [^]

2013-01-03 11:18

Note Added: 0055317

2013-01-03 11:32

Note Added: 0055318

2013-01-03 11:32

Status

resolved => new

2013-01-03 11:32

Resolution

fixed => open

2013-01-03 14:00

Relationship added

blocks 0022723

2013-01-04 09:53

Checkin

2013-01-04 09:53

Note Added: 0055353

2013-01-04 15:03

Checkin

2013-01-04 15:03

Note Added: 0055362

2013-01-04 15:03

Status

new => resolved

2013-01-04 15:03

Resolution

open => fixed

2013-01-04 15:03

Fixed in SCM revision

http://code.openbravo.com/erp/devel/pi/rev/43409b2738c4f7b5550fe572be44d9fef451d652 [^] => http://code.openbravo.com/erp/devel/pi/rev/c8724afca806207458ff56c89842c4a612001a4f [^]

2013-01-04 15:06

Note Added: 0055363

2013-01-07 16:57

Checkin

2013-01-07 16:57

Note Added: 0055365

2013-01-08 06:08

Checkin

2013-01-08 06:08

Note Added: 0055366

2013-01-08 06:08

Checkin

2013-01-08 06:08

Note Added: 0055367

2013-01-08 12:50

Note Added: 0055374

2013-01-08 14:13

Note Added: 0055380

2013-01-08 14:13

Status

resolved => closed

2013-01-08 14:13

Fixed in Version

=> 3.0MP19

2016-07-01 08:20

Relationship added

related to 0033401

2016-09-01 10:21

Relationship added

related to 0033799

2016-09-15 09:55

Relationship added

related to 0033998

2017-10-27 10:21

Relationship added

related to 0037153

2021-06-17 11:37

Relationship added

related to 0046930

Notes

Repository: erp/devel/pi
Changeset: 43409b2738c4f7b5550fe572be44d9fef451d652
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Jan 03 11:00:14 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/43409b2738c4f7b5550fe572be44d9fef451d652 [^]

Fixes issue 5202: Implemented display logic for tabs

Now the tabs can define display logic, based on the values of its ancestor tabs fields.

Summary of the changes:
-DynamicExpressionParser.java: Adds a new attribute called inpColumnNames, that is only used in the tabs display logic and that will be used to convert the tok
ens to its inp column format. This needs to be done because the display logic is going to feed from the view context, and there the ancestor tab fields are sto
red using its inp column name.

-ob-view-tab.js.ftl: Adds to the view description of the tab the showTabIf property, but only if the tab has a display logic defined.

-OBViewTab.java: Adds the getShowIf method, that is used in ob-view-tab.js.ftl to retrieve the display logic of the tabs

-ob-view-form.js: Calls the updateSubTabVisibility (defined in ob-standard-view.js) whenever a fields changes and loses focus.

-ob-standard-view.js: In the first chunk it wraps the tab display logic in a try block to prevent errors if the display logic is not defined properly (this same thing is done for the fields display logic). The second chunk defines and uses the updateSubTabVisibility function, that based on a view will be used to determine the visibility of all its subtabs. The function is called whenever a new record is selected.
If a subtab that was active in its tabBar is hidden, the first visible tab of that tabBar will be selected, if any. If there are not any remaining visible subt
abs, the whole tabBar will be made invisible.

-ob-standard-window.js: Changes have been made in the functions to move among tabs to take into account that it should not be possible to move to a hidden tab.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/DynamicExpressionParser.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-view-tab.js.ftl
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewTab.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M src-db/database/model/tables/AD_TAB.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
---

Test Plan:
- As System Admin, Open Window, Tab and Fields.
- Open in form view the URL tab of the Widget window and enter this in the display logic field: @Widget_Superclass_ID@='C26A68FD8CF347EC9D1FB7E274622450'
- Open in form view the Query tab of the Widget window and enter this in the display logic field: @Widget_Superclass_ID@='2A32CF26F3F64FE39C7F94E9D82497D1'
- Rebuild, restart tomcat, and open as System Admin the Widgets window.
- Select an URL widget, the URL tab should be shown, but not the Query tab.
- Select a Query widget, the QWuery tab should be shown, but not the URL tab.
- Select a HTML widget. Not the Query nor the URL tabs should be shown.
- Create a new widget. By default it is not an URL not a Query widget, so neither of those tabs should be visible. Change its Widget Superclass to URL, the URL tab should be visible.

Check that the shortcuts to move between tabs still work:
- Select a Query widget. The URL subtab will be hidden. This now hidden tab is placed between the Widget Menu Items and the Query tab. Using the shortcut, move between those tabs, and check that the focus is not going to the hidden tab.

Check that if an active tab is hidden, another tab is selected.
- Select a Query widget. The Query tab should be visible. Select that tab, and put the focus back on the header tab.
- Select a non Query widget. The Query tab which was visible at that moment will be hidden, and the first visible tab (Parameter) will be selected.

Check that if no subtabs are visible the whole child tabbar dissapears.
- Change the display logic of level 1 of the Widget window to false, except the one of the Query tab which should be left as it was (@Widget_Superclass_ID@='2A32CF26F3F64FE39C7F94E9D82497D1').
- Rebuild, restart tomcat.
- As system administrator open the Widget window.
- Select a Query widget. Only the Query subtab should be visible.
- Select a non query widget. The only visible tab will be hidden, so the whold child tab bar will dissapear.
- Select again a query widget. The child tab bar will be visible again, and only the Query tab will be shown.

Repository: erp/devel/pi
Changeset: c8724afca806207458ff56c89842c4a612001a4f
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Jan 04 15:01:25 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c8724afca806207458ff56c89842c4a612001a4f [^]

Fixes issue 5202: Preference can be used in the display logic of the tabs

Now the display logic of the tabs can use preference values (i.e. @#ShowAcct@='Y'), and the visibility of the tabs is going to be determined before the tabs are shown to the user (before this change the tabs visibility was only updated after a record was selected).

Summary of the changes:
-DynamicExpresssionParser: The name of the preferences will not be converted to the inp column format

-ob-view-tab.js.ftl: Adds to the definition of the tab the session attributes. These attributes will be the preference attributes used in the tab display logic

-FormInitializationComponent: Includes in the sessionAttributes of the form the attributes used in the tabs display logic

-OBViewTab.java: Returns a JSON object containing the values of the preferences used in the display logic of the tab

-ob-standard-view.js: If the tab comes with session attributes, they are copied to the session attributes of its form. Modifies the places where updateSubtabVisibility is called to ensure that it is called before the tabs are shown to the client, and after the session attributes of the form have been set after selecting a new record. Also changed the attributes of the call to getContextInfo to ensure that it contains the values of the form session attributes.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/DynamicExpressionParser.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-view-tab.js.ftl
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewTab.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---