Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052004POS2POSpublic2023-03-29 10:052023-04-17 13:53
Reportermeriem_azaf 
Assigned Tomeriem_azaf 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052004: Keymap Editor - product from differents sales area on keymap configurator
DescriptionIn the configuration of the products and categories of the keymaps via the editor available on the cashier, we can see that all the products are displayed, and when we select a product that is not available/visible from one sales area to another and well this one simply does not appear
ex : I choose a ruby leffe that belongs to the restaurant sales area and decide to put this product on my take away keymap and well the item will simply not be visible
Steps To Reproduce1- Login in POS2.
2- Go to keymap editor.
3- Choose the keymap Main Terrace Keymap.
4- Click on view versions and after view categories.
5- Choose the keymap category Appetizers and click on view products.
6- Click on link product.
7- Add this product: All mountain ski board Cham.

-> this product should not be added because is not belong to the price list of the Appetizers category.
Proposed SolutionWe should be able to do the check when a product in that grid is clicked to be added to the keymap category. in that case we want to cancel the click and show a notification to the user
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005203723Q2 closed meriem_azaf Keymap Editor - product from differents sales area on keymap configurator 
depends on backport 005203823Q1.2 closed meriem_azaf Keymap Editor - product from differents sales area on keymap configurator 
causes defect 0052180 closed meriem_azaf Not possible to add a product category to a keymap category 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-03-29 10:05meriem_azafNew Issue
2023-03-29 10:05meriem_azafAssigned To => Retail
2023-03-29 10:05meriem_azafOBNetwork customer => No
2023-03-29 10:05meriem_azafTriggers an Emergency Pack => No
2023-03-29 10:05meriem_azafAssigned ToRetail => meriem_azaf
2023-03-29 10:05meriem_azafStatusnew => scheduled
2023-03-29 13:44hgbotMerge Request Status => open
2023-03-29 13:44hgbotNote Added: 0148048
2023-04-03 11:36meriem_azafStatusscheduled => acknowledged
2023-04-03 11:37meriem_azafStatusacknowledged => scheduled
2023-04-17 13:53hgbotMerge Request Statusopen => approved
2023-04-17 13:53hgbotNote Added: 0148480
2023-04-17 13:53hgbotResolutionopen => fixed
2023-04-17 13:53hgbotStatusscheduled => closed
2023-04-17 13:53hgbotFixed in Version => 23Q3
2023-04-17 13:53hgbotNote Added: 0148481
2023-04-20 11:52meriem_azafRelationship addedcauses 0052180

Notes
(0148048)
hgbot   
2023-03-29 13:44   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1649 [^]
(0148480)
hgbot   
2023-04-17 13:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1649 [^]
(0148481)
hgbot   
2023-04-17 13:53   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 1de6d09ccb6345d9a412cf2005b15d7c03a0d6a2
Author: Meriem Azaf <meriem.azaf@openbravo.com>
Date: 17-04-2023 13:17:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/1de6d09ccb6345d9a412cf2005b15d7c03a0d6a2 [^]

Fixes ISSUE-52004: Keymap Editor - product from differents sales area on keymap configurator

In the configuration of the products and categories of the keymaps via the editor available on the cashier, we can see that all the products are displayed, and when we select a product that is not available/visible from one sales area to another and well this one simply does not appear.

The problem here that we displayed all the products that we have in different price lists so for that we cannot do the filtration using the schema selected because of IndexedDB limitations.

So what we did is when we add the product first we check if the product is belong to the price list of the selected schema and if not we cancel the click and show a notification to the user.

Note: for the schema that not has a price list we can add any product.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorLinkedDialog/KeymapEditorLinkedDialog.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorLinkedDialog/__test__/KeymapEditorLinkedDialog.test.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorLinkedDialog/stories/KeymapEditorLinkedDialog.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorKeymapsGrid/KeyMapEditorKeymapsGrid.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorKeymapsGrid/SchemaTags/SchemaTags.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorKeymapsGrid/SchemaTags/__test__/SchemaTags.test.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorKeymapsGrid/__test__/KeyMapEditorKeymapsGrid.test.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeymapEditorLinkedProduct/__test__/KeymapEditorLinkedProduct.test.jsx
---